All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: rsbecker@nexbridge.com, git@vger.kernel.org,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] run-command.c: need alloc.h for our own at-exit handler emulation
Date: Tue, 16 May 2023 11:44:36 -0700	[thread overview]
Message-ID: <xmqq353wune3.fsf@gitster.g> (raw)
In-Reply-To: <ZGPE9ozRChUJ3NGV@nand.local> (Taylor Blau's message of "Tue, 16 May 2023 14:01:26 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> OK, having now read both completely, I would say I have a vague
> preference for my version since it keeps the include at the top and
> unconditional, and has slightly more information in the patch message.
>
> But I do not prefer it so much over yours that I would be sad if you had
> already queued yours and didn't want to bother shuffling it around.

I do not have much preference between the two, either.  Both lack
one important description that we are reasonably confident that this
breakage is limited to run-command.c and no other files.

Thanks.

  reply	other threads:[~2023-05-16 18:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 16:58 [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW rsbecker
2023-05-16 17:06 ` Taylor Blau
2023-05-16 17:19   ` Junio C Hamano
2023-05-16 17:24     ` [PATCH] run-command.c: need alloc.h for our own at-exit handler emulation Junio C Hamano
2023-05-16 17:33       ` rsbecker
2023-05-16 17:57       ` Taylor Blau
2023-05-16 18:01         ` Taylor Blau
2023-05-16 18:44           ` Junio C Hamano [this message]
2023-05-16 18:47             ` Taylor Blau
2023-05-16 18:53               ` Junio C Hamano
2023-05-16 17:56   ` [PATCH] run-command.c: fix missing include under `NO_PTHREADS` Taylor Blau
2023-05-16 19:12     ` Junio C Hamano
2023-05-16 19:13       ` rsbecker
2023-05-16 21:33       ` Taylor Blau
2023-05-18  4:16         ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq353wune3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=newren@gmail.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.