All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Ze Gao <zegao2021@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vasily Gorbik <gor@linux.ibm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Conor Dooley <conor@kernel.org>, Yonghong Song <yhs@fb.com>,
	Ze Gao <zegao@tencent.com>
Subject: Re: [PATCH v2 0/4] Make fprobe + rethook immune to recursion
Date: Tue, 16 May 2023 23:42:34 +0200	[thread overview]
Message-ID: <ZGP4ypidaxQGdp7Y@krava> (raw)
In-Reply-To: <20230516071830.8190-1-zegao@tencent.com>

On Tue, May 16, 2023 at 03:18:26PM +0800, Ze Gao wrote:
> Hi all,
> 
> This is the 2nd version of patch series to fix the ftrace rethook recursion problem.
> 
> v1: https://lore.kernel.org/linux-trace-kernel/cover.1684120990.git.zegao@tencent.com/T/                                 +++#md4c0bae6a6cae28dadf2a2c6105ff140b35fddea
> 
> As Steven suggested, this version removes unnecessary notrace annotations from fprobe
> and rethook functions from v1 [PATCH 2,3,4/4] and replaces with makefile changes to filter
> out compiler flags which ftrace depends upon for rethook related objects.
> 
> Ze Gao (4):
>   rethook: use preempt_{disable, enable}_notrace in
>     rethook_trampoline_handler
>   fprobe: make fprobe_kprobe_handler recursion free
>   fprobe: add recursion detection in fprobe_exit_handler
>   rehook, fprobe: do not trace rethook related functions

hi,
what tree is this based on? I have troubles to apply that

thanks,
jirka

> 
>  arch/riscv/kernel/probes/Makefile |  2 +
>  arch/s390/kernel/Makefile         |  1 +
>  arch/x86/kernel/Makefile          |  1 +
>  kernel/trace/fprobe.c             | 72 ++++++++++++++++++++++++-------
>  kernel/trace/rethook.c            |  4 +-
>  5 files changed, 63 insertions(+), 17 deletions(-)
> 
> -- 
> 2.40.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <olsajiri@gmail.com>
To: Ze Gao <zegao2021@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vasily Gorbik <gor@linux.ibm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Conor Dooley <conor@kernel.org>, Yonghong Song <yhs@fb.com>,
	Ze Gao <zegao@tencent.com>
Subject: Re: [PATCH v2 0/4] Make fprobe + rethook immune to recursion
Date: Tue, 16 May 2023 23:42:34 +0200	[thread overview]
Message-ID: <ZGP4ypidaxQGdp7Y@krava> (raw)
In-Reply-To: <20230516071830.8190-1-zegao@tencent.com>

On Tue, May 16, 2023 at 03:18:26PM +0800, Ze Gao wrote:
> Hi all,
> 
> This is the 2nd version of patch series to fix the ftrace rethook recursion problem.
> 
> v1: https://lore.kernel.org/linux-trace-kernel/cover.1684120990.git.zegao@tencent.com/T/                                 +++#md4c0bae6a6cae28dadf2a2c6105ff140b35fddea
> 
> As Steven suggested, this version removes unnecessary notrace annotations from fprobe
> and rethook functions from v1 [PATCH 2,3,4/4] and replaces with makefile changes to filter
> out compiler flags which ftrace depends upon for rethook related objects.
> 
> Ze Gao (4):
>   rethook: use preempt_{disable, enable}_notrace in
>     rethook_trampoline_handler
>   fprobe: make fprobe_kprobe_handler recursion free
>   fprobe: add recursion detection in fprobe_exit_handler
>   rehook, fprobe: do not trace rethook related functions

hi,
what tree is this based on? I have troubles to apply that

thanks,
jirka

> 
>  arch/riscv/kernel/probes/Makefile |  2 +
>  arch/s390/kernel/Makefile         |  1 +
>  arch/x86/kernel/Makefile          |  1 +
>  kernel/trace/fprobe.c             | 72 ++++++++++++++++++++++++-------
>  kernel/trace/rethook.c            |  4 +-
>  5 files changed, 63 insertions(+), 17 deletions(-)
> 
> -- 
> 2.40.1
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-05-16 21:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16  7:18 [PATCH v2 0/4] Make fprobe + rethook immune to recursion Ze Gao
2023-05-16  7:18 ` Ze Gao
2023-05-16  7:18 ` [PATCH v2 1/4] rethook: use preempt_{disable, enable}_notrace in rethook_trampoline_handler Ze Gao
2023-05-16  7:18   ` Ze Gao
2023-05-16  7:18 ` [PATCH v2 2/4] fprobe: make fprobe_kprobe_handler recursion free Ze Gao
2023-05-16  7:18   ` Ze Gao
2023-05-16  9:15   ` Peter Zijlstra
2023-05-16  9:15     ` Peter Zijlstra
2023-05-16  9:35     ` Ze Gao
2023-05-16  9:35       ` Ze Gao
2023-05-16  9:18   ` Peter Zijlstra
2023-05-16  9:18     ` Peter Zijlstra
2023-05-16  9:47     ` Ze Gao
2023-05-16  9:47       ` Ze Gao
2023-05-16  9:51       ` Ze Gao
2023-05-16  9:51         ` Ze Gao
2023-05-16 16:03       ` Masami Hiramatsu
2023-05-16 16:03         ` Masami Hiramatsu
2023-05-17  1:54         ` Ze Gao
2023-05-17  1:54           ` Ze Gao
2023-05-17  2:54           ` Masami Hiramatsu
2023-05-17  2:54             ` Masami Hiramatsu
2023-05-17  3:10             ` Ze Gao
2023-05-17  3:10               ` Ze Gao
2023-05-17  3:25               ` Steven Rostedt
2023-05-17  3:25                 ` Steven Rostedt
2023-05-17  3:51                 ` Masami Hiramatsu
2023-05-17  3:51                   ` Masami Hiramatsu
2023-05-17  4:51                 ` Ze Gao
2023-05-17  4:51                   ` Ze Gao
2023-05-16  7:18 ` [PATCH v2 3/4] fprobe: add recursion detection in fprobe_exit_handler Ze Gao
2023-05-16  7:18   ` Ze Gao
2023-05-16  7:18 ` [PATCH v2 4/4] rehook, fprobe: do not trace rethook related functions Ze Gao
2023-05-16  7:18   ` Ze Gao
2023-05-16 14:20   ` Steven Rostedt
2023-05-16 14:20     ` Steven Rostedt
2023-05-17  2:00     ` Ze Gao
2023-05-17  2:00       ` Ze Gao
2023-05-16 16:05   ` Masami Hiramatsu
2023-05-16 16:05     ` Masami Hiramatsu
2023-05-16 21:42 ` Jiri Olsa [this message]
2023-05-16 21:42   ` [PATCH v2 0/4] Make fprobe + rethook immune to recursion Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGP4ypidaxQGdp7Y@krava \
    --to=olsajiri@gmail.com \
    --cc=agordeev@linux.ibm.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=ast@kernel.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=conor@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rostedt@goodmis.org \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yhs@fb.com \
    --cc=zegao2021@gmail.com \
    --cc=zegao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.