* [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
@ 2022-02-25 1:29 Jim Mattson
2022-02-25 1:32 ` Sean Christopherson
2023-05-19 17:42 ` Paolo Bonzini
0 siblings, 2 replies; 7+ messages in thread
From: Jim Mattson @ 2022-02-25 1:29 UTC (permalink / raw)
To: kvm, pbonzini; +Cc: Jacob Xu, Sean Christopherson, Jim Mattson
From: Jacob Xu <jacobhxu@google.com>
Include a definition of WARN_ON_ONCE() before using it.
Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT")
Cc: Sean Christopherson <seanjc@google.com>
Signed-off-by: Jacob Xu <jacobhxu@google.com>
[reworded commit message; changed <asm/bug.h> to <linux/bug.h>]
Signed-off-by: Jim Mattson <jmattson@google.com>
---
arch/x86/include/asm/vmx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 0ffaa3156a4e..447b97296400 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -14,6 +14,7 @@
#include <linux/bitops.h>
#include <linux/types.h>
+#include <linux/bug.h>
#include <uapi/asm/vmx.h>
#include <asm/vmxfeatures.h>
--
2.35.1.574.g5d30c73bfb-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2022-02-25 1:29 [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h Jim Mattson
@ 2022-02-25 1:32 ` Sean Christopherson
2022-02-25 1:34 ` Jim Mattson
2023-05-16 21:40 ` Jim Mattson
2023-05-19 17:42 ` Paolo Bonzini
1 sibling, 2 replies; 7+ messages in thread
From: Sean Christopherson @ 2022-02-25 1:32 UTC (permalink / raw)
To: Jim Mattson; +Cc: kvm, pbonzini
On Thu, Feb 24, 2022, Jim Mattson wrote:
> From: Jacob Xu <jacobhxu@google.com>
>
> Include a definition of WARN_ON_ONCE() before using it.
>
> Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT")
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jacob Xu <jacobhxu@google.com>
> [reworded commit message; changed <asm/bug.h> to <linux/bug.h>]
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/include/asm/vmx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 0ffaa3156a4e..447b97296400 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -14,6 +14,7 @@
>
> #include <linux/bitops.h>
> #include <linux/types.h>
> +#include <linux/bug.h>
Paolo, any chance you want to put these in alphabetical order when applying? :-)
Reviewed-by: Sean Christopherson <seanjc@google.com>
> #include <uapi/asm/vmx.h>
> #include <asm/vmxfeatures.h>
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2022-02-25 1:32 ` Sean Christopherson
@ 2022-02-25 1:34 ` Jim Mattson
2022-04-08 21:07 ` Jim Mattson
2023-05-16 21:40 ` Jim Mattson
1 sibling, 1 reply; 7+ messages in thread
From: Jim Mattson @ 2022-02-25 1:34 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kvm, pbonzini
On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote:
> Paolo, any chance you want to put these in alphabetical order when applying? :-)
Alphabetical?!? Not reverse fir tree?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2022-02-25 1:34 ` Jim Mattson
@ 2022-04-08 21:07 ` Jim Mattson
0 siblings, 0 replies; 7+ messages in thread
From: Jim Mattson @ 2022-04-08 21:07 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kvm, pbonzini
On Thu, Feb 24, 2022 at 5:34 PM Jim Mattson <jmattson@google.com> wrote:
>
> On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote:
>
> > Paolo, any chance you want to put these in alphabetical order when applying? :-)
>
> Alphabetical?!? Not reverse fir tree?
Any order is fine with me, actually.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2022-02-25 1:32 ` Sean Christopherson
2022-02-25 1:34 ` Jim Mattson
@ 2023-05-16 21:40 ` Jim Mattson
2023-05-16 23:11 ` Sean Christopherson
1 sibling, 1 reply; 7+ messages in thread
From: Jim Mattson @ 2023-05-16 21:40 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kvm, pbonzini
On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Thu, Feb 24, 2022, Jim Mattson wrote:
> > From: Jacob Xu <jacobhxu@google.com>
> >
> > Include a definition of WARN_ON_ONCE() before using it.
> >
> > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT")
> > Cc: Sean Christopherson <seanjc@google.com>
> > Signed-off-by: Jacob Xu <jacobhxu@google.com>
> > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>]
> > Signed-off-by: Jim Mattson <jmattson@google.com>
> > ---
> > arch/x86/include/asm/vmx.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> > index 0ffaa3156a4e..447b97296400 100644
> > --- a/arch/x86/include/asm/vmx.h
> > +++ b/arch/x86/include/asm/vmx.h
> > @@ -14,6 +14,7 @@
> >
> > #include <linux/bitops.h>
> > #include <linux/types.h>
> > +#include <linux/bug.h>
>
> Paolo, any chance you want to put these in alphabetical order when applying? :-)
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
> > #include <uapi/asm/vmx.h>
> > #include <asm/vmxfeatures.h>
> >
Ping.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2023-05-16 21:40 ` Jim Mattson
@ 2023-05-16 23:11 ` Sean Christopherson
0 siblings, 0 replies; 7+ messages in thread
From: Sean Christopherson @ 2023-05-16 23:11 UTC (permalink / raw)
To: Jim Mattson; +Cc: kvm, pbonzini
On Tue, May 16, 2023, Jim Mattson wrote:
> On Thu, Feb 24, 2022 at 5:32 PM Sean Christopherson <seanjc@google.com> wrote:
> >
> > On Thu, Feb 24, 2022, Jim Mattson wrote:
> > > From: Jacob Xu <jacobhxu@google.com>
> > >
> > > Include a definition of WARN_ON_ONCE() before using it.
> > >
> > > Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT")
> > > Cc: Sean Christopherson <seanjc@google.com>
> > > Signed-off-by: Jacob Xu <jacobhxu@google.com>
> > > [reworded commit message; changed <asm/bug.h> to <linux/bug.h>]
> > > Signed-off-by: Jim Mattson <jmattson@google.com>
> > > ---
> > > arch/x86/include/asm/vmx.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> > > index 0ffaa3156a4e..447b97296400 100644
> > > --- a/arch/x86/include/asm/vmx.h
> > > +++ b/arch/x86/include/asm/vmx.h
> > > @@ -14,6 +14,7 @@
> > >
> > > #include <linux/bitops.h>
> > > #include <linux/types.h>
> > > +#include <linux/bug.h>
> >
> > Paolo, any chance you want to put these in alphabetical order when applying? :-)
> >
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> >
> > > #include <uapi/asm/vmx.h>
> > > #include <asm/vmxfeatures.h>
> > >
>
> Ping.
I'll grab this for 6.5 unless Paolo beats me to the punch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h
2022-02-25 1:29 [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h Jim Mattson
2022-02-25 1:32 ` Sean Christopherson
@ 2023-05-19 17:42 ` Paolo Bonzini
1 sibling, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2023-05-19 17:42 UTC (permalink / raw)
To: Jim Mattson, kvm; +Cc: Jacob Xu, Sean Christopherson
On 2/25/22 02:29, Jim Mattson wrote:
> From: Jacob Xu <jacobhxu@google.com>
>
> Include a definition of WARN_ON_ONCE() before using it.
>
> Fixes: bb1fcc70d98f ("KVM: nVMX: Allow L1 to use 5-level page walks for nested EPT")
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Jacob Xu <jacobhxu@google.com>
> [reworded commit message; changed <asm/bug.h> to <linux/bug.h>]
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/include/asm/vmx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 0ffaa3156a4e..447b97296400 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -14,6 +14,7 @@
>
> #include <linux/bitops.h>
> #include <linux/types.h>
> +#include <linux/bug.h>
> #include <uapi/asm/vmx.h>
> #include <asm/vmxfeatures.h>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-19 17:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 1:29 [PATCH] KVM: VMX: Fix header file dependency of asm/vmx.h Jim Mattson
2022-02-25 1:32 ` Sean Christopherson
2022-02-25 1:34 ` Jim Mattson
2022-04-08 21:07 ` Jim Mattson
2023-05-16 21:40 ` Jim Mattson
2023-05-16 23:11 ` Sean Christopherson
2023-05-19 17:42 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.