From: Vinod Koul <vkoul@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
Date: Fri, 19 May 2023 16:16:56 +0530 [thread overview]
Message-ID: <ZGdToIv95DkTrObb@matsya> (raw)
In-Reply-To: <2b7eef56-9409-46bd-bcf7-dea054adfccd@app.fastmail.com>
On 18-05-23, 13:59, Arnd Bergmann wrote:
> On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> > On 17-05-23, 22:19, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
> >> wide, causing a warning about the format string:
> >>
> >> drivers/dma/ste_dma40.c: In function 'd40_probe':
> >> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> >> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
> >>
> >> Change both to the special %pap and %pap helpers for these types.
> >
> > Already posted [1] and applied now
> >
> > [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org
>
> I think yours is wrong: you use %pR with a resource_size_t, but it
> expects a "struct resource instead".
Right, i indeed looked up wrong format
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
Date: Fri, 19 May 2023 16:16:56 +0530 [thread overview]
Message-ID: <ZGdToIv95DkTrObb@matsya> (raw)
In-Reply-To: <2b7eef56-9409-46bd-bcf7-dea054adfccd@app.fastmail.com>
On 18-05-23, 13:59, Arnd Bergmann wrote:
> On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> > On 17-05-23, 22:19, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
> >> wide, causing a warning about the format string:
> >>
> >> drivers/dma/ste_dma40.c: In function 'd40_probe':
> >> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> >> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
> >>
> >> Change both to the special %pap and %pap helpers for these types.
> >
> > Already posted [1] and applied now
> >
> > [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org
>
> I think yours is wrong: you use %pR with a resource_size_t, but it
> expects a "struct resource instead".
Right, i indeed looked up wrong format
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-19 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 20:19 [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t Arnd Bergmann
2023-05-17 20:19 ` Arnd Bergmann
2023-05-18 11:29 ` Vinod Koul
2023-05-18 11:29 ` Vinod Koul
2023-05-18 11:59 ` Arnd Bergmann
2023-05-18 11:59 ` Arnd Bergmann
2023-05-19 10:46 ` Vinod Koul [this message]
2023-05-19 10:46 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGdToIv95DkTrObb@matsya \
--to=vkoul@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.