All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
Date: Mon, 5 Jun 2023 17:04:08 +0200	[thread overview]
Message-ID: <ZH35aKO5BlAPERPB@ashyti-mobl2.lan> (raw)
In-Reply-To: <2bc9cf75-e8b8-5a98-682b-630685bbe839@linux.intel.com>

On Mon, Jun 05, 2023 at 10:16:22AM +0100, Tvrtko Ursulin wrote:
> 
> On 05/06/2023 09:53, Tvrtko Ursulin wrote:
> > 
> > On 31/05/2023 18:10, fei.yang@intel.com wrote:
> > > From: Fei Yang <fei.yang@intel.com>
> > > 
> > > This series introduce a new extension for GEM_CREATE,
> > > 1. end support for set caching ioctl [PATCH 1/2]
> > > 2. add set_pat extension for gem_create [PATCH 2/2]
> > > 
> > > v2: drop one patch that was merged separately
> > >      commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
> > > v3: rebased on https://patchwork.freedesktop.org/series/117082/
> > > v4: fix missing unlock introduced in v3, and
> > >      solve a rebase conflict
> > > v5: replace obj->cache_level with pat_set_by_user,
> > >      fix i915_cache_level_str() for legacy platforms.
> > > v6: rebased on https://patchwork.freedesktop.org/series/117480/
> > > v7: rebased on https://patchwork.freedesktop.org/series/117528/
> > > v8: dropped the two dependent patches that has been merged
> > >      separately. Add IGT link and Tested-by (MESA).
> > > v9: addressing comments (Andi)
> > > v10: acked-by and tested-by MESA
> > > v11: drop "end support for set caching ioctl" (merged)
> > >       remove tools/include/uapi/drm/i915_drm.h
> > > v12: drop Bspec reference in comment. add to commit message instead
> > > v13: sent to test with igt@gem_create@create-ext-set-pat
> > > v14: sent to test with igt@gem_create@create-ext-set-pat
> > > v15: update commit message with documentation note and t-b/a-b from
> > >       Media driver folks.
> > > 
> > > Fei Yang (1):
> > >    drm/i915: Allow user to set cache at BO creation
> > > 
> > >   drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++++++++++++++++++
> > >   drivers/gpu/drm/i915/gem/i915_gem_object.c |  6 ++++
> > >   include/uapi/drm/i915_drm.h                | 41 ++++++++++++++++++++++
> > >   3 files changed, 83 insertions(+)
> > > 
> > 
> > Try with:
> > 
> > Test-with: 20230526172221.1438998-1-fei.yang@intel.com
> > 
> > That is how it is supposed to be done, to do a CI run against a test
> > case not yet merged that is.
> 
> Or I see that IGT has been since merged so you probably have results
> already?

CI has stopped somewhere in the BAT tests. Can anyone hit the
"Test revision 1 again" button? Fei, would you?

We had it tested some revisions back, though.

Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	fei.yang@intel.com
Subject: Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation
Date: Mon, 5 Jun 2023 17:04:08 +0200	[thread overview]
Message-ID: <ZH35aKO5BlAPERPB@ashyti-mobl2.lan> (raw)
In-Reply-To: <2bc9cf75-e8b8-5a98-682b-630685bbe839@linux.intel.com>

On Mon, Jun 05, 2023 at 10:16:22AM +0100, Tvrtko Ursulin wrote:
> 
> On 05/06/2023 09:53, Tvrtko Ursulin wrote:
> > 
> > On 31/05/2023 18:10, fei.yang@intel.com wrote:
> > > From: Fei Yang <fei.yang@intel.com>
> > > 
> > > This series introduce a new extension for GEM_CREATE,
> > > 1. end support for set caching ioctl [PATCH 1/2]
> > > 2. add set_pat extension for gem_create [PATCH 2/2]
> > > 
> > > v2: drop one patch that was merged separately
> > >      commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function")
> > > v3: rebased on https://patchwork.freedesktop.org/series/117082/
> > > v4: fix missing unlock introduced in v3, and
> > >      solve a rebase conflict
> > > v5: replace obj->cache_level with pat_set_by_user,
> > >      fix i915_cache_level_str() for legacy platforms.
> > > v6: rebased on https://patchwork.freedesktop.org/series/117480/
> > > v7: rebased on https://patchwork.freedesktop.org/series/117528/
> > > v8: dropped the two dependent patches that has been merged
> > >      separately. Add IGT link and Tested-by (MESA).
> > > v9: addressing comments (Andi)
> > > v10: acked-by and tested-by MESA
> > > v11: drop "end support for set caching ioctl" (merged)
> > >       remove tools/include/uapi/drm/i915_drm.h
> > > v12: drop Bspec reference in comment. add to commit message instead
> > > v13: sent to test with igt@gem_create@create-ext-set-pat
> > > v14: sent to test with igt@gem_create@create-ext-set-pat
> > > v15: update commit message with documentation note and t-b/a-b from
> > >       Media driver folks.
> > > 
> > > Fei Yang (1):
> > >    drm/i915: Allow user to set cache at BO creation
> > > 
> > >   drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++++++++++++++++++
> > >   drivers/gpu/drm/i915/gem/i915_gem_object.c |  6 ++++
> > >   include/uapi/drm/i915_drm.h                | 41 ++++++++++++++++++++++
> > >   3 files changed, 83 insertions(+)
> > > 
> > 
> > Try with:
> > 
> > Test-with: 20230526172221.1438998-1-fei.yang@intel.com
> > 
> > That is how it is supposed to be done, to do a CI run against a test
> > case not yet merged that is.
> 
> Or I see that IGT has been since merged so you probably have results
> already?

CI has stopped somewhere in the BAT tests. Can anyone hit the
"Test revision 1 again" button? Fei, would you?

We had it tested some revisions back, though.

Andi

  reply	other threads:[~2023-06-05 15:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 17:10 [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation fei.yang
2023-05-31 17:10 ` fei.yang
2023-05-31 17:10 ` [Intel-gfx] [PATCH v15 1/1] " fei.yang
2023-05-31 17:10   ` fei.yang
2023-06-04 18:44   ` [Intel-gfx] " Andi Shyti
2023-06-04 18:44     ` Andi Shyti
2023-06-05  2:52     ` [Intel-gfx] " Yang, Fei
2023-06-05  2:52       ` Yang, Fei
2023-06-05  9:11   ` [Intel-gfx] " Tvrtko Ursulin
2023-06-05 16:47     ` Yang, Fei
2023-06-06  6:51       ` Yang, Fei
2023-06-06  7:57         ` Joonas Lahtinen
2023-06-01  0:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-06-01  0:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-06-01  1:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-06-05  8:53 ` [Intel-gfx] [PATCH v15 0/1] " Tvrtko Ursulin
2023-06-05  9:16   ` Tvrtko Ursulin
2023-06-05 15:04     ` Andi Shyti [this message]
2023-06-05 15:04       ` Andi Shyti
2023-06-05 15:09     ` Yang, Fei
2023-06-05 21:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Allow user to set cache at BO creation (rev2) Patchwork
2023-06-05 21:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-06-05 21:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-06 21:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZH35aKO5BlAPERPB@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.