From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Russell Harmon <eatnumber1@gmail.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com, snitzer@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v4 2/4] Documentation: dm-integrity: Document the meaning of "buffer".
Date: Tue, 6 Jun 2023 09:18:32 +0700 [thread overview]
Message-ID: <ZH6XeM4Uir4zQMn6@debian.me> (raw)
In-Reply-To: <20230605050853.6240-3-eatnumber1@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 794 bytes --]
On Sun, Jun 04, 2023 at 10:08:51PM -0700, Russell Harmon wrote:
> +Accesses to the on-disk metadata area containing checksums (aka tags) are
> +buffered using dm-bufio. When an access to any given metadata area
> +occurs, each unique metadata area gets its own buffer(s). The buffer size
> +is capped at the size of the metadata area, but may be smaller, thereby
> +requiring multiple buffers to represent the full metadata area. A smaller
> +buffer size will produce a smaller resulting read/write operation to the
> +metadata area for small reads/writes. The metadata is still read even in
> +a full write to the data covered by a single buffer.
> +
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 98 bytes --]
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Russell Harmon <eatnumber1@gmail.com>
Cc: mpatocka@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 2/4] Documentation: dm-integrity: Document the meaning of "buffer".
Date: Tue, 6 Jun 2023 09:18:32 +0700 [thread overview]
Message-ID: <ZH6XeM4Uir4zQMn6@debian.me> (raw)
In-Reply-To: <20230605050853.6240-3-eatnumber1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Sun, Jun 04, 2023 at 10:08:51PM -0700, Russell Harmon wrote:
> +Accesses to the on-disk metadata area containing checksums (aka tags) are
> +buffered using dm-bufio. When an access to any given metadata area
> +occurs, each unique metadata area gets its own buffer(s). The buffer size
> +is capped at the size of the metadata area, but may be smaller, thereby
> +requiring multiple buffers to represent the full metadata area. A smaller
> +buffer size will produce a smaller resulting read/write operation to the
> +metadata area for small reads/writes. The metadata is still read even in
> +a full write to the data covered by a single buffer.
> +
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-06 6:45 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 0:20 [dm-devel] [PATCH] Improve the dm-integrity documentation Russell Harmon
2023-06-03 10:02 ` Russell Harmon
2023-06-03 12:50 ` Bagas Sanjaya
2023-06-03 12:50 ` Bagas Sanjaya
2023-06-03 12:45 ` Bagas Sanjaya
2023-06-03 12:45 ` Bagas Sanjaya
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` [dm-devel] [PATCH 1/4] Fix minor grammatical error in dm-integrity.rst Russell Harmon
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` [dm-devel] [PATCH 2/4] Documents the meaning of "buffer" in dm-integrity Russell Harmon
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` [dm-devel] [PATCH 3/4] Document dm-integrity default values Russell Harmon
2023-06-03 20:15 ` Russell Harmon
2023-06-03 20:15 ` [dm-devel] [PATCH 4/4] Document an example of how the tunables relate in dm-integrity Russell Harmon
2023-06-03 20:15 ` Russell Harmon
2023-06-04 14:07 ` [dm-devel] [PATCH] Improve the dm-integrity documentation Bagas Sanjaya
2023-06-04 14:07 ` Bagas Sanjaya
2023-06-04 18:25 ` [dm-devel] " Russell Harmon
2023-06-04 18:25 ` Russell Harmon
2023-06-04 19:06 ` [dm-devel] [PATCH v3 0/4] " Russell Harmon
2023-06-04 19:06 ` Russell Harmon
2023-06-04 19:06 ` [dm-devel] [PATCH v3 1/4] Fix minor grammatical error in dm-integrity.rst Russell Harmon
2023-06-04 19:06 ` Russell Harmon
2023-06-05 3:03 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:03 ` Bagas Sanjaya
2023-06-05 5:00 ` [dm-devel] " Russell Harmon
2023-06-05 5:00 ` Russell Harmon
2023-06-04 19:06 ` [dm-devel] [PATCH v3 2/4] Documents the meaning of "buffer" in dm-integrity Russell Harmon
2023-06-04 19:06 ` Russell Harmon
2023-06-05 3:05 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:05 ` Bagas Sanjaya
2023-06-05 3:07 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:07 ` Bagas Sanjaya
2023-06-05 5:01 ` [dm-devel] " Russell Harmon
2023-06-05 5:01 ` Russell Harmon
2023-06-04 19:06 ` [dm-devel] [PATCH v3 3/4] Document dm-integrity default values Russell Harmon
2023-06-04 19:06 ` Russell Harmon
2023-06-05 3:16 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:16 ` Bagas Sanjaya
2023-06-05 5:05 ` [dm-devel] " Russell Harmon
2023-06-05 5:05 ` Russell Harmon
2023-06-05 13:23 ` [dm-devel] " Jonathan Corbet
2023-06-05 13:23 ` Jonathan Corbet
2023-06-06 2:16 ` [dm-devel] " Bagas Sanjaya
2023-06-06 2:16 ` Bagas Sanjaya
2023-06-04 19:06 ` [dm-devel] [PATCH v3 4/4] Document an example of how the tunables relate in dm-integrity Russell Harmon
2023-06-04 19:06 ` Russell Harmon
2023-06-05 3:17 ` [dm-devel] " Bagas Sanjaya
2023-06-05 3:17 ` Bagas Sanjaya
2023-06-05 5:05 ` [dm-devel] " Russell Harmon
2023-06-05 5:05 ` Russell Harmon
2023-06-05 5:08 ` [dm-devel] [PATCH v4 0/4] Improve the dm-integrity documentation Russell Harmon
2023-06-05 5:08 ` Russell Harmon
2023-06-05 5:08 ` [dm-devel] [PATCH v4 1/4] Documentation: dm-integrity: Fix minor grammatical error Russell Harmon
2023-06-05 5:08 ` Russell Harmon
2023-06-06 2:17 ` [dm-devel] " Bagas Sanjaya
2023-06-06 2:17 ` Bagas Sanjaya
2023-06-05 5:08 ` [dm-devel] [PATCH v4 2/4] Documentation: dm-integrity: Document the meaning of "buffer" Russell Harmon
2023-06-05 5:08 ` Russell Harmon
2023-06-06 2:18 ` Bagas Sanjaya [this message]
2023-06-06 2:18 ` Bagas Sanjaya
2023-06-05 5:08 ` [dm-devel] [PATCH v4 3/4] Documentation: dm-integrity: Document default values Russell Harmon
2023-06-05 5:08 ` Russell Harmon
2023-06-05 5:08 ` [dm-devel] [PATCH v4 4/4] Documentation: dm-integrity: Document an example of how the tunables relate Russell Harmon
2023-06-05 5:08 ` Russell Harmon
2023-06-17 19:37 ` [dm-devel] " Russell Harmon
2023-06-17 19:37 ` Russell Harmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH6XeM4Uir4zQMn6@debian.me \
--to=bagasdotme@gmail.com \
--cc=dm-devel@redhat.com \
--cc=eatnumber1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.