From: Oliver Upton <oliver.upton@linux.dev>
To: Jun Miao <jun.miao@intel.com>
Cc: maz@kernel.org, oliver.upton@linux.de, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH] KVM: arm64: fix typo
Date: Fri, 26 May 2023 08:35:17 +0000 [thread overview]
Message-ID: <ZHBvRe9ejErYwB0t@linux.dev> (raw)
In-Reply-To: <20230526081548.12729-1-jun.miao@intel.com>
Hi Jun,
The shortlog is too vague. While typo fixes don't need to be
exhaustively described, 'Fix typo' doesn't give any indication as to
where it is.
KVM: arm64: Fix comment typo in hyp_back_vmemmap()
On Fri, May 26, 2023 at 04:15:48PM +0800, Jun Miao wrote:
> Change "begining" to "beginning"
>
> Fixes: 8e6bcc3a4502 ("KVM: arm64: Back the hypervisor 'struct hyp_page' array for all memory")
This is a misuse of the Fixes tag. A typo in a comment is not a bug.
> Signed-off-by: Jun Miao <jun.miao@intel.com>
> ---
> arch/arm64/kvm/hyp/nvhe/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/mm.c b/arch/arm64/kvm/hyp/nvhe/mm.c
> index 318298eb3d6b..f16d9f38bb48 100644
> --- a/arch/arm64/kvm/hyp/nvhe/mm.c
> +++ b/arch/arm64/kvm/hyp/nvhe/mm.c
> @@ -145,7 +145,7 @@ int hyp_back_vmemmap(phys_addr_t back)
> start = hyp_memory[i].base;
> start = ALIGN_DOWN((u64)hyp_phys_to_page(start), PAGE_SIZE);
> /*
> - * The begining of the hyp_vmemmap region for the current
> + * The beginning of the hyp_vmemmap region for the current
> * memblock may already be backed by the page backing the end
> * the previous region, so avoid mapping it twice.
> */
> --
> 2.32.0
>
>
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Jun Miao <jun.miao@intel.com>
Cc: maz@kernel.org, oliver.upton@linux.de, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH] KVM: arm64: fix typo
Date: Fri, 26 May 2023 08:35:17 +0000 [thread overview]
Message-ID: <ZHBvRe9ejErYwB0t@linux.dev> (raw)
In-Reply-To: <20230526081548.12729-1-jun.miao@intel.com>
Hi Jun,
The shortlog is too vague. While typo fixes don't need to be
exhaustively described, 'Fix typo' doesn't give any indication as to
where it is.
KVM: arm64: Fix comment typo in hyp_back_vmemmap()
On Fri, May 26, 2023 at 04:15:48PM +0800, Jun Miao wrote:
> Change "begining" to "beginning"
>
> Fixes: 8e6bcc3a4502 ("KVM: arm64: Back the hypervisor 'struct hyp_page' array for all memory")
This is a misuse of the Fixes tag. A typo in a comment is not a bug.
> Signed-off-by: Jun Miao <jun.miao@intel.com>
> ---
> arch/arm64/kvm/hyp/nvhe/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/mm.c b/arch/arm64/kvm/hyp/nvhe/mm.c
> index 318298eb3d6b..f16d9f38bb48 100644
> --- a/arch/arm64/kvm/hyp/nvhe/mm.c
> +++ b/arch/arm64/kvm/hyp/nvhe/mm.c
> @@ -145,7 +145,7 @@ int hyp_back_vmemmap(phys_addr_t back)
> start = hyp_memory[i].base;
> start = ALIGN_DOWN((u64)hyp_phys_to_page(start), PAGE_SIZE);
> /*
> - * The begining of the hyp_vmemmap region for the current
> + * The beginning of the hyp_vmemmap region for the current
> * memblock may already be backed by the page backing the end
> * the previous region, so avoid mapping it twice.
> */
> --
> 2.32.0
>
>
--
Thanks,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-26 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 8:15 [PATCH] KVM: arm64: fix typo Jun Miao
2023-05-26 8:15 ` Jun Miao
2023-05-26 8:35 ` Oliver Upton [this message]
2023-05-26 8:35 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHBvRe9ejErYwB0t@linux.dev \
--to=oliver.upton@linux.dev \
--cc=james.morse@arm.com \
--cc=jun.miao@intel.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.