* [PATCH] perf ftrace latency: Remove unnecessary "--" from --use-nsec option
@ 2023-05-25 21:20 Namhyung Kim
2023-05-26 18:19 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2023-05-25 21:20 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ian Rogers, Adrian Hunter, Peter Zijlstra, Ingo Molnar, LKML,
linux-perf-users, Changbin Du
The option name should not have the dashes. Current version shows four
dashes for the option.
$ perf ftrace latency -h
Usage: perf ftrace [<options>] [<command>]
or: perf ftrace [<options>] -- [<command>] [<options>]
or: perf ftrace {trace|latency} [<options>] [<command>]
or: perf ftrace {trace|latency} [<options>] -- [<command>] [<options>]
-b, --use-bpf Use BPF to measure function latency
-n, ----use-nsec Use nano-second histogram
-T, --trace-funcs <func>
Show latency of given function
Fixes: 84005bb61486 ("perf ftrace latency: Add -n/--use-nsec option")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index ad2a9ae041f6..ac2e6c75f912 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -1177,7 +1177,7 @@ int cmd_ftrace(int argc, const char **argv)
OPT_BOOLEAN('b', "use-bpf", &ftrace.target.use_bpf,
"Use BPF to measure function latency"),
#endif
- OPT_BOOLEAN('n', "--use-nsec", &ftrace.use_nsec,
+ OPT_BOOLEAN('n', "use-nsec", &ftrace.use_nsec,
"Use nano-second histogram"),
OPT_PARENT(common_options),
};
--
2.41.0.rc0.172.g3f132b7071-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf ftrace latency: Remove unnecessary "--" from --use-nsec option
2023-05-25 21:20 [PATCH] perf ftrace latency: Remove unnecessary "--" from --use-nsec option Namhyung Kim
@ 2023-05-26 18:19 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-05-26 18:19 UTC (permalink / raw)
To: Namhyung Kim
Cc: Jiri Olsa, Ian Rogers, Adrian Hunter, Peter Zijlstra, Ingo Molnar,
LKML, linux-perf-users, Changbin Du
Em Thu, May 25, 2023 at 02:20:38PM -0700, Namhyung Kim escreveu:
> The option name should not have the dashes. Current version shows four
> dashes for the option.
>
> $ perf ftrace latency -h
>
> Usage: perf ftrace [<options>] [<command>]
> or: perf ftrace [<options>] -- [<command>] [<options>]
> or: perf ftrace {trace|latency} [<options>] [<command>]
> or: perf ftrace {trace|latency} [<options>] -- [<command>] [<options>]
>
> -b, --use-bpf Use BPF to measure function latency
> -n, ----use-nsec Use nano-second histogram
> -T, --trace-funcs <func>
> Show latency of given function
Thanks, applied.
- Arnaldo
> Fixes: 84005bb61486 ("perf ftrace latency: Add -n/--use-nsec option")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
> index ad2a9ae041f6..ac2e6c75f912 100644
> --- a/tools/perf/builtin-ftrace.c
> +++ b/tools/perf/builtin-ftrace.c
> @@ -1177,7 +1177,7 @@ int cmd_ftrace(int argc, const char **argv)
> OPT_BOOLEAN('b', "use-bpf", &ftrace.target.use_bpf,
> "Use BPF to measure function latency"),
> #endif
> - OPT_BOOLEAN('n', "--use-nsec", &ftrace.use_nsec,
> + OPT_BOOLEAN('n', "use-nsec", &ftrace.use_nsec,
> "Use nano-second histogram"),
> OPT_PARENT(common_options),
> };
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-26 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 21:20 [PATCH] perf ftrace latency: Remove unnecessary "--" from --use-nsec option Namhyung Kim
2023-05-26 18:19 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.