From: Matthew Wilcox <willy@infradead.org>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: linux-nvme@lists.infradead.org,
James.Bottomley@hansenpartnership.com, linux-mm@kvack.org,
dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
Alasdair Kergon <agk@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, gost.dev@samsung.com,
nitheshshetty@gmail.com, James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
anuj20.g@samsung.com, Mike Snitzer <snitzer@kernel.org>,
ming.lei@redhat.com, linux-block@vger.kernel.org,
dlemoal@kernel.org, Keith Busch <kbusch@kernel.org>,
bvanassche@acm.org, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
joshi.k@samsung.com, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [dm-devel] [PATCH v11 2/9] block: Add copy offload support infrastructure
Date: Mon, 29 May 2023 18:55:10 +0100 [thread overview]
Message-ID: <ZHTm/v1jTZhcpDei@casper.infradead.org> (raw)
In-Reply-To: <20230522104146.2856-3-nj.shetty@samsung.com>
On Mon, May 22, 2023 at 04:11:33PM +0530, Nitesh Shetty wrote:
> + token = alloc_page(gfp_mask);
Why is PAGE_SIZE the right size for 'token'? That seems quite unlikely.
I could understand it being SECTOR_SIZE or something that's dependent on
the device, but I cannot fathom it being dependent on the host' page size.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com, bvanassche@acm.org,
hare@suse.de, ming.lei@redhat.com, dlemoal@kernel.org,
anuj20.g@samsung.com, joshi.k@samsung.com,
nitheshshetty@gmail.com, gost.dev@samsung.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v11 2/9] block: Add copy offload support infrastructure
Date: Mon, 29 May 2023 18:55:10 +0100 [thread overview]
Message-ID: <ZHTm/v1jTZhcpDei@casper.infradead.org> (raw)
In-Reply-To: <20230522104146.2856-3-nj.shetty@samsung.com>
On Mon, May 22, 2023 at 04:11:33PM +0530, Nitesh Shetty wrote:
> + token = alloc_page(gfp_mask);
Why is PAGE_SIZE the right size for 'token'? That seems quite unlikely.
I could understand it being SECTOR_SIZE or something that's dependent on
the device, but I cannot fathom it being dependent on the host' page size.
next prev parent reply other threads:[~2023-05-29 18:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230522104508epcas5p13f99359d0af12453e0e4bc7f4bae23f0@epcas5p1.samsung.com>
2023-05-22 10:41 ` [dm-devel] [PATCH v11 0/9] Implement copy offload support Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 1/9] block: Introduce queue limits for copy-offload support Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 11:45 ` [dm-devel] " Damien Le Moal
2023-05-22 11:45 ` Damien Le Moal
2023-05-23 7:15 ` [dm-devel] " Nitesh Shetty
2023-05-23 7:15 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 2/9] block: Add copy offload support infrastructure Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-24 15:40 ` [dm-devel] " Darrick J. Wong
2023-05-24 15:40 ` Darrick J. Wong
2023-05-29 16:36 ` Nitesh Shetty
2023-05-29 16:36 ` Nitesh Shetty
2023-05-29 17:55 ` Matthew Wilcox [this message]
2023-05-29 17:55 ` Matthew Wilcox
2023-05-30 10:17 ` [dm-devel] " Nitesh Shetty
2023-05-30 10:17 ` Nitesh Shetty
2023-05-30 11:29 ` [dm-devel] " Maurizio Lombardi
2023-05-30 11:29 ` Maurizio Lombardi
2023-05-30 12:10 ` [dm-devel] " Nitesh Shetty
2023-05-30 12:10 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 3/9] block: add emulation for copy Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 4/9] fs, block: copy_file_range for def_blk_ops for direct block device Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 5/9] nvme: add copy offload support Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 6/9] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 7/9] dm: Add support for copy offload Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 8/9] dm: Enable copy offload for dm-linear target Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
2023-05-22 10:41 ` [dm-devel] [PATCH v11 9/9] null_blk: add support for copy offload Nitesh Shetty
2023-05-22 10:41 ` Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHTm/v1jTZhcpDei@casper.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.