All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Holzheu <holzheu@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/6] kexec: delete a useless check in crash_shrink_memory()
Date: Wed, 31 May 2023 15:41:20 +0800	[thread overview]
Message-ID: <ZHb6IFhwRMkAkNjt@MiWiFi-R3L-srv> (raw)
In-Reply-To: <5beb1883-5391-1b75-d8cd-2152478b9e72@huawei.com>

On 05/31/23 at 10:19am, Leizhen (ThunderTown) wrote:
> 
> 
> On 2023/5/31 8:17, Baoquan He wrote:
> > On 05/27/23 at 08:34pm, Zhen Lei wrote:
> >> The check '(crashk_res.parent != NULL)' is added by
> >> commit e05bd3367bd3 ("kexec: fix Oops in crash_shrink_memory()"), but it's
> >> stale now. Because if 'crashk_res' is not reserved, it will be zero in
> >> size and will be intercepted by the above 'if (new_size >= old_size)'.
> >>
> >> Ago:
> >> 	if (new_size >= end - start + 1)
> >>
> >> Now:
> >> 	old_size = (end == 0) ? 0 : end - start + 1;
> >> 	if (new_size >= old_size)
> > 
> > Hmm, I would strongly suggest we keep that check. Even though the
> > current code like above can do the acutal checking, but its actual usage
> > is not obvious for checking of crashk_res existence. In the future,
> > someone may change above calculation and don't notice the hidden
> > functionality at all behind the calculation. The cost of the check is
> > almost zero, right?
> 
> The cost of the check is negligible. The only downside is that it's hard to
> understand why it's added, and I only found out why by looking at the history
> log. In my opinion, the above 'Now:' is the right fix.

It checks if the resource exists before releasing, just a normal
checking?
> 
> > 
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >>  kernel/kexec_core.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> >> index 22acee18195a591..d1ab139dd49035e 100644
> >> --- a/kernel/kexec_core.c
> >> +++ b/kernel/kexec_core.c
> >> @@ -1137,7 +1137,7 @@ int crash_shrink_memory(unsigned long new_size)
> >>  	end = start + new_size;
> >>  	crash_free_reserved_phys_range(end, crashk_res.end);
> >>  
> >> -	if ((start == end) && (crashk_res.parent != NULL))
> >> +	if (start == end)
> >>  		release_resource(&crashk_res);
> >>  
> >>  	ram_res->start = end;
> >> -- 
> >> 2.25.1
> >>
> > 
> > .
> > 
> 
> -- 
> Regards,
>   Zhen Lei
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Holzheu <holzheu@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/6] kexec: delete a useless check in crash_shrink_memory()
Date: Wed, 31 May 2023 15:41:20 +0800	[thread overview]
Message-ID: <ZHb6IFhwRMkAkNjt@MiWiFi-R3L-srv> (raw)
In-Reply-To: <5beb1883-5391-1b75-d8cd-2152478b9e72@huawei.com>

On 05/31/23 at 10:19am, Leizhen (ThunderTown) wrote:
> 
> 
> On 2023/5/31 8:17, Baoquan He wrote:
> > On 05/27/23 at 08:34pm, Zhen Lei wrote:
> >> The check '(crashk_res.parent != NULL)' is added by
> >> commit e05bd3367bd3 ("kexec: fix Oops in crash_shrink_memory()"), but it's
> >> stale now. Because if 'crashk_res' is not reserved, it will be zero in
> >> size and will be intercepted by the above 'if (new_size >= old_size)'.
> >>
> >> Ago:
> >> 	if (new_size >= end - start + 1)
> >>
> >> Now:
> >> 	old_size = (end == 0) ? 0 : end - start + 1;
> >> 	if (new_size >= old_size)
> > 
> > Hmm, I would strongly suggest we keep that check. Even though the
> > current code like above can do the acutal checking, but its actual usage
> > is not obvious for checking of crashk_res existence. In the future,
> > someone may change above calculation and don't notice the hidden
> > functionality at all behind the calculation. The cost of the check is
> > almost zero, right?
> 
> The cost of the check is negligible. The only downside is that it's hard to
> understand why it's added, and I only found out why by looking at the history
> log. In my opinion, the above 'Now:' is the right fix.

It checks if the resource exists before releasing, just a normal
checking?
> 
> > 
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >>  kernel/kexec_core.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> >> index 22acee18195a591..d1ab139dd49035e 100644
> >> --- a/kernel/kexec_core.c
> >> +++ b/kernel/kexec_core.c
> >> @@ -1137,7 +1137,7 @@ int crash_shrink_memory(unsigned long new_size)
> >>  	end = start + new_size;
> >>  	crash_free_reserved_phys_range(end, crashk_res.end);
> >>  
> >> -	if ((start == end) && (crashk_res.parent != NULL))
> >> +	if (start == end)
> >>  		release_resource(&crashk_res);
> >>  
> >>  	ram_res->start = end;
> >> -- 
> >> 2.25.1
> >>
> > 
> > .
> > 
> 
> -- 
> Regards,
>   Zhen Lei
> 


  reply	other threads:[~2023-05-31  7:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 12:34 [PATCH 0/6] kexec: enable kexec_crash_size to support two crash kernel regions Zhen Lei
2023-05-27 12:34 ` Zhen Lei
2023-05-27 12:34 ` [PATCH 1/6] kexec: fix a memory leak in crash_shrink_memory() Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-31  0:13   ` Baoquan He
2023-05-31  0:13     ` Baoquan He
2023-05-31  1:16     ` Leizhen (ThunderTown)
2023-05-31  1:16       ` Leizhen (ThunderTown)
2023-05-31  7:31       ` Baoquan He
2023-05-31  7:31         ` Baoquan He
2023-05-27 12:34 ` [PATCH 2/6] kexec: delete a useless check " Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-31  0:17   ` Baoquan He
2023-05-31  0:17     ` Baoquan He
2023-05-31  2:19     ` Leizhen (ThunderTown)
2023-05-31  2:19       ` Leizhen (ThunderTown)
2023-05-31  7:41       ` Baoquan He [this message]
2023-05-31  7:41         ` Baoquan He
2023-05-31  8:26         ` Leizhen (ThunderTown)
2023-05-31  8:26           ` Leizhen (ThunderTown)
2023-05-27 12:34 ` [PATCH 3/6] kexec: clear crashk_res if all its memory has been released Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-31  0:33   ` Baoquan He
2023-05-31  0:33     ` Baoquan He
2023-05-27 12:34 ` [PATCH 4/6] kexec: improve the readability of crash_shrink_memory() Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-31  7:48   ` Baoquan He
2023-05-31  7:48     ` Baoquan He
2023-05-27 12:34 ` [PATCH 5/6] kexec: add helper __crash_shrink_memory() Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-28  0:08   ` kernel test robot
2023-05-28  0:08     ` kernel test robot
2023-05-29  0:37     ` Leizhen (ThunderTown)
2023-05-29  0:37       ` Leizhen (ThunderTown)
2023-05-28  1:44   ` kernel test robot
2023-05-28  1:44     ` kernel test robot
2023-05-28  6:26   ` kernel test robot
2023-05-28  6:26     ` kernel test robot
2023-05-31  7:50   ` Baoquan He
2023-05-31  7:50     ` Baoquan He
2023-05-27 12:34 ` [PATCH 6/6] kexec: enable kexec_crash_size to support two crash kernel regions Zhen Lei
2023-05-27 12:34   ` Zhen Lei
2023-05-31  9:53   ` Baoquan He
2023-05-31  9:53     ` Baoquan He
2023-05-31 14:25     ` Leizhen (ThunderTown)
2023-05-31 14:25       ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHb6IFhwRMkAkNjt@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.