From: Sasha Levin <sashal@kernel.org>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>
Cc: felipe.clark@amd.com, Aric.Cyr@amd.com, wenjing.liu@amd.com,
dri-devel@lists.freedesktop.org, Jun.Lei@amd.com,
airlied@gmail.com, jiapeng.chong@linux.alibaba.com,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org, aurabindo.pillai@amd.com,
Alvin.Lee2@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com,
mwen@igalia.com, Daniel Wheeler <daniel.wheeler@amd.com>,
Dillon.Varone@amd.com, Wesley Chalmers <Wesley.Chalmers@amd.com>,
qingqing.zhuo@amd.com, Xinhui.Pan@amd.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
daniel@ffwll.ch, Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com
Subject: Re: [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit
Date: Thu, 1 Jun 2023 05:53:46 -0400 [thread overview]
Message-ID: <ZHhqqkF8FCSqMi81@sashalap> (raw)
In-Reply-To: <bc4d10f2-6ded-bed3-1d81-7e09292adf6f@mailbox.org>
On Mon, May 15, 2023 at 03:04:43PM +0200, Michel Dänzer wrote:
>On 5/11/23 21:39, Sasha Levin wrote:
>> From: Wesley Chalmers <Wesley.Chalmers@amd.com>
>>
>> [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ]
>>
>> [WHY]
>> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a
>> pipe commit can cause underflow.
>>
>> [HOW]
>> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets
>> optimized_required.
>>
>> This change expects that Freesync requests are blocked when
>> optimized_required is true.
>
>This change caused a regression, see https://patchwork.freedesktop.org/patch/532240/?series=116487&rev=1#comment_972234 / 9deeb132-a317-7419-e9da-cbc0a379c0eb@daenzer.net .
Dropped, thanks!
--
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
felipe.clark@amd.com, Aric.Cyr@amd.com, wenjing.liu@amd.com,
dri-devel@lists.freedesktop.org, Jun.Lei@amd.com,
airlied@gmail.com, jiapeng.chong@linux.alibaba.com,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org, aurabindo.pillai@amd.com,
Alvin.Lee2@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com,
mwen@igalia.com, Daniel Wheeler <daniel.wheeler@amd.com>,
Dillon.Varone@amd.com, Wesley Chalmers <Wesley.Chalmers@amd.com>,
qingqing.zhuo@amd.com, Xinhui.Pan@amd.com, daniel@ffwll.ch,
Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com
Subject: Re: [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit
Date: Thu, 1 Jun 2023 05:53:46 -0400 [thread overview]
Message-ID: <ZHhqqkF8FCSqMi81@sashalap> (raw)
In-Reply-To: <bc4d10f2-6ded-bed3-1d81-7e09292adf6f@mailbox.org>
On Mon, May 15, 2023 at 03:04:43PM +0200, Michel Dänzer wrote:
>On 5/11/23 21:39, Sasha Levin wrote:
>> From: Wesley Chalmers <Wesley.Chalmers@amd.com>
>>
>> [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ]
>>
>> [WHY]
>> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a
>> pipe commit can cause underflow.
>>
>> [HOW]
>> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets
>> optimized_required.
>>
>> This change expects that Freesync requests are blocked when
>> optimized_required is true.
>
>This change caused a regression, see https://patchwork.freedesktop.org/patch/532240/?series=116487&rev=1#comment_972234 / 9deeb132-a317-7419-e9da-cbc0a379c0eb@daenzer.net .
Dropped, thanks!
--
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>
Cc: felipe.clark@amd.com, wenjing.liu@amd.com,
dri-devel@lists.freedesktop.org, Jun.Lei@amd.com,
jiapeng.chong@linux.alibaba.com,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
amd-gfx@lists.freedesktop.org, aurabindo.pillai@amd.com,
Alvin.Lee2@amd.com, sunpeng.li@amd.com, mwen@igalia.com,
Daniel Wheeler <daniel.wheeler@amd.com>,
Dillon.Varone@amd.com, Wesley Chalmers <Wesley.Chalmers@amd.com>,
qingqing.zhuo@amd.com, Xinhui.Pan@amd.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com
Subject: Re: [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit
Date: Thu, 1 Jun 2023 05:53:46 -0400 [thread overview]
Message-ID: <ZHhqqkF8FCSqMi81@sashalap> (raw)
In-Reply-To: <bc4d10f2-6ded-bed3-1d81-7e09292adf6f@mailbox.org>
On Mon, May 15, 2023 at 03:04:43PM +0200, Michel Dänzer wrote:
>On 5/11/23 21:39, Sasha Levin wrote:
>> From: Wesley Chalmers <Wesley.Chalmers@amd.com>
>>
>> [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ]
>>
>> [WHY]
>> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a
>> pipe commit can cause underflow.
>>
>> [HOW]
>> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets
>> optimized_required.
>>
>> This change expects that Freesync requests are blocked when
>> optimized_required is true.
>
>This change caused a regression, see https://patchwork.freedesktop.org/patch/532240/?series=116487&rev=1#comment_972234 / 9deeb132-a317-7419-e9da-cbc0a379c0eb@daenzer.net .
Dropped, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-06-01 9:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 19:39 [PATCH AUTOSEL 6.1 1/9] drm/amdgpu: release gpu full access after "amdgpu_device_ip_late_init" Sasha Levin
2023-05-11 19:39 ` Sasha Levin
2023-05-11 19:39 ` Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 2/9] watchdog: menz069_wdt: fix watchdog initialisation Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 3/9] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit Sasha Levin
2023-05-11 19:39 ` Sasha Levin
2023-05-11 19:39 ` Sasha Levin
2023-05-15 13:04 ` Michel Dänzer
2023-05-15 13:04 ` Michel Dänzer
2023-06-01 9:53 ` Sasha Levin [this message]
2023-06-01 9:53 ` Sasha Levin
2023-06-01 9:53 ` Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 5/9] of: fdt: Scan /memreserve/ last Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 6/9] LoongArch: Relay BCE exceptions to userland as SIGSEGV with si_code=SEGV_BNDERR Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 7/9] netfilter: nf_tables: deactivate anonymous set from preparation phase Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 8/9] ASoC: Intel: soc-acpi-cht: Add quirk for Nextbook Ares 8A tablet Sasha Levin
2023-05-11 19:39 ` [PATCH AUTOSEL 6.1 9/9] drm/amdgpu: Use the default reset when loading or reloading the driver Sasha Levin
2023-05-11 19:39 ` Sasha Levin
2023-05-11 19:39 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHhqqkF8FCSqMi81@sashalap \
--to=sashal@kernel.org \
--cc=Alvin.Lee2@amd.com \
--cc=Aric.Cyr@amd.com \
--cc=Dillon.Varone@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.wheeler@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe.clark@amd.com \
--cc=harry.wentland@amd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.daenzer@mailbox.org \
--cc=mwen@igalia.com \
--cc=qingqing.zhuo@amd.com \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.