From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg
Date: Fri, 9 Jun 2023 09:23:50 +0100 [thread overview]
Message-ID: <ZILhllzq5SAFTgOf@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230609080305.546028-1-maxime.chevallier@bootlin.com>
On Fri, Jun 09, 2023 at 10:03:03AM +0200, Maxime Chevallier wrote:
> This is the second version of a small changeset for QUSGMII support,
> fixing inconsistencies in reported max speed and control word parsing.
>
> As reported here [1], there are some inconsistencies for the Q-USGMII
> mode speeds and configuration. The first patch in this fixup series
> makes so that we correctly report the max speed of 1Gbps for this mode.
>
> The second patch uses a dedicated helper to decode the control word.
> This is necessary as although USGMII control words are close to USXGMII,
> they don't support the same speeds.
>
> Thanks,
>
> Maxime
>
> [1] : https://lore.kernel.org/netdev/ZHnd+6FUO77XFJvQ@shell.armlinux.org.uk/
>
> V1->V2: Fix decoding logic for usgmii control word, as per Russell's review
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg
Date: Fri, 9 Jun 2023 09:23:50 +0100 [thread overview]
Message-ID: <ZILhllzq5SAFTgOf@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230609080305.546028-1-maxime.chevallier@bootlin.com>
On Fri, Jun 09, 2023 at 10:03:03AM +0200, Maxime Chevallier wrote:
> This is the second version of a small changeset for QUSGMII support,
> fixing inconsistencies in reported max speed and control word parsing.
>
> As reported here [1], there are some inconsistencies for the Q-USGMII
> mode speeds and configuration. The first patch in this fixup series
> makes so that we correctly report the max speed of 1Gbps for this mode.
>
> The second patch uses a dedicated helper to decode the control word.
> This is necessary as although USGMII control words are close to USXGMII,
> they don't support the same speeds.
>
> Thanks,
>
> Maxime
>
> [1] : https://lore.kernel.org/netdev/ZHnd+6FUO77XFJvQ@shell.armlinux.org.uk/
>
> V1->V2: Fix decoding logic for usgmii control word, as per Russell's review
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-09 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:03 [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg Maxime Chevallier
2023-06-09 8:03 ` Maxime Chevallier
2023-06-09 8:03 ` [PATCH net v2 1/2] net: phylink: report correct max speed for QUSGMII Maxime Chevallier
2023-06-09 8:03 ` Maxime Chevallier
2023-06-09 8:03 ` [PATCH net v2 2/2] net: phylink: use a dedicated helper to parse usgmii control word Maxime Chevallier
2023-06-09 8:03 ` Maxime Chevallier
2023-06-09 8:23 ` Russell King (Oracle) [this message]
2023-06-09 8:23 ` [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg Russell King (Oracle)
2023-06-13 0:00 ` patchwork-bot+netdevbpf
2023-06-13 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZILhllzq5SAFTgOf@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Allan.Nielsen@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.