From: Catalin Marinas <catalin.marinas@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [arm64:devel/kmalloc-minalign 18/18] include/linux/cache.h:104:38: error: missing binary operator before token "("
Date: Sat, 10 Jun 2023 09:39:29 +0100 [thread overview]
Message-ID: <ZIQ2wXRVNh/NKDK2@arm.com> (raw)
In-Reply-To: <202306101526.kiwBY0Xr-lkp@intel.com>
On Sat, Jun 10, 2023 at 04:10:50PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/kmalloc-minalign
> head: e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> commit: e5bbe79231baf5cad690c6fc9de3910ad14a2aa6 [18/18] fixup! mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230610/202306101526.kiwBY0Xr-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?id=e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> git remote add arm64 https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> git fetch --no-tags arm64 devel/kmalloc-minalign
> git checkout e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 olddefconfig
> make W=1 O=build_dir ARCH=x86_64 prepare
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306101526.kiwBY0Xr-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/x86/include/asm/current.h:9,
> from arch/x86/include/asm/preempt.h:7,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:56,
> from include/linux/swait.h:7,
> from include/linux/completion.h:12,
> from include/linux/crypto.h:15,
> from arch/x86/kernel/asm-offsets.c:9:
> >> include/linux/cache.h:104:38: error: missing binary operator before token "("
> 104 | #define ARCH_DMA_MINALIGN __alignof__(unsigned long long)
> | ^
> include/linux/slab.h:239:39: note: in expansion of macro 'ARCH_DMA_MINALIGN'
> 239 | #if defined(ARCH_HAS_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 && \
> | ^~~~~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1
> make[2]: Target 'prepare' not remade because of errors.
> make[1]: *** [Makefile:1287: prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:226: __sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
I noticed this as well but somehow pushed the fixup in error. Removed
now and fixed properly.
Thanks for the report.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [arm64:devel/kmalloc-minalign 18/18] include/linux/cache.h:104:38: error: missing binary operator before token "("
Date: Sat, 10 Jun 2023 09:39:29 +0100 [thread overview]
Message-ID: <ZIQ2wXRVNh/NKDK2@arm.com> (raw)
In-Reply-To: <202306101526.kiwBY0Xr-lkp@intel.com>
On Sat, Jun 10, 2023 at 04:10:50PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/kmalloc-minalign
> head: e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> commit: e5bbe79231baf5cad690c6fc9de3910ad14a2aa6 [18/18] fixup! mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230610/202306101526.kiwBY0Xr-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?id=e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> git remote add arm64 https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> git fetch --no-tags arm64 devel/kmalloc-minalign
> git checkout e5bbe79231baf5cad690c6fc9de3910ad14a2aa6
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 olddefconfig
> make W=1 O=build_dir ARCH=x86_64 prepare
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306101526.kiwBY0Xr-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/x86/include/asm/current.h:9,
> from arch/x86/include/asm/preempt.h:7,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:56,
> from include/linux/swait.h:7,
> from include/linux/completion.h:12,
> from include/linux/crypto.h:15,
> from arch/x86/kernel/asm-offsets.c:9:
> >> include/linux/cache.h:104:38: error: missing binary operator before token "("
> 104 | #define ARCH_DMA_MINALIGN __alignof__(unsigned long long)
> | ^
> include/linux/slab.h:239:39: note: in expansion of macro 'ARCH_DMA_MINALIGN'
> 239 | #if defined(ARCH_HAS_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 && \
> | ^~~~~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1
> make[2]: Target 'prepare' not remade because of errors.
> make[1]: *** [Makefile:1287: prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:226: __sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
I noticed this as well but somehow pushed the fixup in error. Removed
now and fixed properly.
Thanks for the report.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-10 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 8:10 [arm64:devel/kmalloc-minalign 18/18] include/linux/cache.h:104:38: error: missing binary operator before token "(" kernel test robot
2023-06-10 8:10 ` kernel test robot
2023-06-10 8:39 ` Catalin Marinas [this message]
2023-06-10 8:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIQ2wXRVNh/NKDK2@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.