From: Baoquan He <bhe@redhat.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
horms@kernel.org, thunder.leizhen@huawei.com,
John.p.donnelly@oracle.com, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high
Date: Mon, 12 Jun 2023 07:06:24 +0800 [thread overview]
Message-ID: <ZIZTcEjdJOqXanJS@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZIXayAr6r1tnFQ5i@arm.com>
On 06/11/23 at 03:31pm, Catalin Marinas wrote:
> On Sun, Jun 11, 2023 at 08:15:07PM +0800, Baoquan He wrote:
> > On 06/09/23 at 08:30pm, Catalin Marinas wrote:
> > > On Mon, 15 May 2023 14:02:57 +0800, Baoquan He wrote:
> > > > In v5 patch, Catalin helped review and acked the patch. However, an
> > > > uninitialized local varilable is warned out by static checker when Will
> > > > tried to merge the patch. And Will complained the code flow in
> > > > reserve_crashkernel() is hard to follow, required to refactor. While
> > > > when I tried to do the refactory, I feel it's not easy, the existing
> > > > several cases causes that.
> > > >
> > > > [...]
> > >
> > > Applied to arm64 (for-next/kdump).
> > >
> > > I reworte some of the paragraphs in the documentation patch, removed
> > > some sentences to make it easier to read (some details were pretty
> > > obvious). Please have a look, if you think I missed something important,
> > > just send a patch on top. Thanks.
> > >
> > > [1/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high
> > > https://git.kernel.org/arm64/c/6c4dcaddbd36
> > > [2/2] Documentation: add kdump.rst to present crashkernel reservation on arm64
> > > https://git.kernel.org/arm64/c/03dc0e05407f
> >
> > Could you help add below code change into the document patch commit? I
> > forgot adding it and got warning report from lkp test robot.
> >
> > https://lore.kernel.org/oe-kbuild-all/202306110549.ynH2Juok-lkp@intel.com/
> >
> > diff --git a/Documentation/arm64/index.rst b/Documentation/arm64/index.rst
> > index ae21f8118830..dcfebddb6088 100644
> > --- a/Documentation/arm64/index.rst
> > +++ b/Documentation/arm64/index.rst
> > @@ -25,6 +25,7 @@ ARM64 Architecture
> > sve
> > tagged-address-abi
> > tagged-pointers
> > + kdump
>
> I've seen the warning as well. Please send a patch fixing this as I try
> to avoid rebasing. Also we keep this part in alphabetical order.
Has sent a patch to fix that, thanks.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
horms@kernel.org, thunder.leizhen@huawei.com,
John.p.donnelly@oracle.com, kexec@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high
Date: Mon, 12 Jun 2023 07:06:24 +0800 [thread overview]
Message-ID: <ZIZTcEjdJOqXanJS@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZIXayAr6r1tnFQ5i@arm.com>
On 06/11/23 at 03:31pm, Catalin Marinas wrote:
> On Sun, Jun 11, 2023 at 08:15:07PM +0800, Baoquan He wrote:
> > On 06/09/23 at 08:30pm, Catalin Marinas wrote:
> > > On Mon, 15 May 2023 14:02:57 +0800, Baoquan He wrote:
> > > > In v5 patch, Catalin helped review and acked the patch. However, an
> > > > uninitialized local varilable is warned out by static checker when Will
> > > > tried to merge the patch. And Will complained the code flow in
> > > > reserve_crashkernel() is hard to follow, required to refactor. While
> > > > when I tried to do the refactory, I feel it's not easy, the existing
> > > > several cases causes that.
> > > >
> > > > [...]
> > >
> > > Applied to arm64 (for-next/kdump).
> > >
> > > I reworte some of the paragraphs in the documentation patch, removed
> > > some sentences to make it easier to read (some details were pretty
> > > obvious). Please have a look, if you think I missed something important,
> > > just send a patch on top. Thanks.
> > >
> > > [1/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high
> > > https://git.kernel.org/arm64/c/6c4dcaddbd36
> > > [2/2] Documentation: add kdump.rst to present crashkernel reservation on arm64
> > > https://git.kernel.org/arm64/c/03dc0e05407f
> >
> > Could you help add below code change into the document patch commit? I
> > forgot adding it and got warning report from lkp test robot.
> >
> > https://lore.kernel.org/oe-kbuild-all/202306110549.ynH2Juok-lkp@intel.com/
> >
> > diff --git a/Documentation/arm64/index.rst b/Documentation/arm64/index.rst
> > index ae21f8118830..dcfebddb6088 100644
> > --- a/Documentation/arm64/index.rst
> > +++ b/Documentation/arm64/index.rst
> > @@ -25,6 +25,7 @@ ARM64 Architecture
> > sve
> > tagged-address-abi
> > tagged-pointers
> > + kdump
>
> I've seen the warning as well. Please send a patch fixing this as I try
> to avoid rebasing. Also we keep this part in alphabetical order.
Has sent a patch to fix that, thanks.
next prev parent reply other threads:[~2023-06-11 23:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 6:02 [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Baoquan He
2023-05-15 6:02 ` Baoquan He
2023-05-15 6:02 ` [PATCH v6 1/2] " Baoquan He
2023-05-15 6:02 ` Baoquan He
2023-05-15 9:54 ` [PATCH v6 RESEND " Baoquan He
2023-05-15 9:54 ` Baoquan He
2023-05-15 9:54 ` Baoquan He
2023-06-06 11:53 ` Leizhen (ThunderTown)
2023-06-06 11:53 ` Leizhen (ThunderTown)
2023-06-06 11:53 ` Leizhen (ThunderTown)
2023-05-15 10:07 ` [PATCH v6 " Baoquan He
2023-05-15 10:07 ` Baoquan He
2023-05-15 10:07 ` Baoquan He
2023-05-15 6:02 ` [PATCH v6 2/2] Documentation: add kdump.rst to present crashkernel reservation on arm64 Baoquan He
2023-05-15 6:02 ` Baoquan He
2023-06-06 12:08 ` Leizhen (ThunderTown)
2023-06-06 12:08 ` Leizhen (ThunderTown)
2023-06-06 12:08 ` Leizhen (ThunderTown)
2023-06-09 19:30 ` [PATCH v6 0/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Catalin Marinas
2023-06-09 19:30 ` Catalin Marinas
2023-06-09 19:30 ` Catalin Marinas
2023-06-11 0:35 ` Baoquan He
2023-06-11 0:35 ` Baoquan He
2023-06-11 12:15 ` Baoquan He
2023-06-11 12:15 ` Baoquan He
2023-06-11 14:31 ` Catalin Marinas
2023-06-11 14:31 ` Catalin Marinas
2023-06-11 23:06 ` Baoquan He [this message]
2023-06-11 23:06 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIZTcEjdJOqXanJS@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=John.p.donnelly@oracle.com \
--cc=catalin.marinas@arm.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.