* Bug report in reg_user_mr in exe
@ 2023-06-13 16:26 Bob Pearson
2023-06-13 16:52 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Bob Pearson @ 2023-06-13 16:26 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma@vger.kernel.org
Jason,
Recently the code in rxe_reg_user_mr was changed to check if the driver supported the
access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the
driver didn't support that option but it turns out that this breaks the perf tests which
request relaxed ordering by default.
It looks like the correct fix for this is to go ahead and claim support for relaxed ordering
but it will be a no-op.
Thoughts?
Bob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug report in reg_user_mr in exe
2023-06-13 16:26 Bug report in reg_user_mr in exe Bob Pearson
@ 2023-06-13 16:52 ` Jason Gunthorpe
2023-06-13 16:54 ` Bob Pearson
0 siblings, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2023-06-13 16:52 UTC (permalink / raw)
To: Bob Pearson; +Cc: linux-rdma@vger.kernel.org
On Tue, Jun 13, 2023 at 11:26:55AM -0500, Bob Pearson wrote:
> Jason,
>
> Recently the code in rxe_reg_user_mr was changed to check if the driver supported the
> access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the
> driver didn't support that option but it turns out that this breaks the perf tests which
> request relaxed ordering by default.
Sounds like rxe is checking the flags wrong, there is a set of
optional access flags that should be ignored by the driver.
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug report in reg_user_mr in exe
2023-06-13 16:52 ` Jason Gunthorpe
@ 2023-06-13 16:54 ` Bob Pearson
2023-06-13 16:55 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Bob Pearson @ 2023-06-13 16:54 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma@vger.kernel.org
On 6/13/23 11:52, Jason Gunthorpe wrote:
> On Tue, Jun 13, 2023 at 11:26:55AM -0500, Bob Pearson wrote:
>> Jason,
>>
>> Recently the code in rxe_reg_user_mr was changed to check if the driver supported the
>> access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the
>> driver didn't support that option but it turns out that this breaks the perf tests which
>> request relaxed ordering by default.
>
> Sounds like rxe is checking the flags wrong, there is a set of
> optional access flags that should be ignored by the driver.
>
> Jason
OK. That's easy. I'm just embarrassed I broke ib_send_bw.
So mask off the optional ones and check the rest?
Bob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug report in reg_user_mr in exe
2023-06-13 16:54 ` Bob Pearson
@ 2023-06-13 16:55 ` Jason Gunthorpe
0 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2023-06-13 16:55 UTC (permalink / raw)
To: Bob Pearson; +Cc: linux-rdma@vger.kernel.org
On Tue, Jun 13, 2023 at 11:54:46AM -0500, Bob Pearson wrote:
> On 6/13/23 11:52, Jason Gunthorpe wrote:
> > On Tue, Jun 13, 2023 at 11:26:55AM -0500, Bob Pearson wrote:
> >> Jason,
> >>
> >> Recently the code in rxe_reg_user_mr was changed to check if the driver supported the
> >> access flags. Since the rxe driver does nothing about relaxed ordering. I assumed that the
> >> driver didn't support that option but it turns out that this breaks the perf tests which
> >> request relaxed ordering by default.
> >
> > Sounds like rxe is checking the flags wrong, there is a set of
> > optional access flags that should be ignored by the driver.
> >
> > Jason
>
> OK. That's easy. I'm just embarrassed I broke ib_send_bw.
> So mask off the optional ones and check the rest?
Yes, there is a constant for it too
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-13 16:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-13 16:26 Bug report in reg_user_mr in exe Bob Pearson
2023-06-13 16:52 ` Jason Gunthorpe
2023-06-13 16:54 ` Bob Pearson
2023-06-13 16:55 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.