From: Oliver Upton <oliver.upton@linux.dev>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check
Date: Wed, 14 Jun 2023 12:23:32 +0000 [thread overview]
Message-ID: <ZImxRC3QlLbPhwsC@linux.dev> (raw)
In-Reply-To: <ZIjcoOaexz5YAyWT@google.com>
On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote:
> +<everyone else>
>
> Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be
> trivial, but it still needs eyeballs from the relevant maintainers.
+1000. I'd buy someone a beer if they made a bot that just ran
get_maintainer on patches that hit the list :)
> On Wed, Mar 15, 2023, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> >
> > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang at intel.com
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/arm64/kvm/arm.c | 1 -
> > arch/powerpc/kvm/powerpc.c | 1 -
> > arch/riscv/kvm/vm.c | 1 -
> > arch/s390/kvm/kvm-s390.c | 1 -
> > virt/kvm/kvm_main.c | 1 +
> > 5 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 3bd732eaf087..96329e675771 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> > r = vgic_present;
> > break;
> > case KVM_CAP_IOEVENTFD:
> > - case KVM_CAP_DEVICE_CTRL:
> > case KVM_CAP_USER_MEMORY:
> > case KVM_CAP_SYNC_MMU:
> > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS:
for arm64:
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check
Date: Wed, 14 Jun 2023 12:23:32 +0000 [thread overview]
Message-ID: <ZImxRC3QlLbPhwsC@linux.dev> (raw)
In-Reply-To: <ZIjcoOaexz5YAyWT@google.com>
On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote:
> +<everyone else>
>
> Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be
> trivial, but it still needs eyeballs from the relevant maintainers.
+1000. I'd buy someone a beer if they made a bot that just ran
get_maintainer on patches that hit the list :)
> On Wed, Mar 15, 2023, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> >
> > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang@intel.com
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/arm64/kvm/arm.c | 1 -
> > arch/powerpc/kvm/powerpc.c | 1 -
> > arch/riscv/kvm/vm.c | 1 -
> > arch/s390/kvm/kvm-s390.c | 1 -
> > virt/kvm/kvm_main.c | 1 +
> > 5 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 3bd732eaf087..96329e675771 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> > r = vgic_present;
> > break;
> > case KVM_CAP_IOEVENTFD:
> > - case KVM_CAP_DEVICE_CTRL:
> > case KVM_CAP_USER_MEMORY:
> > case KVM_CAP_SYNC_MMU:
> > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS:
for arm64:
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check
Date: Wed, 14 Jun 2023 12:23:32 +0000 [thread overview]
Message-ID: <ZImxRC3QlLbPhwsC@linux.dev> (raw)
In-Reply-To: <ZIjcoOaexz5YAyWT@google.com>
On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote:
> +<everyone else>
>
> Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be
> trivial, but it still needs eyeballs from the relevant maintainers.
+1000. I'd buy someone a beer if they made a bot that just ran
get_maintainer on patches that hit the list :)
> On Wed, Mar 15, 2023, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> >
> > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang@intel.com
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/arm64/kvm/arm.c | 1 -
> > arch/powerpc/kvm/powerpc.c | 1 -
> > arch/riscv/kvm/vm.c | 1 -
> > arch/s390/kvm/kvm-s390.c | 1 -
> > virt/kvm/kvm_main.c | 1 +
> > 5 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 3bd732eaf087..96329e675771 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> > r = vgic_present;
> > break;
> > case KVM_CAP_IOEVENTFD:
> > - case KVM_CAP_DEVICE_CTRL:
> > case KVM_CAP_USER_MEMORY:
> > case KVM_CAP_SYNC_MMU:
> > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS:
for arm64:
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org, Claudio Imbrenda <imbrenda@linux.ibm.com>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-kernel@vger.kernel.org, Wei Wang <wei.w.wang@intel.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
kvm-riscv@lists.infradead.org, Marc Zyngier <maz@kernel.org>,
kvmarm@lists.linux.dev, pbonzini@redhat.com,
linux-riscv@lists.infradead.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check
Date: Wed, 14 Jun 2023 12:23:32 +0000 [thread overview]
Message-ID: <ZImxRC3QlLbPhwsC@linux.dev> (raw)
In-Reply-To: <ZIjcoOaexz5YAyWT@google.com>
On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote:
> +<everyone else>
>
> Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be
> trivial, but it still needs eyeballs from the relevant maintainers.
+1000. I'd buy someone a beer if they made a bot that just ran
get_maintainer on patches that hit the list :)
> On Wed, Mar 15, 2023, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> >
> > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang@intel.com
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/arm64/kvm/arm.c | 1 -
> > arch/powerpc/kvm/powerpc.c | 1 -
> > arch/riscv/kvm/vm.c | 1 -
> > arch/s390/kvm/kvm-s390.c | 1 -
> > virt/kvm/kvm_main.c | 1 +
> > 5 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 3bd732eaf087..96329e675771 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> > r = vgic_present;
> > break;
> > case KVM_CAP_IOEVENTFD:
> > - case KVM_CAP_DEVICE_CTRL:
> > case KVM_CAP_USER_MEMORY:
> > case KVM_CAP_SYNC_MMU:
> > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS:
for arm64:
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check
Date: Wed, 14 Jun 2023 12:23:32 +0000 [thread overview]
Message-ID: <ZImxRC3QlLbPhwsC@linux.dev> (raw)
In-Reply-To: <ZIjcoOaexz5YAyWT@google.com>
On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote:
> +<everyone else>
>
> Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be
> trivial, but it still needs eyeballs from the relevant maintainers.
+1000. I'd buy someone a beer if they made a bot that just ran
get_maintainer on patches that hit the list :)
> On Wed, Mar 15, 2023, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> >
> > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang@intel.com
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/arm64/kvm/arm.c | 1 -
> > arch/powerpc/kvm/powerpc.c | 1 -
> > arch/riscv/kvm/vm.c | 1 -
> > arch/s390/kvm/kvm-s390.c | 1 -
> > virt/kvm/kvm_main.c | 1 +
> > 5 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 3bd732eaf087..96329e675771 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> > r = vgic_present;
> > break;
> > case KVM_CAP_IOEVENTFD:
> > - case KVM_CAP_DEVICE_CTRL:
> > case KVM_CAP_USER_MEMORY:
> > case KVM_CAP_SYNC_MMU:
> > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS:
for arm64:
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-14 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:16 [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check Wei Wang
2023-06-13 21:16 ` Sean Christopherson
2023-06-13 21:16 ` Sean Christopherson
2023-06-13 21:16 ` Sean Christopherson
2023-06-13 21:16 ` Sean Christopherson
2023-06-13 21:16 ` Sean Christopherson
2023-06-14 12:23 ` Oliver Upton [this message]
2023-06-14 12:23 ` Oliver Upton
2023-06-14 12:23 ` Oliver Upton
2023-06-14 12:23 ` Oliver Upton
2023-06-14 12:23 ` Oliver Upton
2023-06-15 3:48 ` Michael Ellerman
2023-06-15 5:49 ` Anup Patel
2023-12-01 1:52 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZImxRC3QlLbPhwsC@linux.dev \
--to=oliver.upton@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.