Re: [PATCH v3 1/1] memory: Fix export symbol twice compiler error for "export symbols for memory related functions" patch

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Wei Chin Tsai <Wei-chin.Tsai@mediatek.com>
Cc: lkp@intel.com, angelogioacchino.delregno@collabora.com,
	ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
	mel.lee@mediatek.com, oe-kbuild-all@lists.linux.dev,
	wsd_upstream@mediatek.com
Subject: Re: [PATCH v3 1/1] memory: Fix export symbol twice compiler error for "export symbols for memory related functions" patch
Date: Wed, 14 Jun 2023 17:24:02 +0100	[thread overview]
Message-ID: <ZInpooYdKnhdm3SW@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230614153902.26206-1-Wei-chin.Tsai@mediatek.com>

On Wed, Jun 14, 2023 at 11:39:02PM +0800, Wei Chin Tsai wrote:
> User could not add the export symbol "arch_vma_name"
> in arch/arm/kernel/process.c and kernel/signal.c both.
> It would cause the export symbol twice compiler error
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Signed-off-by: Wei Chin Tsai <Wei-chin.Tsai@mediatek.com>

I'm sorry, but this patch is silly.

> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index df91412a1069..d71a9bafb584 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -343,7 +343,10 @@ const char *arch_vma_name(struct vm_area_struct *vma)
>  {
>  	return is_gate_vma(vma) ? "[vectors]" : NULL;
>  }
> +
> +#ifdef CONFIG_ARM
>  EXPORT_SYMBOL_GPL(arch_vma_name);
> +#endif

CONFIG_ARM will always be set here, so adding this ifdef is useless.

> diff --git a/kernel/signal.c b/kernel/signal.c
> index a1abe77fcdc3..f7d03450781e 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -4700,7 +4700,10 @@ __weak const char *arch_vma_name(struct vm_area_struct *vma)
>  {
>  	return NULL;
>  }
> +
> +#ifdef CONFIG_ARM64
>  EXPORT_SYMBOL_GPL(arch_vma_name);
> +#endif

Sorry, but no.

Please do the research I've now twice asked for.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!