Re: [mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[Niklas Cassel <Niklas.Cassel@wdc.com>]

On Thu, Jun 15, 2023 at 02:00:21PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
> head:   aca416ac0b1fbe89d563f88cdb9884f986863d34
> commit: bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60 [70/83] scsi: block: Improve ioprio value validity checks
> config: i386-randconfig-i012-20230614 (https://download.01.org/0day-ci/archive/20230615/202306151347.WblKhRwQ-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>         git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>         git fetch --no-tags mkp-scsi for-next
>         git checkout bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306151347.WblKhRwQ-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <command-line>:
> >> ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'
>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>          |        ^~~~~~~~~~~~~~~
> >> ./usr/include/linux/ioprio.h:107:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ioprio_value'
>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>          |                              ^~~~~~~~~~~~
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


If we really want to use __always_inline,
I think that the uapi header should include:
<linux/stddef.h>

see how e.g.
include/uapi/linux/swab.h:#include <linux/stddef.h>
which also uses __always_inline does it.


(stddef.h includes compiler_attributes.h which redefines
__always_inline to also include inline, and stddef.h also
defines __always_inline if it isn't defined.)


So I suppose:
1) either replace __always_inline with inline in ioprio.h
or
2) let ioprio.h include <linux/stddef.h>


Kind regards,
Niklas