[mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head:   aca416ac0b1fbe89d563f88cdb9884f986863d34
commit: bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60 [70/83] scsi: block: Improve ioprio value validity checks
config: i386-randconfig-i012-20230614 (https://download.01.org/0day-ci/archive/20230615/202306151347.WblKhRwQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
        git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
        git fetch --no-tags mkp-scsi for-next
        git checkout bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306151347.WblKhRwQ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <command-line>:
>> ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'
     107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
         |        ^~~~~~~~~~~~~~~
>> ./usr/include/linux/ioprio.h:107:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ioprio_value'
     107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
         |                              ^~~~~~~~~~~~

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head:   aca416ac0b1fbe89d563f88cdb9884f986863d34
commit: bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60 [70/83] scsi: block: Improve ioprio value validity checks
config: i386-randconfig-i001-20230614 (https://download.01.org/0day-ci/archive/20230615/202306151519.FDr0tbFR-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
        git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
        git fetch --no-tags mkp-scsi for-next
        git checkout bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306151519.FDr0tbFR-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <built-in>:1:
>> ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'
   static __always_inline __u16 ioprio_value(int class, int level, int hint)
          ^
>> ./usr/include/linux/ioprio.h:107:29: error: expected ';' after top level declarator
   static __always_inline __u16 ioprio_value(int class, int level, int hint)
                               ^
                               ;
   2 errors generated.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[Niklas Cassel]

On Thu, Jun 15, 2023 at 02:00:21PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
> head:   aca416ac0b1fbe89d563f88cdb9884f986863d34
> commit: bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60 [70/83] scsi: block: Improve ioprio value validity checks
> config: i386-randconfig-i012-20230614 (https://download.01.org/0day-ci/archive/20230615/202306151347.WblKhRwQ-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>         git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>         git fetch --no-tags mkp-scsi for-next
>         git checkout bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306151347.WblKhRwQ-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <command-line>:
> >> ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'
>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>          |        ^~~~~~~~~~~~~~~
> >> ./usr/include/linux/ioprio.h:107:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ioprio_value'
>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>          |                              ^~~~~~~~~~~~
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


If we really want to use __always_inline,
I think that the uapi header should include:
<linux/stddef.h>

see how e.g.
include/uapi/linux/swab.h:#include <linux/stddef.h>
which also uses __always_inline does it.


(stddef.h includes compiler_attributes.h which redefines
__always_inline to also include inline, and stddef.h also
defines __always_inline if it isn't defined.)


So I suppose:
1) either replace __always_inline with inline in ioprio.h
or
2) let ioprio.h include <linux/stddef.h>


Kind regards,
Niklas

Re: [mkp-scsi:for-next 70/83] ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'

[Damien Le Moal]

On 6/15/23 18:53, Niklas Cassel wrote:
> On Thu, Jun 15, 2023 at 02:00:21PM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
>> head:   aca416ac0b1fbe89d563f88cdb9884f986863d34
>> commit: bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60 [70/83] scsi: block: Improve ioprio value validity checks
>> config: i386-randconfig-i012-20230614 (https://download.01.org/0day-ci/archive/20230615/202306151347.WblKhRwQ-lkp@intel.com/config)
>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>> reproduce (this is a W=1 build):
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>>         git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>>         git fetch --no-tags mkp-scsi for-next
>>         git checkout bfaaaa3d9d09974828dc5c5d44eb2657a65d6b60
>>         # save the config file
>>         mkdir build_dir && cp config build_dir/.config
>>         make W=1 O=build_dir ARCH=i386 olddefconfig
>>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202306151347.WblKhRwQ-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from <command-line>:
>>>> ./usr/include/linux/ioprio.h:107:8: error: unknown type name '__always_inline'
>>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>>          |        ^~~~~~~~~~~~~~~
>>>> ./usr/include/linux/ioprio.h:107:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ioprio_value'
>>      107 | static __always_inline __u16 ioprio_value(int class, int level, int hint)
>>          |                              ^~~~~~~~~~~~
>>
>> -- 
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
> 
> 
> If we really want to use __always_inline,
> I think that the uapi header should include:
> <linux/stddef.h>
> 
> see how e.g.
> include/uapi/linux/swab.h:#include <linux/stddef.h>
> which also uses __always_inline does it.
> 
> 
> (stddef.h includes compiler_attributes.h which redefines
> __always_inline to also include inline, and stddef.h also
> defines __always_inline if it isn't defined.)
> 
> 
> So I suppose:
> 1) either replace __always_inline with inline in ioprio.h
> or
> 2) let ioprio.h include <linux/stddef.h>

I replied to the problem notification email and forgot to add you... I think this:

diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h
index 7310449c0178..92a769b9786d 100644
--- a/include/uapi/linux/ioprio.h
+++ b/include/uapi/linux/ioprio.h
@@ -2,6 +2,9 @@
 #ifndef _UAPI_LINUX_IOPRIO_H
 #define _UAPI_LINUX_IOPRIO_H

+#include <linux/stddef.h>
+#include <linux/types.h>
+
 /*
  * Gives us 8 prio classes with 13-bits of data for each class
  */

should do.

I basically followed what other uapi heder files using __always_inline do. The
addition of linux/types.h is to be safe for that "__u16" used also.

Never saw any error on my local builds though, and the buildbot did not complain
after the patch was submitted either. Not sure why.

> 
> 
> Kind regards,
> Niklas

-- 
Damien Le Moal
Western Digital Research