From: Simon Horman <simon.horman@corigine.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Ramón Nordin Rodriguez" <ramon.nordin.rodriguez@ferroamp.se>,
"Parthiban Veerasooran" <Parthiban.Veerasooran@microchip.com>,
"Frank Sae" <Frank.Sae@motor-comm.com>,
"Michael Walle" <michael@walle.cc>,
"Daniel Golle" <daniel@makrotopia.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] net: phy: mediatek: fix compile-test dependencies
Date: Fri, 16 Jun 2023 13:47:35 +0200 [thread overview]
Message-ID: <ZIxL16HWci5dd7Ah@corigine.com> (raw)
In-Reply-To: <20230616093009.3511692-1-arnd@kernel.org>
On Fri, Jun 16, 2023 at 11:29:54AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new phy driver attempts to select a driver from another subsystem,
> but that fails when the NVMEM subsystem is disabled:
>
> WARNING: unmet direct dependencies detected for NVMEM_MTK_EFUSE
> Depends on [n]: NVMEM [=n] && (ARCH_MEDIATEK [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
> Selected by [y]:
> - MEDIATEK_GE_SOC_PHY [=y] && NETDEVICES [=y] && PHYLIB [=y] && (ARM64 && ARCH_MEDIATEK [=n] || COMPILE_TEST [=y])
>
> I could not see an actual compile time dependency, so presumably this
> is only needed for for working correctly but not technically a dependency
nit: for for -> for
or
for for working correctly -> for correct operation
> on that particular nvmem driver implementation, so it would likely
> be safe to remove the select for compile testing.
>
> To keep the spirit of the original 'select', just replace this with a
> 'depends on' that ensures that the driver will work but does not get in
> the way of build testing.
>
> Fixes: 98c485eaf509b ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I don't know the answer to the question of if this dependency is needed or
not. But I do agree that it does what it says on the box.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Ramón Nordin Rodriguez" <ramon.nordin.rodriguez@ferroamp.se>,
"Parthiban Veerasooran" <Parthiban.Veerasooran@microchip.com>,
"Frank Sae" <Frank.Sae@motor-comm.com>,
"Michael Walle" <michael@walle.cc>,
"Daniel Golle" <daniel@makrotopia.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] net: phy: mediatek: fix compile-test dependencies
Date: Fri, 16 Jun 2023 13:47:35 +0200 [thread overview]
Message-ID: <ZIxL16HWci5dd7Ah@corigine.com> (raw)
In-Reply-To: <20230616093009.3511692-1-arnd@kernel.org>
On Fri, Jun 16, 2023 at 11:29:54AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new phy driver attempts to select a driver from another subsystem,
> but that fails when the NVMEM subsystem is disabled:
>
> WARNING: unmet direct dependencies detected for NVMEM_MTK_EFUSE
> Depends on [n]: NVMEM [=n] && (ARCH_MEDIATEK [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
> Selected by [y]:
> - MEDIATEK_GE_SOC_PHY [=y] && NETDEVICES [=y] && PHYLIB [=y] && (ARM64 && ARCH_MEDIATEK [=n] || COMPILE_TEST [=y])
>
> I could not see an actual compile time dependency, so presumably this
> is only needed for for working correctly but not technically a dependency
nit: for for -> for
or
for for working correctly -> for correct operation
> on that particular nvmem driver implementation, so it would likely
> be safe to remove the select for compile testing.
>
> To keep the spirit of the original 'select', just replace this with a
> 'depends on' that ensures that the driver will work but does not get in
> the way of build testing.
>
> Fixes: 98c485eaf509b ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I don't know the answer to the question of if this dependency is needed or
not. But I do agree that it does what it says on the box.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-16 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:29 [PATCH] net: phy: mediatek: fix compile-test dependencies Arnd Bergmann
2023-06-16 9:29 ` Arnd Bergmann
2023-06-16 11:47 ` Simon Horman [this message]
2023-06-16 11:47 ` Simon Horman
2023-06-17 22:26 ` Daniel Golle
2023-06-17 22:26 ` Daniel Golle
2023-06-17 4:35 ` Randy Dunlap
2023-06-17 4:35 ` Randy Dunlap
2023-06-20 19:10 ` patchwork-bot+netdevbpf
2023-06-20 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIxL16HWci5dd7Ah@corigine.com \
--to=simon.horman@corigine.com \
--cc=Frank.Sae@motor-comm.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=ramon.nordin.rodriguez@ferroamp.se \
--cc=rdunlap@infradead.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.