All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH 0/5] gnss: updates to support the Renesas KingFisher board
@ 2023-05-23  6:43 Wolfram Sang
  2023-05-23  6:43 ` [RFC PATCH 1/5] WIP: gnss: merge MTK driver into UBX driver Wolfram Sang
                   ` (4 more replies)
  0 siblings, 5 replies; 26+ messages in thread
From: Wolfram Sang @ 2023-05-23  6:43 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Johan Hovold, linux-kernel, Wolfram Sang

Hi, here are some patches with which I can use the GPS receiver on the
Renesas KingFisher board. They are RFC because of my proposal to merge
UBX and MTK drivers in patch 1. Patches 2-5 should be good to go from my
point of view. Looking forward to comments!

   Wolfram


Wolfram Sang (5):
  WIP: gnss: merge MTK driver into UBX driver
  gnss: ubx: use new helper to remove open coded regulator handling
  gnss: ubx: 'vcc' can be optional
  gnss: ubx: add support for the reset gpio
  arm64: dts: renesas: ulcb-kf: add node for GPS

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi |  9 ++-
 drivers/gnss/ubx.c                       | 82 +++++++++++++++---------
 2 files changed, 58 insertions(+), 33 deletions(-)

-- 
2.35.1


^ permalink raw reply	[flat|nested] 26+ messages in thread
* Re: [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio
@ 2023-05-28  4:50 kernel test robot
  0 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2023-05-28  4:50 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230523064310.3005-5-wsa+renesas@sang-engineering.com>
References: <20230523064310.3005-5-wsa+renesas@sang-engineering.com>
TO: Wolfram Sang <wsa-dev@sang-engineering.com>

Hi Wolfram,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on geert-renesas-devel/next]
[also build test WARNING on linus/master v6.4-rc3 next-20230525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wolfram-Sang/WIP-gnss-merge-MTK-driver-into-UBX-driver/20230523-144613
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
patch link:    https://lore.kernel.org/r/20230523064310.3005-5-wsa%2Brenesas%40sang-engineering.com
patch subject: [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: i386-randconfig-m021-20230528 (https://download.01.org/0day-ci/archive/20230528/202305281234.zR27yeIA-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202305281234.zR27yeIA-lkp@intel.com/

smatch warnings:
drivers/gnss/ubx.c:128 ubx_probe() warn: missing unwind goto?

vim +128 drivers/gnss/ubx.c

7b5f4730e4af68 Wolfram Sang 2023-05-23   89  
1ad69f10e3a58d Johan Hovold 2018-06-01   90  static int ubx_probe(struct serdev_device *serdev)
1ad69f10e3a58d Johan Hovold 2018-06-01   91  {
7b5f4730e4af68 Wolfram Sang 2023-05-23   92  	const struct ubx_info *info = of_device_get_match_data(&serdev->dev);
1ad69f10e3a58d Johan Hovold 2018-06-01   93  	struct gnss_serial *gserial;
1ad69f10e3a58d Johan Hovold 2018-06-01   94  	struct ubx_data *data;
1ad69f10e3a58d Johan Hovold 2018-06-01   95  	int ret;
1ad69f10e3a58d Johan Hovold 2018-06-01   96  
7b5f4730e4af68 Wolfram Sang 2023-05-23   97  	if (!info)
7b5f4730e4af68 Wolfram Sang 2023-05-23   98  		return -ENOENT;
7b5f4730e4af68 Wolfram Sang 2023-05-23   99  
1ad69f10e3a58d Johan Hovold 2018-06-01  100  	gserial = gnss_serial_allocate(serdev, sizeof(*data));
1ad69f10e3a58d Johan Hovold 2018-06-01  101  	if (IS_ERR(gserial)) {
1ad69f10e3a58d Johan Hovold 2018-06-01  102  		ret = PTR_ERR(gserial);
1ad69f10e3a58d Johan Hovold 2018-06-01  103  		return ret;
1ad69f10e3a58d Johan Hovold 2018-06-01  104  	}
1ad69f10e3a58d Johan Hovold 2018-06-01  105  
1ad69f10e3a58d Johan Hovold 2018-06-01  106  	gserial->ops = &ubx_gserial_ops;
1ad69f10e3a58d Johan Hovold 2018-06-01  107  
7b5f4730e4af68 Wolfram Sang 2023-05-23  108  	gserial->gdev->type = info->type;
10f146639fee5f Johan Hovold 2018-06-01  109  
1ad69f10e3a58d Johan Hovold 2018-06-01  110  	data = gnss_serial_get_drvdata(gserial);
1ad69f10e3a58d Johan Hovold 2018-06-01  111  
23c5c7e33b0fc6 Wolfram Sang 2023-05-23  112  	data->vcc = devm_regulator_get_optional(&serdev->dev, "vcc");
1ad69f10e3a58d Johan Hovold 2018-06-01  113  	if (IS_ERR(data->vcc)) {
1ad69f10e3a58d Johan Hovold 2018-06-01  114  		ret = PTR_ERR(data->vcc);
23c5c7e33b0fc6 Wolfram Sang 2023-05-23  115  		if (ret == -ENODEV)
23c5c7e33b0fc6 Wolfram Sang 2023-05-23  116  			data->vcc = NULL;
23c5c7e33b0fc6 Wolfram Sang 2023-05-23  117  		else
1ad69f10e3a58d Johan Hovold 2018-06-01  118  			goto err_free_gserial;
1ad69f10e3a58d Johan Hovold 2018-06-01  119  	}
1ad69f10e3a58d Johan Hovold 2018-06-01  120  
58f289a9dc7461 Wolfram Sang 2023-05-23  121  	ret = devm_regulator_get_enable_optional(&serdev->dev, info->v_bckp_name);
58f289a9dc7461 Wolfram Sang 2023-05-23  122  	if (ret < 0 && ret != -ENODEV)
1ad69f10e3a58d Johan Hovold 2018-06-01  123  		goto err_free_gserial;
1ad69f10e3a58d Johan Hovold 2018-06-01  124  
32522a4fa4ae01 Wolfram Sang 2023-05-23  125  	/* Start with reset asserted (GPIO must be active low!) */
32522a4fa4ae01 Wolfram Sang 2023-05-23  126  	data->reset_gpio = devm_gpiod_get_optional(&serdev->dev, "reset", GPIOD_OUT_HIGH);
32522a4fa4ae01 Wolfram Sang 2023-05-23  127  	if (IS_ERR(data->reset_gpio))
32522a4fa4ae01 Wolfram Sang 2023-05-23 @128  		return PTR_ERR(data->reset_gpio);
32522a4fa4ae01 Wolfram Sang 2023-05-23  129  
1ad69f10e3a58d Johan Hovold 2018-06-01  130  	ret = gnss_serial_register(gserial);
1ad69f10e3a58d Johan Hovold 2018-06-01  131  	if (ret)
58f289a9dc7461 Wolfram Sang 2023-05-23  132  		goto err_free_gserial;
1ad69f10e3a58d Johan Hovold 2018-06-01  133  
1ad69f10e3a58d Johan Hovold 2018-06-01  134  	return 0;
1ad69f10e3a58d Johan Hovold 2018-06-01  135  
1ad69f10e3a58d Johan Hovold 2018-06-01  136  err_free_gserial:
1ad69f10e3a58d Johan Hovold 2018-06-01  137  	gnss_serial_free(gserial);
1ad69f10e3a58d Johan Hovold 2018-06-01  138  
1ad69f10e3a58d Johan Hovold 2018-06-01  139  	return ret;
1ad69f10e3a58d Johan Hovold 2018-06-01  140  }
1ad69f10e3a58d Johan Hovold 2018-06-01  141  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2023-06-20 14:50 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-23  6:43 [RFC PATCH 0/5] gnss: updates to support the Renesas KingFisher board Wolfram Sang
2023-05-23  6:43 ` [RFC PATCH 1/5] WIP: gnss: merge MTK driver into UBX driver Wolfram Sang
2023-05-25 20:10   ` kernel test robot
2023-06-12 11:35   ` Wolfram Sang
2023-06-20  7:13     ` Johan Hovold
2023-06-20  9:00       ` Wolfram Sang
2023-06-20 10:21       ` Wolfram Sang
2023-06-20 14:50         ` Johan Hovold
2023-05-23  6:43 ` [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling Wolfram Sang
2023-06-20  8:48   ` Johan Hovold
2023-06-20  9:04     ` Wolfram Sang
2023-06-20  9:08       ` Johan Hovold
2023-05-23  6:43 ` [RFC PATCH 3/5] gnss: ubx: 'vcc' can be optional Wolfram Sang
2023-06-20  7:15   ` Johan Hovold
2023-06-20  9:04     ` Wolfram Sang
2023-05-23  6:43 ` [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio Wolfram Sang
2023-05-29  9:30   ` Dan Carpenter
2023-06-20 10:36     ` Wolfram Sang
2023-06-20  7:17   ` Johan Hovold
2023-06-20  9:06     ` Wolfram Sang
2023-06-20  9:12       ` Johan Hovold
2023-06-20  9:41         ` Wolfram Sang
2023-06-20 10:05           ` Johan Hovold
2023-06-20 10:14             ` Wolfram Sang
2023-05-23  6:43 ` [RFC PATCH 5/5] arm64: dts: renesas: ulcb-kf: add node for GPS Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2023-05-28  4:50 [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.