All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>, "Kalle Valo" <kvalo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Pradeep Kumar Chitrapu" <quic_pradeepc@quicinc.com>,
	"P Praneesh" <quic_ppranees@quicinc.com>,
	"Bhagavathi Perumal S" <quic_bperumal@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Karthikeyan Periyasamy" <quic_periyasa@quicinc.com>,
	ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dean Luick" <dean.luick@cornelisnetworks.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 09/10] wifi: ath12k: Use RMW accessors for changing LNKCTL
Date: Wed, 21 Jun 2023 16:47:36 +0200	[thread overview]
Message-ID: <ZJMNiEw0IekR684V@corigine.com> (raw)
In-Reply-To: <20230620134624.99688-10-ilpo.jarvinen@linux.intel.com>

On Tue, Jun 20, 2023 at 04:46:23PM +0300, Ilpo Järvinen wrote:
> Don't assume that only the driver would be accessing LNKCTL. ASPM
> policy changes can trigger write to LNKCTL outside of driver's control.
> 
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value. On restore, clear the ASPMC
> field properly.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Acked-by: Kalle Valo <kvalo@kernel.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/net/wireless/ath/ath12k/pci.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Simon Horman <simon.horman@corigine.com>


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>, "Kalle Valo" <kvalo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Pradeep Kumar Chitrapu" <quic_pradeepc@quicinc.com>,
	"P Praneesh" <quic_ppranees@quicinc.com>,
	"Bhagavathi Perumal S" <quic_bperumal@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Karthikeyan Periyasamy" <quic_periyasa@quicinc.com>,
	ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dean Luick" <dean.luick@cornelisnetworks.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 09/10] wifi: ath12k: Use RMW accessors for changing LNKCTL
Date: Wed, 21 Jun 2023 16:47:36 +0200	[thread overview]
Message-ID: <ZJMNiEw0IekR684V@corigine.com> (raw)
In-Reply-To: <20230620134624.99688-10-ilpo.jarvinen@linux.intel.com>

On Tue, Jun 20, 2023 at 04:46:23PM +0300, Ilpo Järvinen wrote:
> Don't assume that only the driver would be accessing LNKCTL. ASPM
> policy changes can trigger write to LNKCTL outside of driver's control.
> 
> Use RMW capability accessors which do proper locking to avoid losing
> concurrent updates to the register value. On restore, clear the ASPMC
> field properly.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Acked-by: Kalle Valo <kvalo@kernel.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/net/wireless/ath/ath12k/pci.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Simon Horman <simon.horman@corigine.com>


  reply	other threads:[~2023-06-21 14:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 13:46 [PATCH v3 00/10] PCI: Improve PCIe Capability RMW concurrency control Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 01/10] PCI: Add locking to RMW PCI Express Capability Register accessors Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 02/10] PCI: Make link retraining use RMW accessors for changing LNKCTL Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 03/10] PCI: pciehp: Use " Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 04/10] PCI/ASPM: " Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 05/10] drm/amdgpu: " Ilpo Järvinen
2023-06-20 13:46   ` Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 06/10] drm/radeon: " Ilpo Järvinen
2023-06-20 13:46   ` Ilpo Järvinen
2023-06-20 13:46 ` [PATCH v3 07/10] net/mlx5: " Ilpo Järvinen
2023-06-21 14:46   ` Simon Horman
2023-06-20 13:46 ` [PATCH v3 08/10] wifi: ath11k: " Ilpo Järvinen
2023-06-20 13:46   ` Ilpo Järvinen
2023-06-21 14:47   ` Simon Horman
2023-06-21 14:47     ` Simon Horman
2023-06-20 13:46 ` [PATCH v3 09/10] wifi: ath12k: " Ilpo Järvinen
2023-06-20 13:46   ` Ilpo Järvinen
2023-06-21 14:47   ` Simon Horman [this message]
2023-06-21 14:47     ` Simon Horman
2023-06-20 13:46 ` [PATCH v3 10/10] wifi: ath10k: " Ilpo Järvinen
2023-06-20 13:46   ` Ilpo Järvinen
2023-06-21 14:46   ` Simon Horman
2023-06-21 14:46     ` Simon Horman
2023-06-20 14:11 ` [PATCH v3 00/10] PCI: Improve PCIe Capability RMW concurrency control Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJMNiEw0IekR684V@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ath12k@lists.infradead.org \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=dean.luick@cornelisnetworks.com \
    --cc=edumazet@google.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=hkallweit1@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lukas@wunner.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_bperumal@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_periyasa@quicinc.com \
    --cc=quic_ppranees@quicinc.com \
    --cc=quic_pradeepc@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.