From: Simon Horman <simon.horman@corigine.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: pmenzel@molgen.mpg.de, netdev@vger.kernel.org, gal@nvidia.com,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next] net: fix net device address assign type
Date: Thu, 22 Jun 2023 08:37:10 +0200 [thread overview]
Message-ID: <ZJPsFjXtuam5J6Rs@corigine.com> (raw)
In-Reply-To: <20230621132106.991342-1-piotrx.gardocki@intel.com>
On Wed, Jun 21, 2023 at 03:21:06PM +0200, Piotr Gardocki wrote:
> Commit ad72c4a06acc introduced optimization to return from function
> quickly if the MAC address is not changing at all. It was reported
> that such change causes dev->addr_assign_type to not change
> to NET_ADDR_SET from _PERM or _RANDOM.
> Restore the old behavior and skip only call to ndo_set_mac_address.
>
> Fixes: ad72c4a06acc ("net: add check for current MAC address in dev_set_mac_address")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com,
pmenzel@molgen.mpg.de, kuba@kernel.org,
maciej.fijalkowski@intel.com, anthony.l.nguyen@intel.com,
aleksander.lobakin@intel.com, gal@nvidia.com
Subject: Re: [PATCH net-next] net: fix net device address assign type
Date: Thu, 22 Jun 2023 08:37:10 +0200 [thread overview]
Message-ID: <ZJPsFjXtuam5J6Rs@corigine.com> (raw)
In-Reply-To: <20230621132106.991342-1-piotrx.gardocki@intel.com>
On Wed, Jun 21, 2023 at 03:21:06PM +0200, Piotr Gardocki wrote:
> Commit ad72c4a06acc introduced optimization to return from function
> quickly if the MAC address is not changing at all. It was reported
> that such change causes dev->addr_assign_type to not change
> to NET_ADDR_SET from _PERM or _RANDOM.
> Restore the old behavior and skip only call to ndo_set_mac_address.
>
> Fixes: ad72c4a06acc ("net: add check for current MAC address in dev_set_mac_address")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-22 6:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:21 [Intel-wired-lan] [PATCH net-next] net: fix net device address assign type Piotr Gardocki
2023-06-21 13:21 ` Piotr Gardocki
2023-06-22 6:37 ` Simon Horman [this message]
2023-06-22 6:37 ` Simon Horman
2023-06-22 8:22 ` [Intel-wired-lan] " Jiri Pirko
2023-06-22 8:22 ` Jiri Pirko
2023-06-22 12:42 ` [Intel-wired-lan] " Piotr Gardocki
2023-06-22 12:42 ` Piotr Gardocki
2023-06-22 13:37 ` [Intel-wired-lan] " Jiri Pirko
2023-06-22 13:37 ` Jiri Pirko
2023-06-23 3:00 ` [Intel-wired-lan] " patchwork-bot+netdevbpf
2023-06-23 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJPsFjXtuam5J6Rs@corigine.com \
--to=simon.horman@corigine.com \
--cc=anthony.l.nguyen@intel.com \
--cc=gal@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.