All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: mjrosato@linux.ibm.com, jasowang@redhat.com,
	xudong.hao@intel.com, zhenzhong.duan@intel.com,
	peterx@redhat.com, terrence.xu@intel.com,
	chao.p.peng@linux.intel.com, linux-s390@vger.kernel.org,
	kvm@vger.kernel.org, lulu@redhat.com, yanting.jiang@intel.com,
	joro@8bytes.org, nicolinc@nvidia.com, kevin.tian@intel.com,
	yan.y.zhao@intel.com, intel-gfx@lists.freedesktop.org,
	eric.auger@redhat.com, intel-gvt-dev@lists.freedesktop.org,
	yi.y.sun@linux.intel.com, clegoate@redhat.com, cohuck@redhat.com,
	shameerali.kolothum.thodi@huawei.com,
	suravee.suthikulpanit@amd.com, robin.murphy@arm.com
Subject: Re: [Intel-gfx] [PATCH v8 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev
Date: Thu, 22 Jun 2023 12:22:04 -0300	[thread overview]
Message-ID: <ZJRnHO0p+pPgBZdr@nvidia.com> (raw)
In-Reply-To: <20230616093042.65094-9-yi.l.liu@intel.com>

On Fri, Jun 16, 2023 at 02:30:40AM -0700, Yi Liu wrote:
> This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx
> of the cdev device to check the ownership of the other affected devices.
> 
> When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed
> device, the new flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID is reported to indicate
> the values returned are IOMMUFD devids rather than group IDs as used when
> accessing vfio devices through the conventional vfio group interface.
> Additionally the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED will be reported
> in this mode if all of the devices affected by the hot-reset are owned by
> either virtue of being directly bound to the same iommufd context as the
> calling device, or implicitly owned via a shared IOMMU group.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/vfio/iommufd.c           | 44 ++++++++++++++++++++++++++
>  drivers/vfio/pci/vfio_pci_core.c | 54 +++++++++++++++++++++++++++-----
>  include/linux/vfio.h             | 14 +++++++++
>  include/uapi/linux/vfio.h        | 50 ++++++++++++++++++++++++++++-
>  4 files changed, 154 insertions(+), 8 deletions(-)

I would have put patch 9 before this one, but it is OK this way too

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: alex.williamson@redhat.com, kevin.tian@intel.com,
	joro@8bytes.org, robin.murphy@arm.com, cohuck@redhat.com,
	eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
	mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
	yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
	shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
	suravee.suthikulpanit@amd.com,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-s390@vger.kernel.org,
	xudong.hao@intel.com, yan.y.zhao@intel.com,
	terrence.xu@intel.com, yanting.jiang@intel.com,
	zhenzhong.duan@intel.com, clegoate@redhat.com
Subject: Re: [PATCH v8 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev
Date: Thu, 22 Jun 2023 12:22:04 -0300	[thread overview]
Message-ID: <ZJRnHO0p+pPgBZdr@nvidia.com> (raw)
In-Reply-To: <20230616093042.65094-9-yi.l.liu@intel.com>

On Fri, Jun 16, 2023 at 02:30:40AM -0700, Yi Liu wrote:
> This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx
> of the cdev device to check the ownership of the other affected devices.
> 
> When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed
> device, the new flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID is reported to indicate
> the values returned are IOMMUFD devids rather than group IDs as used when
> accessing vfio devices through the conventional vfio group interface.
> Additionally the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED will be reported
> in this mode if all of the devices affected by the hot-reset are owned by
> either virtue of being directly bound to the same iommufd context as the
> calling device, or implicitly owned via a shared IOMMU group.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/vfio/iommufd.c           | 44 ++++++++++++++++++++++++++
>  drivers/vfio/pci/vfio_pci_core.c | 54 +++++++++++++++++++++++++++-----
>  include/linux/vfio.h             | 14 +++++++++
>  include/uapi/linux/vfio.h        | 50 ++++++++++++++++++++++++++++-
>  4 files changed, 154 insertions(+), 8 deletions(-)

I would have put patch 9 before this one, but it is OK this way too

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

  reply	other threads:[~2023-06-22 15:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  9:30 [Intel-gfx] [PATCH v8 00/10] Enhance vfio PCI hot reset for vfio cdev device Yi Liu
2023-06-16  9:30 ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 01/10] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 02/10] vfio/pci: Move the existing hot reset logic to be a helper Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 03/10] iommufd: Reserve all negative IDs in the iommufd xarray Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 04/10] iommufd: Add iommufd_ctx_has_group() Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 05/10] iommufd: Add helper to retrieve iommufd_ctx and devid Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 06/10] vfio: Mark cdev usage in vfio_device Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 07/10] vfio: Add helper to search vfio_device in a dev_set Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-22 15:22   ` Jason Gunthorpe [this message]
2023-06-22 15:22     ` Jason Gunthorpe
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 09/10] vfio/pci: Copy hot-reset device info to userspace in the devices loop Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16  9:30 ` [Intel-gfx] [PATCH v8 10/10] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu
2023-06-16  9:30   ` Yi Liu
2023-06-16 10:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enhance vfio PCI hot reset for vfio cdev device (rev8) Patchwork
2023-06-16 10:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-16 14:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJRnHO0p+pPgBZdr@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=clegoate@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jasowang@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=nicolinc@nvidia.com \
    --cc=peterx@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=terrence.xu@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=yan.y.zhao@intel.com \
    --cc=yanting.jiang@intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.