From: Josh Triplett <josh@joshtriplett.org>
To: Allen Ballway <ballway@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed
Date: Thu, 22 Jun 2023 10:51:02 -0700 [thread overview]
Message-ID: <ZJSKBg+LymhvINoG@localhost> (raw)
In-Reply-To: <20230622172817.2281527-1-ballway@chromium.org>
On Thu, Jun 22, 2023 at 05:28:15PM +0000, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct intel_connector *connector)
>
> drm_WARN_ON(&i915->drm, panel->backlight.pwm_level_max == 0);
>
> + if (intel_has_quirk(i915, QUIRK_NO_DIM)) {
> + /* Cannot dim backlight, set minimum to hightest value */
Typo: s/hightest/highest/
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Allen Ballway <ballway@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, arun.r.murthy@intel.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed
Date: Thu, 22 Jun 2023 10:51:02 -0700 [thread overview]
Message-ID: <ZJSKBg+LymhvINoG@localhost> (raw)
In-Reply-To: <20230622172817.2281527-1-ballway@chromium.org>
On Thu, Jun 22, 2023 at 05:28:15PM +0000, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct intel_connector *connector)
>
> drm_WARN_ON(&i915->drm, panel->backlight.pwm_level_max == 0);
>
> + if (intel_has_quirk(i915, QUIRK_NO_DIM)) {
> + /* Cannot dim backlight, set minimum to hightest value */
Typo: s/hightest/highest/
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Allen Ballway <ballway@chromium.org>
Cc: arun.r.murthy@intel.com, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed
Date: Thu, 22 Jun 2023 10:51:02 -0700 [thread overview]
Message-ID: <ZJSKBg+LymhvINoG@localhost> (raw)
In-Reply-To: <20230622172817.2281527-1-ballway@chromium.org>
On Thu, Jun 22, 2023 at 05:28:15PM +0000, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct intel_connector *connector)
>
> drm_WARN_ON(&i915->drm, panel->backlight.pwm_level_max == 0);
>
> + if (intel_has_quirk(i915, QUIRK_NO_DIM)) {
> + /* Cannot dim backlight, set minimum to hightest value */
Typo: s/hightest/highest/
next prev parent reply other threads:[~2023-06-22 18:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 21:25 [Intel-gfx] [PATCH] drm/i915/quirk: Add quirk for devices that cannot be dimmed Allen Ballway
2023-06-06 21:25 ` Allen Ballway
2023-06-06 21:25 ` Allen Ballway
2023-06-07 0:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-06-07 0:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-07 16:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-22 17:28 ` [Intel-gfx] [PATCH v2] " Allen Ballway
2023-06-22 17:28 ` Allen Ballway
2023-06-22 17:28 ` Allen Ballway
2023-06-22 17:51 ` Josh Triplett [this message]
2023-06-22 17:51 ` Josh Triplett
2023-06-22 17:51 ` Josh Triplett
2023-06-29 17:21 ` [Intel-gfx] [PATCH] " Allen Ballway
2023-06-29 17:21 ` Allen Ballway
2023-06-29 17:21 ` Allen Ballway
2023-08-08 17:39 ` [Intel-gfx] [PATCH v3 RESEND] " Allen Ballway
2023-08-08 17:39 ` Allen Ballway
2023-08-08 17:39 ` Allen Ballway
2023-09-11 17:29 ` [Intel-gfx] " Jani Nikula
2023-09-11 17:29 ` Jani Nikula
2023-09-11 17:29 ` Jani Nikula
2023-06-22 18:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev2) Patchwork
2023-06-23 8:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-29 19:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev3) Patchwork
2023-08-08 19:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev4) Patchwork
2023-08-08 19:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-08 19:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-09 6:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJSKBg+LymhvINoG@localhost \
--to=josh@joshtriplett.org \
--cc=ballway@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.