From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Caleb D.S. Brzezinski" <calebdsb@protonmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: Wrap macro definitions in parenthesis
Date: Tue, 27 Jun 2023 18:09:31 +0700 [thread overview]
Message-ID: <ZJrDazgexlKD7EjI@debian.me> (raw)
In-Reply-To: <20210616212552.117604-1-calebdsb@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
On Wed, Jun 16, 2021 at 09:26:03PM +0000, Caleb D.S. Brzezinski wrote:
> /* 11b rate */
> -#define TX_RATE_1M (u8)(10 / 5) /* 11b 11g basic rate */
> -#define TX_RATE_2M (u8)(20 / 5) /* 11b 11g basic rate */
> -#define TX_RATE_5M (u8)(55 / 5) /* 11g basic rate */
> -#define TX_RATE_11M (u8)(110 / 5) /* 11g basic rate */
> +#define TX_RATE_1M ((u8)(10 / 5)) /* 11b 11g basic rate */
> +#define TX_RATE_2M ((u8)(20 / 5)) /* 11b 11g basic rate */
> +#define TX_RATE_5M ((u8)(55 / 5)) /* 11g basic rate */
> +#define TX_RATE_11M ((u8)(110 / 5)) /* 11g basic rate */
>
> /* 11g rate */
> -#define TX_RATE_6M (u8)(60 / 5) /* 11g basic rate */
> -#define TX_RATE_12M (u8)(120 / 5) /* 11g basic rate */
> -#define TX_RATE_24M (u8)(240 / 5) /* 11g basic rate */
> -#define TX_RATE_9M (u8)(90 / 5)
> -#define TX_RATE_18M (u8)(180 / 5)
> -#define TX_RATE_36M (u8)(360 / 5)
> -#define TX_RATE_48M (u8)(480 / 5)
> -#define TX_RATE_54M (u8)(540 / 5)
> +#define TX_RATE_6M ((u8)(60 / 5)) /* 11g basic rate */
> +#define TX_RATE_12M ((u8)(120 / 5)) /* 11g basic rate */
> +#define TX_RATE_24M ((u8)(240 / 5)) /* 11g basic rate */
> +#define TX_RATE_9M ((u8)(90 / 5))
> +#define TX_RATE_18M ((u8)(180 / 5))
> +#define TX_RATE_36M ((u8)(360 / 5))
> +#define TX_RATE_48M ((u8)(480 / 5))
> +#define TX_RATE_54M ((u8)(540 / 5))
>
tl;dr (quoted from Greg's bot):
> You sent a patch that has been sent multiple times in the past few
> days, and is identical to ones that has been recently rejected.
> Please always look at the mailing list traffic to determine if you are
> duplicating other people's work.
Why? See discussions on [1] and [2].
[1]: https://lore.kernel.org/all/YCUAy1VhLV3lwa3H@kroah.com/
[2]: https://lore.kernel.org/all/20210222062849.GN2087@kadam/
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-06-27 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 21:26 [PATCH] staging: ks7010: Wrap macro definitions in parenthesis Caleb D.S. Brzezinski
2023-06-27 11:09 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJrDazgexlKD7EjI@debian.me \
--to=bagasdotme@gmail.com \
--cc=calebdsb@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.