All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Morgan <macroalpha82@gmail.com>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Maya Matuszczyk <maccraft123mc@gmail.com>,
	Lee Jones <lee@kernel.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	linux-rockchip@lists.infradead.org, stable@vger.kernel.org,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: rk817: Add missing module alias
Date: Tue, 27 Jun 2023 12:39:29 -0500	[thread overview]
Message-ID: <ZJse0Z7OMeh+tuur@wintermute.localhost.fail> (raw)
In-Reply-To: <20230612143651.959646-2-frattaroli.nicolas@gmail.com>

On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
> 
> Add the right MODULE_ALIAS to fix this.
> 

Good catch, thank you.

Reviewed-by: Chris Morgan <macromorgan@hotmail.com>

> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  drivers/power/supply/rk817_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
>  MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
>  MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> -- 
> 2.41.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Maya Matuszczyk <maccraft123mc@gmail.com>,
	Lee Jones <lee@kernel.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	linux-rockchip@lists.infradead.org, stable@vger.kernel.org,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: rk817: Add missing module alias
Date: Tue, 27 Jun 2023 12:39:29 -0500	[thread overview]
Message-ID: <ZJse0Z7OMeh+tuur@wintermute.localhost.fail> (raw)
In-Reply-To: <20230612143651.959646-2-frattaroli.nicolas@gmail.com>

On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
> 
> Add the right MODULE_ALIAS to fix this.
> 

Good catch, thank you.

Reviewed-by: Chris Morgan <macromorgan@hotmail.com>

> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  drivers/power/supply/rk817_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
>  MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
>  MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> -- 
> 2.41.0
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2023-06-27 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 14:36 [PATCH] power: supply: rk817: Add missing module alias Nicolas Frattaroli
2023-06-12 14:36 ` Nicolas Frattaroli
2023-06-27 17:39 ` Chris Morgan [this message]
2023-06-27 17:39   ` Chris Morgan
2023-09-14 16:03 ` Sebastian Reichel
2023-09-14 16:03   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJse0Z7OMeh+tuur@wintermute.localhost.fail \
    --to=macroalpha82@gmail.com \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maccraft123mc@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=sebastian.reichel@collabora.com \
    --cc=sre@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.