All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [RFC PATCH 7/8] ASoC: Intel: Skylake: Update PCI ID list
Date: Wed, 28 Jun 2023 17:52:34 +0300	[thread overview]
Message-ID: <ZJxJMg0bldj/M7TY@smile.fi.intel.com> (raw)
In-Reply-To: <20230628205135.517241-8-amadeuszx.slawinski@linux.intel.com>

On Wed, Jun 28, 2023 at 10:51:34PM +0200, Amadeusz Sławiński wrote:
> Use PCI device IDs from pci_ids.h header and while at it change to using
> PCI_DEVICE_DATA macro, to simplify declarations.

PCI_DEVICE_DATA()

...

> +	{ PCI_DEVICE_DATA(INTEL, HDA_SKL_LP,	&snd_soc_acpi_intel_skl_machines) },

Do you really need TAB(s) in the parameter list?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-06-28 14:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 20:51 [RFC PATCH 0/8] PCI: Define Intel PCI IDs and use them in drivers Amadeusz Sławiński
2023-06-28 13:00 ` Mark Brown
2023-06-28 14:49 ` Andy Shevchenko
2023-06-28 15:57   ` Pierre-Louis Bossart
2023-06-28 20:51 ` [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h Amadeusz Sławiński
2023-06-28 14:44   ` Andy Shevchenko
2023-06-29  8:18     ` Amadeusz Sławiński
2023-06-29 16:09   ` Bjorn Helgaas
2023-06-28 20:51 ` [RFC PATCH 2/8] ALSA: intel-dsp-config: Update PCI ID list Amadeusz Sławiński
2023-06-28 20:51 ` [RFC PATCH 3/8] ALSA: hda: " Amadeusz Sławiński
2023-06-28 14:47   ` Andy Shevchenko
2023-06-29  8:18     ` Amadeusz Sławiński
2023-06-29 16:08   ` Bjorn Helgaas
2023-06-28 20:51 ` [RFC PATCH 4/8] ALSA: hda/i915: Update PCI IDs Amadeusz Sławiński
2023-06-28 14:42   ` Andy Shevchenko
2023-06-28 14:44     ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 5/8] ASoC: Intel: avs: Update PCI ID list Amadeusz Sławiński
2023-06-28 14:48   ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 6/8] " Amadeusz Sławiński
2023-06-28 14:51   ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 7/8] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-06-28 14:52   ` Andy Shevchenko [this message]
2023-06-29  8:19     ` Amadeusz Sławiński
2023-06-29  9:28       ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 8/8] ASoC: SOF: Intel: " Amadeusz Sławiński
2023-06-28 14:54   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJxJMg0bldj/M7TY@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.