From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h
Date: Thu, 29 Jun 2023 10:18:50 +0200 [thread overview]
Message-ID: <a7bf3aaa-581d-0625-5f18-6b9b062ea48d@linux.intel.com> (raw)
In-Reply-To: <ZJxHTHCq0T/y+dG0@smile.fi.intel.com>
On 6/28/2023 4:44 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote:
>> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
>> Almost every use contains additional comments to identify to which
>> platform those IDs refer to. Add those IDs to pci_ids.h header, so that
>> there is one place which defines those names.
>
> ...
>
>> #define PCI_DEVICE_ID_INTEL_5400_FBD0 0x4035
>> #define PCI_DEVICE_ID_INTEL_5400_FBD1 0x4036
>> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N 0x4dc8
>> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H 0x43c8
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0 0x4b55
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3 0x4b58
>
> Can it be kept sorted by a value?
>
> Didn't check the full list, though.
>
My mistake, I've tried to add them in order, but must have missed this
one, will review whole list again.
next prev parent reply other threads:[~2023-06-29 8:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 20:51 [RFC PATCH 0/8] PCI: Define Intel PCI IDs and use them in drivers Amadeusz Sławiński
2023-06-28 13:00 ` Mark Brown
2023-06-28 14:49 ` Andy Shevchenko
2023-06-28 15:57 ` Pierre-Louis Bossart
2023-06-28 20:51 ` [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h Amadeusz Sławiński
2023-06-28 14:44 ` Andy Shevchenko
2023-06-29 8:18 ` Amadeusz Sławiński [this message]
2023-06-29 16:09 ` Bjorn Helgaas
2023-06-28 20:51 ` [RFC PATCH 2/8] ALSA: intel-dsp-config: Update PCI ID list Amadeusz Sławiński
2023-06-28 20:51 ` [RFC PATCH 3/8] ALSA: hda: " Amadeusz Sławiński
2023-06-28 14:47 ` Andy Shevchenko
2023-06-29 8:18 ` Amadeusz Sławiński
2023-06-29 16:08 ` Bjorn Helgaas
2023-06-28 20:51 ` [RFC PATCH 4/8] ALSA: hda/i915: Update PCI IDs Amadeusz Sławiński
2023-06-28 14:42 ` Andy Shevchenko
2023-06-28 14:44 ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 5/8] ASoC: Intel: avs: Update PCI ID list Amadeusz Sławiński
2023-06-28 14:48 ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 6/8] " Amadeusz Sławiński
2023-06-28 14:51 ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 7/8] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-06-28 14:52 ` Andy Shevchenko
2023-06-29 8:19 ` Amadeusz Sławiński
2023-06-29 9:28 ` Andy Shevchenko
2023-06-28 20:51 ` [RFC PATCH 8/8] ASoC: SOF: Intel: " Amadeusz Sławiński
2023-06-28 14:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7bf3aaa-581d-0625-5f18-6b9b062ea48d@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.