From: Bill O'Donnell <billodo@redhat.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: axboe@kernel.dk, song@kernel.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, xiang@kernel.org, chao@kernel.org,
huyue2@coolpad.com, jefflexu@linux.alibaba.com,
hch@infradead.org, djwong@kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/7] xfs: Convert to bdev_logical_block_mask()
Date: Wed, 28 Jun 2023 11:41:27 -0500 [thread overview]
Message-ID: <ZJxit/naWMq3v6OU@redhat.com> (raw)
In-Reply-To: <20230628093500.68779-6-frank.li@vivo.com>
On Wed, Jun 28, 2023 at 05:34:59PM +0800, Yangtao Li wrote:
> Use bdev_logical_block_mask() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
> ---
> fs/xfs/xfs_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 15d1e5a7c2d3..f784daa21219 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1968,7 +1968,7 @@ xfs_setsize_buftarg(
>
> /* Set up device logical sector size mask */
> btp->bt_logical_sectorsize = bdev_logical_block_size(btp->bt_bdev);
> - btp->bt_logical_sectormask = bdev_logical_block_size(btp->bt_bdev) - 1;
> + btp->bt_logical_sectormask = bdev_logical_block_mask(btp->bt_bdev);
>
> return 0;
> }
> --
> 2.39.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Bill O'Donnell <billodo@redhat.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, brauner@kernel.org,
linux-raid@vger.kernel.org, djwong@kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org, song@kernel.org,
huyue2@coolpad.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/7] xfs: Convert to bdev_logical_block_mask()
Date: Wed, 28 Jun 2023 11:41:27 -0500 [thread overview]
Message-ID: <ZJxit/naWMq3v6OU@redhat.com> (raw)
In-Reply-To: <20230628093500.68779-6-frank.li@vivo.com>
On Wed, Jun 28, 2023 at 05:34:59PM +0800, Yangtao Li wrote:
> Use bdev_logical_block_mask() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
> ---
> fs/xfs/xfs_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 15d1e5a7c2d3..f784daa21219 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1968,7 +1968,7 @@ xfs_setsize_buftarg(
>
> /* Set up device logical sector size mask */
> btp->bt_logical_sectorsize = bdev_logical_block_size(btp->bt_bdev);
> - btp->bt_logical_sectormask = bdev_logical_block_size(btp->bt_bdev) - 1;
> + btp->bt_logical_sectormask = bdev_logical_block_mask(btp->bt_bdev);
>
> return 0;
> }
> --
> 2.39.0
>
next prev parent reply other threads:[~2023-06-28 16:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 9:34 [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 9:34 ` [PATCH 2/7] block: Convert to bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 9:34 ` [PATCH 3/7] md: Convert to queue_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 9:34 ` [PATCH 4/7] buffer: Convert to bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 9:34 ` [PATCH 5/7] iomap: " Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 9:34 ` [PATCH 6/7] xfs: " Yangtao Li
2023-06-28 9:34 ` Yangtao Li
2023-06-28 16:41 ` Bill O'Donnell [this message]
2023-06-28 16:41 ` Bill O'Donnell
2023-06-28 9:35 ` [PATCH 7/7] erofs: " Yangtao Li
2023-06-28 9:35 ` Yangtao Li
2023-06-28 16:45 ` [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask() Bill O'Donnell
2023-06-28 16:45 ` Bill O'Donnell
2023-06-28 16:46 ` Matthew Wilcox
2023-06-28 16:46 ` Matthew Wilcox
2023-06-29 3:44 ` Yangtao Li
2023-06-29 3:44 ` Yangtao Li
2023-06-29 4:34 ` Darrick J. Wong
2023-06-29 4:34 ` Darrick J. Wong
2023-06-29 5:44 ` Christoph Hellwig
2023-06-29 5:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJxit/naWMq3v6OU@redhat.com \
--to=billodo@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=frank.li@vivo.com \
--cc=hch@infradead.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.