All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: hanyu001@208suo.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit
Date: Thu, 13 Jul 2023 11:16:20 +0100	[thread overview]
Message-ID: <ZK/O9Dc2aYtXEKHd@shell.armlinux.org.uk> (raw)
In-Reply-To: <72204230a061f7d5bf19f09d524203ce@208suo.com>

On Thu, Jul 13, 2023 at 06:06:15PM +0800, hanyu001@208suo.com wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.
> 
> Fix the coccicheck warning:
> WARNING: use scnprintf or sprintf.
> 
> ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf
> 
> Signed-off-by: ztt <1549089851@qq.com>
> ---
>  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
> index 993fefdc167a..d20626451a2e 100644
> --- a/arch/arm/mm/cache-l2x0-pmu.c
> +++ b/arch/arm/mm/cache-l2x0-pmu.c
> @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
>      struct l2x0_event_attribute *lattr;
> 
>      lattr = container_of(attr, typeof(*lattr), attr);
> -    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> +    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);

This only serves to shut up a warning. On 32-bit ARM, there is utterly
no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes,
or even 32 bytes!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: hanyu001@208suo.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit
Date: Thu, 13 Jul 2023 11:16:20 +0100	[thread overview]
Message-ID: <ZK/O9Dc2aYtXEKHd@shell.armlinux.org.uk> (raw)
In-Reply-To: <72204230a061f7d5bf19f09d524203ce@208suo.com>

On Thu, Jul 13, 2023 at 06:06:15PM +0800, hanyu001@208suo.com wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.
> 
> Fix the coccicheck warning:
> WARNING: use scnprintf or sprintf.
> 
> ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf
> 
> Signed-off-by: ztt <1549089851@qq.com>
> ---
>  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
> index 993fefdc167a..d20626451a2e 100644
> --- a/arch/arm/mm/cache-l2x0-pmu.c
> +++ b/arch/arm/mm/cache-l2x0-pmu.c
> @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
>      struct l2x0_event_attribute *lattr;
> 
>      lattr = container_of(attr, typeof(*lattr), attr);
> -    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> +    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);

This only serves to shut up a warning. On 32-bit ARM, there is utterly
no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes,
or even 32 bytes!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2023-07-13 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_EFB5DEE75502CBD51C95CFE33D443DB41608@qq.com>
2023-07-13 10:06 ` Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit hanyu001
2023-07-13 10:06   ` hanyu001
2023-07-13 10:16   ` Russell King (Oracle) [this message]
2023-07-13 10:16     ` Russell King (Oracle)
2023-07-17  8:22     ` David Laight
2023-07-17  8:22       ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZK/O9Dc2aYtXEKHd@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=hanyu001@208suo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.