* [PATCH] ARM: mm: Fix warnings in context.c [not found] <tencent_B7B25B0AACAECB0523A2B09F270CF97BFF07@qq.com> @ 2023-07-12 9:06 ` shijie001 0 siblings, 0 replies; 4+ messages in thread From: shijie001 @ 2023-07-12 9:06 UTC (permalink / raw) To: linux; +Cc: linux-arm-kernel, linux-kernel The following checkpatch warning is removed: WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> Signed-off-by: Jie Shi <shijie001@208suo.com> --- arch/arm/mm/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c index 4204ffa2d104..c84ad6c786e7 100644 --- a/arch/arm/mm/context.c +++ b/arch/arm/mm/context.c @@ -13,7 +13,7 @@ #include <linux/smp.h> #include <linux/percpu.h> -#include <asm/mmu_context.h> +#include <linux/mmu_context.h> #include <asm/smp_plat.h> #include <asm/thread_notify.h> #include <asm/tlbflush.h> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: mm: Fix warnings in context.c @ 2023-07-12 9:06 ` shijie001 0 siblings, 0 replies; 4+ messages in thread From: shijie001 @ 2023-07-12 9:06 UTC (permalink / raw) To: linux; +Cc: linux-arm-kernel, linux-kernel The following checkpatch warning is removed: WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> Signed-off-by: Jie Shi <shijie001@208suo.com> --- arch/arm/mm/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c index 4204ffa2d104..c84ad6c786e7 100644 --- a/arch/arm/mm/context.c +++ b/arch/arm/mm/context.c @@ -13,7 +13,7 @@ #include <linux/smp.h> #include <linux/percpu.h> -#include <asm/mmu_context.h> +#include <linux/mmu_context.h> #include <asm/smp_plat.h> #include <asm/thread_notify.h> #include <asm/tlbflush.h> ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mm: Fix warnings in context.c 2023-07-12 9:06 ` shijie001 @ 2023-07-12 19:24 ` Russell King (Oracle) -1 siblings, 0 replies; 4+ messages in thread From: Russell King (Oracle) @ 2023-07-12 19:24 UTC (permalink / raw) To: shijie001; +Cc: linux-arm-kernel, linux-kernel On Wed, Jul 12, 2023 at 05:06:32PM +0800, shijie001@208suo.com wrote: > The following checkpatch warning is removed: > WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> > > Signed-off-by: Jie Shi <shijie001@208suo.com> > --- > arch/arm/mm/context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c > index 4204ffa2d104..c84ad6c786e7 100644 > --- a/arch/arm/mm/context.c > +++ b/arch/arm/mm/context.c > @@ -13,7 +13,7 @@ > #include <linux/smp.h> > #include <linux/percpu.h> > > -#include <asm/mmu_context.h> > +#include <linux/mmu_context.h> > #include <asm/smp_plat.h> > #include <asm/thread_notify.h> > #include <asm/tlbflush.h> > Probably haven't noticed, but linux/ includes are all grouped together, and asm/ includes are all grouped together. Please keep that. Also, is it really a necessary change, when arch/arm/mm/context.c is only implementing the interfaces provided by asm/mmu_context.h? I think the warning is wrong in this case and should never be fixed as things currently stand. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mm: Fix warnings in context.c @ 2023-07-12 19:24 ` Russell King (Oracle) 0 siblings, 0 replies; 4+ messages in thread From: Russell King (Oracle) @ 2023-07-12 19:24 UTC (permalink / raw) To: shijie001; +Cc: linux-arm-kernel, linux-kernel On Wed, Jul 12, 2023 at 05:06:32PM +0800, shijie001@208suo.com wrote: > The following checkpatch warning is removed: > WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> > > Signed-off-by: Jie Shi <shijie001@208suo.com> > --- > arch/arm/mm/context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c > index 4204ffa2d104..c84ad6c786e7 100644 > --- a/arch/arm/mm/context.c > +++ b/arch/arm/mm/context.c > @@ -13,7 +13,7 @@ > #include <linux/smp.h> > #include <linux/percpu.h> > > -#include <asm/mmu_context.h> > +#include <linux/mmu_context.h> > #include <asm/smp_plat.h> > #include <asm/thread_notify.h> > #include <asm/tlbflush.h> > Probably haven't noticed, but linux/ includes are all grouped together, and asm/ includes are all grouped together. Please keep that. Also, is it really a necessary change, when arch/arm/mm/context.c is only implementing the interfaces provided by asm/mmu_context.h? I think the warning is wrong in this case and should never be fixed as things currently stand. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-12 19:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_B7B25B0AACAECB0523A2B09F270CF97BFF07@qq.com>
2023-07-12 9:06 ` [PATCH] ARM: mm: Fix warnings in context.c shijie001
2023-07-12 9:06 ` shijie001
2023-07-12 19:24 ` Russell King (Oracle)
2023-07-12 19:24 ` Russell King (Oracle)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.