From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v4 6/6] iio: adc: meson: support reading from channel 7 mux inputs
Date: Mon, 10 Jul 2023 12:32:17 +0300 [thread overview]
Message-ID: <ZKvQIWCc3vMoA80N@smile.fi.intel.com> (raw)
In-Reply-To: <20230707153322.114302-7-gnstark@sberdevices.ru>
On Fri, Jul 07, 2023 at 06:27:43PM +0300, George Stark wrote:
> Add iio channel for every channel 7 mux input.
IIO
"...for each muxed input of the channel 7."
> Meson saradc channel 7 is connected to a mux that can switch channel
> input to well-known sources like Vdd, GND and several Vdd dividers.
Make this sentence to be the first in the commit message.
"can switch input" (again, avoid tautology).
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v4 6/6] iio: adc: meson: support reading from channel 7 mux inputs
Date: Mon, 10 Jul 2023 12:32:17 +0300 [thread overview]
Message-ID: <ZKvQIWCc3vMoA80N@smile.fi.intel.com> (raw)
In-Reply-To: <20230707153322.114302-7-gnstark@sberdevices.ru>
On Fri, Jul 07, 2023 at 06:27:43PM +0300, George Stark wrote:
> Add iio channel for every channel 7 mux input.
IIO
"...for each muxed input of the channel 7."
> Meson saradc channel 7 is connected to a mux that can switch channel
> input to well-known sources like Vdd, GND and several Vdd dividers.
Make this sentence to be the first in the commit message.
"can switch input" (again, avoid tautology).
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v4 6/6] iio: adc: meson: support reading from channel 7 mux inputs
Date: Mon, 10 Jul 2023 12:32:17 +0300 [thread overview]
Message-ID: <ZKvQIWCc3vMoA80N@smile.fi.intel.com> (raw)
In-Reply-To: <20230707153322.114302-7-gnstark@sberdevices.ru>
On Fri, Jul 07, 2023 at 06:27:43PM +0300, George Stark wrote:
> Add iio channel for every channel 7 mux input.
IIO
"...for each muxed input of the channel 7."
> Meson saradc channel 7 is connected to a mux that can switch channel
> input to well-known sources like Vdd, GND and several Vdd dividers.
Make this sentence to be the first in the commit message.
"can switch input" (again, avoid tautology).
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-10 9:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 15:27 [PATCH v4 0/6] iio: adc: meson: add iio channels to read channel 7 mux inputs George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` [PATCH v4 1/6] iio: adc: meson: remove unused timestamp channel George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` [PATCH v4 2/6] iio: adc: meson: move enums declaration before variables declaration George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-10 9:26 ` Andy Shevchenko
2023-07-10 9:26 ` Andy Shevchenko
2023-07-10 9:26 ` Andy Shevchenko
2023-07-07 15:27 ` [PATCH v4 3/6] iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-10 9:28 ` Andy Shevchenko
2023-07-10 9:28 ` Andy Shevchenko
2023-07-10 9:28 ` Andy Shevchenko
2023-07-07 15:27 ` [PATCH v4 4/6] iio: adc: meson: add enum for iio channel numbers George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` [PATCH v4 5/6] iio: adc: meson: add channel labels George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-10 9:29 ` Andy Shevchenko
2023-07-10 9:29 ` Andy Shevchenko
2023-07-10 9:29 ` Andy Shevchenko
2023-07-07 15:27 ` [PATCH v4 6/6] iio: adc: meson: support reading from channel 7 mux inputs George Stark
2023-07-07 15:27 ` George Stark
2023-07-07 15:27 ` George Stark
2023-07-10 9:32 ` Andy Shevchenko [this message]
2023-07-10 9:32 ` Andy Shevchenko
2023-07-10 9:32 ` Andy Shevchenko
2023-07-08 16:04 ` [PATCH v4 0/6] iio: adc: meson: add iio channels to read " Jonathan Cameron
2023-07-08 16:04 ` Jonathan Cameron
2023-07-08 16:04 ` Jonathan Cameron
2023-07-10 9:33 ` Andy Shevchenko
2023-07-10 9:33 ` Andy Shevchenko
2023-07-10 9:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKvQIWCc3vMoA80N@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.