* [Intel-wired-lan] [PATCH iwl-next v1] i40e: Clear stats after deleting tc
@ 2023-07-24 9:43 ` Jedrzej Jagielski
0 siblings, 0 replies; 6+ messages in thread
From: Jedrzej Jagielski @ 2023-07-24 9:43 UTC (permalink / raw)
To: intel-wired-lan
Cc: Grzegorz Szczurek, netdev, anthony.l.nguyen, Jedrzej Jagielski
From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
There was an issue with ethtool stats that
have not been cleared after tc had been deleted.
Fix this by resetting stats after deleting tc
by calling i40e_vsi_reset_stats() function after
distroying qdisc.
Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 29ad1797adce..6f604bfe7437 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
/* Update the netdev TC setup */
i40e_vsi_config_netdev_tc(vsi, enabled_tc);
+
+ /* After distroying qdisc reset all stats of the vsi */
+ if (!vsi->mqprio_qopt.qopt.hw)
+ i40e_vsi_reset_stats(vsi);
+
out:
return ret;
}
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH iwl-next v1] i40e: Clear stats after deleting tc
@ 2023-07-24 9:43 ` Jedrzej Jagielski
0 siblings, 0 replies; 6+ messages in thread
From: Jedrzej Jagielski @ 2023-07-24 9:43 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, anthony.l.nguyen, Grzegorz Szczurek, Jedrzej Jagielski
From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
There was an issue with ethtool stats that
have not been cleared after tc had been deleted.
Fix this by resetting stats after deleting tc
by calling i40e_vsi_reset_stats() function after
distroying qdisc.
Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 29ad1797adce..6f604bfe7437 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
/* Update the netdev TC setup */
i40e_vsi_config_netdev_tc(vsi, enabled_tc);
+
+ /* After distroying qdisc reset all stats of the vsi */
+ if (!vsi->mqprio_qopt.qopt.hw)
+ i40e_vsi_reset_stats(vsi);
+
out:
return ret;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Clear stats after deleting tc
2023-07-24 9:43 ` Jedrzej Jagielski
@ 2023-07-25 12:25 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-07-25 12:25 UTC (permalink / raw)
To: Jedrzej Jagielski
Cc: Grzegorz Szczurek, netdev, anthony.l.nguyen, intel-wired-lan
On Mon, Jul 24, 2023 at 11:43:19AM +0200, Jedrzej Jagielski wrote:
> From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>
> There was an issue with ethtool stats that
> have not been cleared after tc had been deleted.
I think it would be good to elaborate on what the issue is,
perhaps with an example. I think this should be added to
the patch description.
> Fix this by resetting stats after deleting tc
> by calling i40e_vsi_reset_stats() function after
> distroying qdisc.
>
> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 29ad1797adce..6f604bfe7437 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
>
> /* Update the netdev TC setup */
> i40e_vsi_config_netdev_tc(vsi, enabled_tc);
> +
> + /* After distroying qdisc reset all stats of the vsi */
nit: distroying -> destroying
> + if (!vsi->mqprio_qopt.qopt.hw)
> + i40e_vsi_reset_stats(vsi);
> +
> out:
> return ret;
> }
--
pw-bot: changes-requested
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH iwl-next v1] i40e: Clear stats after deleting tc
@ 2023-07-25 12:25 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-07-25 12:25 UTC (permalink / raw)
To: Jedrzej Jagielski
Cc: intel-wired-lan, netdev, anthony.l.nguyen, Grzegorz Szczurek
On Mon, Jul 24, 2023 at 11:43:19AM +0200, Jedrzej Jagielski wrote:
> From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>
> There was an issue with ethtool stats that
> have not been cleared after tc had been deleted.
I think it would be good to elaborate on what the issue is,
perhaps with an example. I think this should be added to
the patch description.
> Fix this by resetting stats after deleting tc
> by calling i40e_vsi_reset_stats() function after
> distroying qdisc.
>
> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 29ad1797adce..6f604bfe7437 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
>
> /* Update the netdev TC setup */
> i40e_vsi_config_netdev_tc(vsi, enabled_tc);
> +
> + /* After distroying qdisc reset all stats of the vsi */
nit: distroying -> destroying
> + if (!vsi->mqprio_qopt.qopt.hw)
> + i40e_vsi_reset_stats(vsi);
> +
> out:
> return ret;
> }
--
pw-bot: changes-requested
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Clear stats after deleting tc
2023-07-25 12:25 ` Simon Horman
@ 2023-07-26 9:23 ` Jagielski, Jedrzej
-1 siblings, 0 replies; 6+ messages in thread
From: Jagielski, Jedrzej @ 2023-07-26 9:23 UTC (permalink / raw)
To: Simon Horman
Cc: Grzegorz Szczurek, netdev@vger.kernel.org, Nguyen, Anthony L,
intel-wired-lan@lists.osuosl.org
From: Simon Horman <simon.horman@corigine.com>
Sent: Tue, 25 July 2023 14:25
>On Mon, Jul 24, 2023 at 11:43:19AM +0200, Jedrzej Jagielski wrote:
>> From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>>
>> There was an issue with ethtool stats that
>> have not been cleared after tc had been deleted.
>
>I think it would be good to elaborate on what the issue is,
>perhaps with an example. I think this should be added to
>the patch description.
OK, I will provide more details
>
>> Fix this by resetting stats after deleting tc
>> by calling i40e_vsi_reset_stats() function after
>> distroying qdisc.
>>
>> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
>> ---
>> drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 29ad1797adce..6f604bfe7437 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
>>
>> /* Update the netdev TC setup */
>> i40e_vsi_config_netdev_tc(vsi, enabled_tc);
>> +
>> + /* After distroying qdisc reset all stats of the vsi */
>
>nit: distroying -> destroying
Thanks for catching that
>
>> + if (!vsi->mqprio_qopt.qopt.hw)
>> + i40e_vsi_reset_stats(vsi);
>> +
>> out:
>> return ret;
>> }
>
>--
>pw-bot: changes-requested
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH iwl-next v1] i40e: Clear stats after deleting tc
@ 2023-07-26 9:23 ` Jagielski, Jedrzej
0 siblings, 0 replies; 6+ messages in thread
From: Jagielski, Jedrzej @ 2023-07-26 9:23 UTC (permalink / raw)
To: Simon Horman
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Nguyen, Anthony L, Grzegorz Szczurek
From: Simon Horman <simon.horman@corigine.com>
Sent: Tue, 25 July 2023 14:25
>On Mon, Jul 24, 2023 at 11:43:19AM +0200, Jedrzej Jagielski wrote:
>> From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>>
>> There was an issue with ethtool stats that
>> have not been cleared after tc had been deleted.
>
>I think it would be good to elaborate on what the issue is,
>perhaps with an example. I think this should be added to
>the patch description.
OK, I will provide more details
>
>> Fix this by resetting stats after deleting tc
>> by calling i40e_vsi_reset_stats() function after
>> distroying qdisc.
>>
>> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
>> ---
>> drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 29ad1797adce..6f604bfe7437 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
>>
>> /* Update the netdev TC setup */
>> i40e_vsi_config_netdev_tc(vsi, enabled_tc);
>> +
>> + /* After distroying qdisc reset all stats of the vsi */
>
>nit: distroying -> destroying
Thanks for catching that
>
>> + if (!vsi->mqprio_qopt.qopt.hw)
>> + i40e_vsi_reset_stats(vsi);
>> +
>> out:
>> return ret;
>> }
>
>--
>pw-bot: changes-requested
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-26 9:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-24 9:43 [Intel-wired-lan] [PATCH iwl-next v1] i40e: Clear stats after deleting tc Jedrzej Jagielski
2023-07-24 9:43 ` Jedrzej Jagielski
2023-07-25 12:25 ` [Intel-wired-lan] " Simon Horman
2023-07-25 12:25 ` Simon Horman
2023-07-26 9:23 ` [Intel-wired-lan] " Jagielski, Jedrzej
2023-07-26 9:23 ` Jagielski, Jedrzej
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.