From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
paul.walmsley@sifive.com, palmer@rivosinc.com,
aou@eecs.berkeley.edu, anup@brainfault.org,
konstantin@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org,
alexghiti@rivosinc.com
Subject: Re: [PATCH v5 0/4] RISC-V: mm: Make SV48 the default address space
Date: Fri, 14 Jul 2023 09:36:45 -0700 [thread overview]
Message-ID: <ZLF5nS12R37loA9I@ghost> (raw)
In-Reply-To: <20230714-hangnail-stinking-60f9725ac0d5@spud>
On Fri, Jul 14, 2023 at 12:17:00PM +0100, Conor Dooley wrote:
> On Thu, Jul 13, 2023 at 05:13:59PM -0700, Charlie Jenkins wrote:
> > Make sv48 the default address space for mmap as some applications
> > currently depend on this assumption. Users can now select a
> > desired address space using a non-zero hint address to mmap. Previously,
> > requesting the default address space from mmap by passing zero as the hint
> > address would result in using the largest address space possible. Some
> > applications depend on empty bits in the virtual address space, like Go and
> > Java, so this patch provides more flexibility for application developers.
>
> The patchwork automation failed to apply this, what is the base for the
> series?
I forgot to pull in the changes to the riscv selftests so the conflict
is in that Makefile. I will send out a v6 with the correct base.
>
> >
> > -Charlie
> >
> > ---
> > v5:
> > - Minor wording change in documentation
> > - Change some parenthesis in arch_get_mmap_ macros
> > - Added case for addr==0 in arch_get_mmap_ because without this, programs would
> > crash if RLIMIT_STACK was modified before executing the program. This was
> > tested using the libhugetlbfs tests.
> >
> > v4:
> > - Split testcases/document patch into test cases, in-code documentation, and
> > formal documentation patches
> > - Modified the mmap_base macro to be more legible and better represent memory
> > layout
> > - Fixed documentation to better reflect the implmentation
> > - Renamed DEFAULT_VA_BITS to MMAP_VA_BITS
> > - Added additional test case for rlimit changes
> > ---
> >
> > Charlie Jenkins (4):
> > RISC-V: mm: Restrict address space for sv39,sv48,sv57
> > RISC-V: mm: Add tests for RISC-V mm
> > RISC-V: mm: Update pgtable comment documentation
> > RISC-V: mm: Document mmap changes
> >
> > Documentation/riscv/vm-layout.rst | 22 +++
> > arch/riscv/include/asm/elf.h | 2 +-
> > arch/riscv/include/asm/pgtable.h | 20 ++-
> > arch/riscv/include/asm/processor.h | 46 +++++-
> > tools/testing/selftests/riscv/Makefile | 2 +-
> > tools/testing/selftests/riscv/mm/.gitignore | 1 +
> > tools/testing/selftests/riscv/mm/Makefile | 21 +++
> > .../selftests/riscv/mm/testcases/mmap.c | 133 ++++++++++++++++++
> > 8 files changed, 234 insertions(+), 13 deletions(-)
> > create mode 100644 tools/testing/selftests/riscv/mm/.gitignore
> > create mode 100644 tools/testing/selftests/riscv/mm/Makefile
> > create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap.c
> >
> > --
> > 2.41.0
> >
WARNING: multiple messages have this Message-ID (diff)
From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
paul.walmsley@sifive.com, palmer@rivosinc.com,
aou@eecs.berkeley.edu, anup@brainfault.org,
konstantin@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org,
alexghiti@rivosinc.com
Subject: Re: [PATCH v5 0/4] RISC-V: mm: Make SV48 the default address space
Date: Fri, 14 Jul 2023 09:36:45 -0700 [thread overview]
Message-ID: <ZLF5nS12R37loA9I@ghost> (raw)
In-Reply-To: <20230714-hangnail-stinking-60f9725ac0d5@spud>
On Fri, Jul 14, 2023 at 12:17:00PM +0100, Conor Dooley wrote:
> On Thu, Jul 13, 2023 at 05:13:59PM -0700, Charlie Jenkins wrote:
> > Make sv48 the default address space for mmap as some applications
> > currently depend on this assumption. Users can now select a
> > desired address space using a non-zero hint address to mmap. Previously,
> > requesting the default address space from mmap by passing zero as the hint
> > address would result in using the largest address space possible. Some
> > applications depend on empty bits in the virtual address space, like Go and
> > Java, so this patch provides more flexibility for application developers.
>
> The patchwork automation failed to apply this, what is the base for the
> series?
I forgot to pull in the changes to the riscv selftests so the conflict
is in that Makefile. I will send out a v6 with the correct base.
>
> >
> > -Charlie
> >
> > ---
> > v5:
> > - Minor wording change in documentation
> > - Change some parenthesis in arch_get_mmap_ macros
> > - Added case for addr==0 in arch_get_mmap_ because without this, programs would
> > crash if RLIMIT_STACK was modified before executing the program. This was
> > tested using the libhugetlbfs tests.
> >
> > v4:
> > - Split testcases/document patch into test cases, in-code documentation, and
> > formal documentation patches
> > - Modified the mmap_base macro to be more legible and better represent memory
> > layout
> > - Fixed documentation to better reflect the implmentation
> > - Renamed DEFAULT_VA_BITS to MMAP_VA_BITS
> > - Added additional test case for rlimit changes
> > ---
> >
> > Charlie Jenkins (4):
> > RISC-V: mm: Restrict address space for sv39,sv48,sv57
> > RISC-V: mm: Add tests for RISC-V mm
> > RISC-V: mm: Update pgtable comment documentation
> > RISC-V: mm: Document mmap changes
> >
> > Documentation/riscv/vm-layout.rst | 22 +++
> > arch/riscv/include/asm/elf.h | 2 +-
> > arch/riscv/include/asm/pgtable.h | 20 ++-
> > arch/riscv/include/asm/processor.h | 46 +++++-
> > tools/testing/selftests/riscv/Makefile | 2 +-
> > tools/testing/selftests/riscv/mm/.gitignore | 1 +
> > tools/testing/selftests/riscv/mm/Makefile | 21 +++
> > .../selftests/riscv/mm/testcases/mmap.c | 133 ++++++++++++++++++
> > 8 files changed, 234 insertions(+), 13 deletions(-)
> > create mode 100644 tools/testing/selftests/riscv/mm/.gitignore
> > create mode 100644 tools/testing/selftests/riscv/mm/Makefile
> > create mode 100644 tools/testing/selftests/riscv/mm/testcases/mmap.c
> >
> > --
> > 2.41.0
> >
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-14 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 0:13 [PATCH v5 0/4] RISC-V: mm: Make SV48 the default address space Charlie Jenkins
2023-07-14 0:13 ` Charlie Jenkins
2023-07-14 0:14 ` [PATCH v5 1/4] RISC-V: mm: Restrict address space for sv39,sv48,sv57 Charlie Jenkins
2023-07-14 0:14 ` Charlie Jenkins
2023-07-14 0:14 ` [PATCH v5 2/4] RISC-V: mm: Add tests for RISC-V mm Charlie Jenkins
2023-07-14 0:14 ` Charlie Jenkins
2023-07-14 0:14 ` [PATCH v5 3/4] RISC-V: mm: Update pgtable comment documentation Charlie Jenkins
2023-07-14 0:14 ` Charlie Jenkins
2023-07-14 0:14 ` [PATCH v5 4/4] RISC-V: mm: Document mmap changes Charlie Jenkins
2023-07-14 0:14 ` Charlie Jenkins
2023-07-14 11:17 ` [PATCH v5 0/4] RISC-V: mm: Make SV48 the default address space Conor Dooley
2023-07-14 11:17 ` Conor Dooley
2023-07-14 16:36 ` Charlie Jenkins [this message]
2023-07-14 16:36 ` Charlie Jenkins
2023-07-14 16:49 ` Conor Dooley
2023-07-14 16:49 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLF5nS12R37loA9I@ghost \
--to=charlie@rivosinc.com \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=jrtc27@jrtc27.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.