All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mostafa Saleh <smostafa@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
	maz@kernel.org, suzuki.poulose@arm.com, tabba@google.com,
	james.morse@arm.com, qperret@google.com, bgardon@google.com,
	sudeep.holla@arm.com, gshan@redhat.com, yuzenghui@huawei.com,
	will@kernel.org, catalin.marinas@arm.com
Subject: Re: [PATCH v2] KVM: arm64: Add missing BTI instructions
Date: Mon, 17 Jul 2023 09:48:18 +0000	[thread overview]
Message-ID: <ZLUOYn8bujcIrgaG@google.com> (raw)
In-Reply-To: <168920214959.3096128.780259299986215400.b4-ty@linux.dev>

On Wed, Jul 12, 2023 at 10:50:34PM +0000, Oliver Upton wrote:
> On Thu, 6 Jul 2023 15:22:40 +0000, Mostafa Saleh wrote:
> > Some bti instructions were missing from
> > commit b53d4a272349 ("KVM: arm64: Use BTI for nvhe")
> > 
> > 1) kvm_host_psci_cpu_entry
> > kvm_host_psci_cpu_entry is called from __kvm_hyp_init_cpu through "br"
> > instruction as __kvm_hyp_init_cpu resides in idmap section while
> > kvm_host_psci_cpu_entry is in hyp .text so the offset is larger than
> > 128MB range covered by "b".
> > Which means that this function should start with "bti j" instruction.
> > 
> > [...]
> 
> Applied to kvmarm/fixes. Sorry this took longer than expected, Mostafa. I
> was hitting an unrelated issue with pKVM initialization on the only system
> I have that supports BTI.
> 
> [1/1] KVM: arm64: Add missing BTI instructions
>       https://git.kernel.org/kvmarm/kvmarm/c/dcf89d111199
> 

Thanks Oliver, hopefully everything is sorted out now.

WARNING: multiple messages have this Message-ID (diff)
From: Mostafa Saleh <smostafa@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
	maz@kernel.org, suzuki.poulose@arm.com, tabba@google.com,
	james.morse@arm.com, qperret@google.com, bgardon@google.com,
	sudeep.holla@arm.com, gshan@redhat.com, yuzenghui@huawei.com,
	will@kernel.org, catalin.marinas@arm.com
Subject: Re: [PATCH v2] KVM: arm64: Add missing BTI instructions
Date: Mon, 17 Jul 2023 09:48:18 +0000	[thread overview]
Message-ID: <ZLUOYn8bujcIrgaG@google.com> (raw)
In-Reply-To: <168920214959.3096128.780259299986215400.b4-ty@linux.dev>

On Wed, Jul 12, 2023 at 10:50:34PM +0000, Oliver Upton wrote:
> On Thu, 6 Jul 2023 15:22:40 +0000, Mostafa Saleh wrote:
> > Some bti instructions were missing from
> > commit b53d4a272349 ("KVM: arm64: Use BTI for nvhe")
> > 
> > 1) kvm_host_psci_cpu_entry
> > kvm_host_psci_cpu_entry is called from __kvm_hyp_init_cpu through "br"
> > instruction as __kvm_hyp_init_cpu resides in idmap section while
> > kvm_host_psci_cpu_entry is in hyp .text so the offset is larger than
> > 128MB range covered by "b".
> > Which means that this function should start with "bti j" instruction.
> > 
> > [...]
> 
> Applied to kvmarm/fixes. Sorry this took longer than expected, Mostafa. I
> was hitting an unrelated issue with pKVM initialization on the only system
> I have that supports BTI.
> 
> [1/1] KVM: arm64: Add missing BTI instructions
>       https://git.kernel.org/kvmarm/kvmarm/c/dcf89d111199
> 

Thanks Oliver, hopefully everything is sorted out now.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-17  9:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 15:22 [PATCH v2] KVM: arm64: Add missing BTI instructions Mostafa Saleh
2023-07-06 15:22 ` Mostafa Saleh
2023-07-06 16:23 ` Sudeep Holla
2023-07-06 16:23   ` Sudeep Holla
2023-07-07 10:59   ` Mostafa Saleh
2023-07-07 10:59     ` Mostafa Saleh
2023-07-12 10:49 ` Marc Zyngier
2023-07-12 10:49   ` Marc Zyngier
2023-07-12 22:50 ` Oliver Upton
2023-07-12 22:50   ` Oliver Upton
2023-07-17  9:48   ` Mostafa Saleh [this message]
2023-07-17  9:48     ` Mostafa Saleh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLUOYn8bujcIrgaG@google.com \
    --to=smostafa@google.com \
    --cc=bgardon@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=gshan@redhat.com \
    --cc=james.morse@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=qperret@google.com \
    --cc=sudeep.holla@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.