From: Cristian Marussi <cristian.marussi@arm.com>
To: Sukrut Bellary <sukrut.bellary@linux.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling
Date: Tue, 18 Jul 2023 10:46:28 +0100 [thread overview]
Message-ID: <ZLZfdCBEF9YWtGWa@pluto> (raw)
In-Reply-To: <20230718085529.258899-1-sukrut.bellary@linux.com>
On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
>
> Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com>
> ---
> This is based on static analysis. Compilation tested.
> ---
Hi Sukrut,
thanks for this.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sukrut Bellary <sukrut.bellary@linux.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling
Date: Tue, 18 Jul 2023 10:46:28 +0100 [thread overview]
Message-ID: <ZLZfdCBEF9YWtGWa@pluto> (raw)
In-Reply-To: <20230718085529.258899-1-sukrut.bellary@linux.com>
On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
>
> Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com>
> ---
> This is based on static analysis. Compilation tested.
> ---
Hi Sukrut,
thanks for this.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2023-07-19 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:55 [PATCH] firmware: arm_scmi: Fix signed error return values handling Sukrut Bellary
2023-07-18 8:55 ` Sukrut Bellary
2023-07-18 9:05 ` Dan Carpenter
2023-07-18 9:05 ` Dan Carpenter
2023-07-18 9:46 ` Cristian Marussi [this message]
2023-07-18 9:46 ` Cristian Marussi
2023-07-19 10:00 ` Sudeep Holla
2023-07-19 10:00 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLZfdCBEF9YWtGWa@pluto \
--to=cristian.marussi@arm.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=sukrut.bellary@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.