All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Dongwon Kim <dongwon.kim@intel.com>,
	David Hildenbrand <david@redhat.com>,
	Junxiao Chang <junxiao.chang@intel.com>,
	Hugh Dickins <hughd@google.com>, Peter Xu <peterx@redhat.com>,
	linux-mm@kvack.org, dri-devel@lists.freedesktop.org,
	Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)
Date: Tue, 18 Jul 2023 12:36:30 -0300	[thread overview]
Message-ID: <ZLaxfmrVo7sygM3d@nvidia.com> (raw)
In-Reply-To: <20230718082858.1570809-2-vivek.kasireddy@intel.com>

On Tue, Jul 18, 2023 at 01:28:56AM -0700, Vivek Kasireddy wrote:
> Currently, there does not appear to be any mechanism for letting
> drivers or other kernel entities know about updates made in a
> mapping particularly when a new page is faulted in. Providing
> notifications for such situations is really useful when using
> memfds backed by ram-based filesystems such as shmem or hugetlbfs
> that also allow FALLOC_FL_PUNCH_HOLE.

Huh? You get an invalidate when this happens and the address becomes
non-present.

> More specifically, when a hole is punched in a memfd (that is
> backed by shmem or hugetlbfs), a driver can register for
> notifications associated with range invalidations. However, it
> would also be useful to have notifications when new pages are
> faulted in as a result of writes made to the mapping region that
> overlaps with a previously punched hole.

If there is no change to the PTEs then it is hard to see why this
would be part of a mmu_notifier.

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	David Hildenbrand <david@redhat.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Hugh Dickins <hughd@google.com>, Peter Xu <peterx@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Dongwon Kim <dongwon.kim@intel.com>,
	Junxiao Chang <junxiao.chang@intel.com>
Subject: Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)
Date: Tue, 18 Jul 2023 12:36:30 -0300	[thread overview]
Message-ID: <ZLaxfmrVo7sygM3d@nvidia.com> (raw)
In-Reply-To: <20230718082858.1570809-2-vivek.kasireddy@intel.com>

On Tue, Jul 18, 2023 at 01:28:56AM -0700, Vivek Kasireddy wrote:
> Currently, there does not appear to be any mechanism for letting
> drivers or other kernel entities know about updates made in a
> mapping particularly when a new page is faulted in. Providing
> notifications for such situations is really useful when using
> memfds backed by ram-based filesystems such as shmem or hugetlbfs
> that also allow FALLOC_FL_PUNCH_HOLE.

Huh? You get an invalidate when this happens and the address becomes
non-present.

> More specifically, when a hole is punched in a memfd (that is
> backed by shmem or hugetlbfs), a driver can register for
> notifications associated with range invalidations. However, it
> would also be useful to have notifications when new pages are
> faulted in as a result of writes made to the mapping region that
> overlaps with a previously punched hole.

If there is no change to the PTEs then it is hard to see why this
would be part of a mmu_notifier.

Jason


  reply	other threads:[~2023-07-18 15:36 UTC|newest]

Thread overview: 128+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18  8:28 [RFC v1 0/3] udmabuf: Replace pages when there is FALLOC_FL_PUNCH_HOLE in memfd Vivek Kasireddy
2023-07-18  8:28 ` Vivek Kasireddy
2023-07-18  8:28 ` [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages) Vivek Kasireddy
2023-07-18  8:28   ` Vivek Kasireddy
2023-07-18 15:36   ` Jason Gunthorpe [this message]
2023-07-18 15:36     ` Jason Gunthorpe
2023-07-19  0:05     ` Kasireddy, Vivek
2023-07-19  0:05       ` Kasireddy, Vivek
2023-07-19  0:24       ` Jason Gunthorpe
2023-07-19  0:24         ` Jason Gunthorpe
2023-07-19  6:19         ` Kasireddy, Vivek
2023-07-19  6:19           ` Kasireddy, Vivek
2023-07-19  2:08   ` Alistair Popple
2023-07-19  2:08     ` Alistair Popple
2023-07-20  7:43     ` Kasireddy, Vivek
2023-07-20  7:43       ` Kasireddy, Vivek
2023-07-20  9:00       ` Alistair Popple
2023-07-20  9:00         ` Alistair Popple
2023-07-24  7:54         ` Kasireddy, Vivek
2023-07-24  7:54           ` Kasireddy, Vivek
2023-07-24 13:35           ` Jason Gunthorpe
2023-07-24 13:35             ` Jason Gunthorpe
2023-07-24 20:32             ` Kasireddy, Vivek
2023-07-24 20:32               ` Kasireddy, Vivek
2023-07-25  4:30               ` Hugh Dickins
2023-07-25  4:30                 ` Hugh Dickins
2023-07-25 22:24                 ` Kasireddy, Vivek
2023-07-25 22:24                   ` Kasireddy, Vivek
2023-07-27 21:43                   ` Peter Xu
2023-07-27 21:43                     ` Peter Xu
2023-07-29  0:08                     ` Kasireddy, Vivek
2023-07-29  0:08                       ` Kasireddy, Vivek
2023-07-31 17:05                       ` Peter Xu
2023-07-31 17:05                         ` Peter Xu
2023-08-01  7:11                         ` Kasireddy, Vivek
2023-08-01  7:11                           ` Kasireddy, Vivek
2023-08-01 21:57                           ` Peter Xu
2023-08-01 21:57                             ` Peter Xu
2023-08-03  8:08                             ` Kasireddy, Vivek
2023-08-03  8:08                               ` Kasireddy, Vivek
2023-08-03 13:02                               ` Peter Xu
2023-08-03 13:02                                 ` Peter Xu
2023-07-25 12:36               ` Jason Gunthorpe
2023-07-25 12:36                 ` Jason Gunthorpe
2023-07-25 22:44                 ` Kasireddy, Vivek
2023-07-25 22:44                   ` Kasireddy, Vivek
2023-07-25 22:53                   ` Jason Gunthorpe
2023-07-25 22:53                     ` Jason Gunthorpe
2023-07-27  7:34                     ` Kasireddy, Vivek
2023-07-27  7:34                       ` Kasireddy, Vivek
2023-07-27 11:58                       ` Jason Gunthorpe
2023-07-27 11:58                         ` Jason Gunthorpe
2023-07-29  0:46                         ` Kasireddy, Vivek
2023-07-29  0:46                           ` Kasireddy, Vivek
2023-07-30 23:09                           ` Jason Gunthorpe
2023-07-30 23:09                             ` Jason Gunthorpe
2023-08-01  5:32                             ` Kasireddy, Vivek
2023-08-01  5:32                               ` Kasireddy, Vivek
2023-08-01 12:19                               ` Jason Gunthorpe
2023-08-01 12:19                                 ` Jason Gunthorpe
2023-08-01 12:22                                 ` David Hildenbrand
2023-08-01 12:22                                   ` David Hildenbrand
2023-08-01 12:23                                   ` Jason Gunthorpe
2023-08-01 12:23                                     ` Jason Gunthorpe
2023-08-01 12:26                                     ` David Hildenbrand
2023-08-01 12:26                                       ` David Hildenbrand
2023-08-01 12:26                                       ` Jason Gunthorpe
2023-08-01 12:26                                         ` Jason Gunthorpe
2023-08-01 12:28                                         ` David Hildenbrand
2023-08-01 12:28                                           ` David Hildenbrand
2023-08-01 17:53                                           ` Kasireddy, Vivek
2023-08-01 17:53                                             ` Kasireddy, Vivek
2023-08-01 18:19                                             ` Jason Gunthorpe
2023-08-01 18:19                                               ` Jason Gunthorpe
2023-08-03  7:35                                               ` Kasireddy, Vivek
2023-08-03  7:35                                                 ` Kasireddy, Vivek
2023-08-03 12:14                                                 ` Jason Gunthorpe
2023-08-03 12:14                                                   ` Jason Gunthorpe
2023-08-03 12:32                                                   ` David Hildenbrand
2023-08-03 12:32                                                     ` David Hildenbrand
2023-08-04  0:14                                                     ` Alistair Popple
2023-08-04  0:14                                                       ` Alistair Popple
2023-08-04  6:39                                                       ` Kasireddy, Vivek
2023-08-04  6:39                                                         ` Kasireddy, Vivek
2023-08-04  7:23                                                         ` David Hildenbrand
2023-08-04  7:23                                                           ` David Hildenbrand
2023-08-04 21:53                                                           ` Kasireddy, Vivek
2023-08-04 21:53                                                             ` Kasireddy, Vivek
2023-08-04 12:49                                                         ` Jason Gunthorpe
2023-08-04 12:49                                                           ` Jason Gunthorpe
2023-08-08  7:37                                                           ` Kasireddy, Vivek
2023-08-08  7:37                                                             ` Kasireddy, Vivek
2023-08-08 12:42                                                             ` Jason Gunthorpe
2023-08-08 12:42                                                               ` Jason Gunthorpe
2023-08-16  6:43                                                               ` Kasireddy, Vivek
2023-08-16  6:43                                                                 ` Kasireddy, Vivek
2023-08-21  9:02                                                                 ` Alistair Popple
2023-08-21  9:02                                                                   ` Alistair Popple
2023-08-22  6:14                                                                   ` Kasireddy, Vivek
2023-08-22  6:14                                                                     ` Kasireddy, Vivek
2023-08-22  8:15                                                                     ` Alistair Popple
2023-08-22  8:15                                                                       ` Alistair Popple
2023-08-24  6:48                                                                       ` Kasireddy, Vivek
2023-08-24  6:48                                                                         ` Kasireddy, Vivek
2023-08-28  4:38                                                                         ` Kasireddy, Vivek
2023-08-28  4:38                                                                           ` Kasireddy, Vivek
2023-08-30 16:02                                                                           ` Jason Gunthorpe
2023-08-30 16:02                                                                             ` Jason Gunthorpe
2023-07-25  3:38             ` Alistair Popple
2023-07-25  3:38               ` Alistair Popple
2023-07-24 13:36           ` Alistair Popple
2023-07-24 13:36             ` Alistair Popple
2023-07-24 13:37             ` Jason Gunthorpe
2023-07-24 13:37               ` Jason Gunthorpe
2023-07-24 20:42             ` Kasireddy, Vivek
2023-07-24 20:42               ` Kasireddy, Vivek
2023-07-25  3:14               ` Alistair Popple
2023-07-25  3:14                 ` Alistair Popple
2023-07-18  8:28 ` [RFC v1 2/3] udmabuf: Replace pages when there is FALLOC_FL_PUNCH_HOLE in memfd Vivek Kasireddy
2023-07-18  8:28   ` Vivek Kasireddy
2023-08-02 12:40   ` Daniel Vetter
2023-08-02 12:40     ` Daniel Vetter
2023-08-03  8:24     ` Kasireddy, Vivek
2023-08-03  8:24       ` Kasireddy, Vivek
2023-08-03  8:32       ` Daniel Vetter
2023-08-03  8:32         ` Daniel Vetter
2023-07-18  8:28 ` [RFC v1 3/3] selftests/dma-buf/udmabuf: Add tests for huge pages and FALLOC_FL_PUNCH_HOLE Vivek Kasireddy
2023-07-18  8:28   ` Vivek Kasireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLaxfmrVo7sygM3d@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=david@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hughd@google.com \
    --cc=junxiao.chang@intel.com \
    --cc=kraxel@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=peterx@redhat.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.