From: Sasha Levin <sashal@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Junhao He <hejunhao3@huawei.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Will Deacon <will@kernel.org>,
zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver
Date: Fri, 21 Jul 2023 11:13:57 -0400 [thread overview]
Message-ID: <ZLqgtRcgGqmHUXFM@sashalap> (raw)
In-Reply-To: <ZKKfjW6Ix9dg11QZ@FVFF77S0Q05N>
On Mon, Jul 03, 2023 at 11:14:37AM +0100, Mark Rutland wrote:
>On Sun, Jul 02, 2023 at 03:50:56PM -0400, Sasha Levin wrote:
>> From: Junhao He <hejunhao3@huawei.com>
>>
>> [ Upstream commit 1a51688474c0d395b864e98236335fba712e29bf ]
>>
>> Compared to the original PA device, H60PA offers higher bandwidth.
>> The H60PA is a new device and we use HID to differentiate them.
>>
>> The events supported by PAv3 and PAv2 are different. The PAv3 PMU
>> removed some events which are supported by PAv2 PMU. The older PA
>> PMU driver will probe v3 as v2. Therefore PA events displayed by
>> "perf list" cannot work properly. We add the HISI0275 HID for PAv3
>> PMU to distinguish different.
>>
>> For each H60PA PMU, except for the overflow interrupt register, other
>> functions of the H60PA PMU are the same as the original PA PMU module.
>> It has 8-programable counters and each counter is free-running.
>> Interrupt is supported to handle counter (64-bits) overflow.
>>
>> Signed-off-by: Junhao He <hejunhao3@huawei.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
>> Acked-by: Mark Rutland <mark.rutland@arm.com>
>> Link: https://lore.kernel.org/r/20230615125926.29832-2-hejunhao3@huawei.com
>> Signed-off-by: Will Deacon <will@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 127 +++++++++++++++++---
>> drivers/perf/hisilicon/hisi_uncore_pmu.h | 8 ++
>> 2 files changed, 120 insertions(+), 15 deletions(-)
>
>Why is this being backported to stable?
>
>This patch adds supoprt for new HW, and is clearly not a fix, so it's not clear
>to me why it has been selected.
I'll drop it, thanks.
--
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Junhao He <hejunhao3@huawei.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Will Deacon <will@kernel.org>,
zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver
Date: Fri, 21 Jul 2023 11:13:57 -0400 [thread overview]
Message-ID: <ZLqgtRcgGqmHUXFM@sashalap> (raw)
In-Reply-To: <ZKKfjW6Ix9dg11QZ@FVFF77S0Q05N>
On Mon, Jul 03, 2023 at 11:14:37AM +0100, Mark Rutland wrote:
>On Sun, Jul 02, 2023 at 03:50:56PM -0400, Sasha Levin wrote:
>> From: Junhao He <hejunhao3@huawei.com>
>>
>> [ Upstream commit 1a51688474c0d395b864e98236335fba712e29bf ]
>>
>> Compared to the original PA device, H60PA offers higher bandwidth.
>> The H60PA is a new device and we use HID to differentiate them.
>>
>> The events supported by PAv3 and PAv2 are different. The PAv3 PMU
>> removed some events which are supported by PAv2 PMU. The older PA
>> PMU driver will probe v3 as v2. Therefore PA events displayed by
>> "perf list" cannot work properly. We add the HISI0275 HID for PAv3
>> PMU to distinguish different.
>>
>> For each H60PA PMU, except for the overflow interrupt register, other
>> functions of the H60PA PMU are the same as the original PA PMU module.
>> It has 8-programable counters and each counter is free-running.
>> Interrupt is supported to handle counter (64-bits) overflow.
>>
>> Signed-off-by: Junhao He <hejunhao3@huawei.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
>> Acked-by: Mark Rutland <mark.rutland@arm.com>
>> Link: https://lore.kernel.org/r/20230615125926.29832-2-hejunhao3@huawei.com
>> Signed-off-by: Will Deacon <will@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 127 +++++++++++++++++---
>> drivers/perf/hisilicon/hisi_uncore_pmu.h | 8 ++
>> 2 files changed, 120 insertions(+), 15 deletions(-)
>
>Why is this being backported to stable?
>
>This patch adds supoprt for new HW, and is clearly not a fix, so it's not clear
>to me why it has been selected.
I'll drop it, thanks.
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-21 15:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 19:50 [PATCH AUTOSEL 6.4 01/12] platform/chrome: cros_ec: Report EC panic as uevent Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 02/12] ACPI: x86: Add skip i2c clients quirk for Nextbook Ares 8A Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 03/12] ACPI: button: Add lid disable DMI " Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 04/12] ACPI: x86: Add ACPI_QUIRK_UART1_SKIP for Lenovo Yoga Book yb1-x90f/l Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 05/12] ACPI: video: Add backlight=native DMI quirk for Apple iMac11,3 Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 06/12] ACPI: video: Add backlight=native DMI quirk for Lenovo ThinkPad X131e (3371 AMD version) Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 07/12] arm64: cpufeature: detect FEAT_HCX Sasha Levin
2023-07-02 19:50 ` Sasha Levin
2023-07-03 11:51 ` Mark Brown
2023-07-03 11:51 ` Mark Brown
2023-07-09 14:56 ` Sasha Levin
2023-07-09 14:56 ` Sasha Levin
2023-07-09 21:13 ` Mark Brown
2023-07-09 21:13 ` Mark Brown
2023-07-10 9:44 ` Will Deacon
2023-07-10 9:44 ` Will Deacon
2023-07-10 13:31 ` Greg KH
2023-07-10 13:31 ` Greg KH
2023-07-10 13:47 ` Mark Brown
2023-07-10 13:47 ` Mark Brown
2023-07-10 14:09 ` Greg KH
2023-07-10 14:09 ` Greg KH
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 08/12] ACPI: resource: Remove "Zen" specific match and quirks Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 09/12] arm64: set __exception_irq_entry with __irq_entry as a default Sasha Levin
2023-07-02 19:50 ` Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 10/12] arm64: mm: fix VA-range sanity check Sasha Levin
2023-07-02 19:50 ` Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver Sasha Levin
2023-07-02 19:50 ` Sasha Levin
2023-07-03 10:14 ` Mark Rutland
2023-07-03 10:14 ` Mark Rutland
2023-07-21 15:13 ` Sasha Levin [this message]
2023-07-21 15:13 ` Sasha Levin
2023-07-02 19:50 ` [PATCH AUTOSEL 6.4 12/12] ACPI: video: Add backlight=native DMI quirk for Dell Studio 1569 Sasha Levin
2023-07-10 22:46 ` [PATCH AUTOSEL 6.4 01/12] platform/chrome: cros_ec: Report EC panic as uevent Brian Norris
2023-07-21 15:11 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLqgtRcgGqmHUXFM@sashalap \
--to=sashal@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.