From: Simon Horman <simon.horman@corigine.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, Jose.Abreu@synopsys.com,
mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next 6/7] net: txgbe: support copper NIC with external PHY
Date: Wed, 26 Jul 2023 14:15:32 +0200 [thread overview]
Message-ID: <ZMEOZP++xAnpKjEz@corigine.com> (raw)
In-Reply-To: <20230724102341.10401-7-jiawenwu@trustnetic.com>
On Mon, Jul 24, 2023 at 06:23:40PM +0800, Jiawen Wu wrote:
...
Hi Jiawen Wu,
a minor nit from my side.
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
...
> +
> + /* remove unsupport link mode */
nit: unsupport -> unsupported
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_10baseT_Half_BIT);
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_10baseT_Full_BIT);
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT);
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_2500baseT_Full_BIT);
> + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_5000baseT_Full_BIT);
...
next prev parent reply other threads:[~2023-07-26 12:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 10:23 [PATCH net-next 0/7] support more link mode for TXGBE Jiawen Wu
2023-07-24 10:23 ` [PATCH net-next 1/7] net: pcs: xpcs: add specific vendor supoprt for Wangxun 10Gb NICs Jiawen Wu
2023-07-25 17:24 ` Andrew Lunn
2023-07-24 10:23 ` [PATCH net-next 2/7] net: pcs: xpcs: support to switch mode for Wangxun NICs Jiawen Wu
2023-07-25 17:32 ` Andrew Lunn
2023-07-26 2:40 ` Jiawen Wu
2023-07-24 10:23 ` [PATCH net-next 3/7] net: pcs: xpcs: add 1000BASE-X AN interrupt support Jiawen Wu
2023-07-24 10:23 ` [PATCH net-next 4/7] net: pcs: xpcs: adapt Wangxun NICs for SGMII mode Jiawen Wu
2023-07-24 10:34 ` Russell King (Oracle)
2023-07-25 2:05 ` Jiawen Wu
2023-07-25 7:48 ` Russell King (Oracle)
2023-07-25 9:50 ` Jiawen Wu
2023-07-25 9:58 ` Russell King (Oracle)
2023-07-25 10:08 ` Russell King (Oracle)
2023-07-25 10:45 ` Jiawen Wu
2023-07-28 10:11 ` Jiawen Wu
2023-07-28 10:24 ` Andrew Lunn
2023-07-31 1:47 ` Jiawen Wu
2023-07-28 10:33 ` Russell King (Oracle)
2023-07-31 1:58 ` Jiawen Wu
2023-08-03 2:20 ` Jiawen Wu
2023-08-03 11:10 ` Russell King (Oracle)
2023-08-04 5:56 ` Jiawen Wu
2023-07-25 17:37 ` Andrew Lunn
2023-07-26 12:14 ` Simon Horman
2023-07-24 10:23 ` [PATCH net-next 5/7] net: txgbe: support switching mode to 1000BASE-X and SGMII Jiawen Wu
2023-07-24 10:40 ` Russell King (Oracle)
2023-07-25 2:29 ` Jiawen Wu
2023-07-24 10:23 ` [PATCH net-next 6/7] net: txgbe: support copper NIC with external PHY Jiawen Wu
2023-07-24 10:43 ` Russell King (Oracle)
2023-07-25 2:41 ` Jiawen Wu
2023-07-25 8:02 ` Russell King (Oracle)
2023-07-25 10:04 ` Jiawen Wu
2023-07-25 10:38 ` Russell King (Oracle)
2023-07-26 12:15 ` Simon Horman [this message]
2023-07-24 10:23 ` [PATCH net-next 7/7] net: ngbe: move mdio access registers to libwx Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMEOZP++xAnpKjEz@corigine.com \
--to=simon.horman@corigine.com \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=jiawenwu@trustnetic.com \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.