All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Cc: intel-wired-lan@osuosl.org, edumazet@google.com,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting implementation
Date: Tue, 1 Aug 2023 11:57:01 +0200	[thread overview]
Message-ID: <ZMjW7XeEqpoHhQFd@kernel.org> (raw)
In-Reply-To: <20230801011518.25370-1-muhammad.husaini.zulkifli@intel.com>

On Tue, Aug 01, 2023 at 09:15:16AM +0800, Muhammad Husaini Zulkifli wrote:
> The current tx-usecs coalesce setting implementation in the driver code is
> improved by this patch series. The implementation of the current driver
> code may have previously been a copy of the legacy code i210.
> 
> Patch 1:
> Allow the user to see the tx-usecs colease setting's current value when
> using the ethtool command. The previous value was 0.
> 
> Patch 2:
> Give the user the ability to modify the tx-usecs colease setting's value.
> Previously, it was restricted to rx-usecs.
> 
> V2 -> V3:
> - Refactor the code, as Simon suggested, to make it more readable.
> 
> V1 -> V2:
> - Split the patch file into two, like Anthony suggested.

Thanks for the refactoring.

Reviewed-by: Simon Horman <horms@kernel.org>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Cc: intel-wired-lan@osuosl.org, davem@davemloft.net, kuba@kernel.org,
	pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org,
	naamax.meir@linux.intel.com, anthony.l.nguyen@intel.com
Subject: Re: [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting implementation
Date: Tue, 1 Aug 2023 11:57:01 +0200	[thread overview]
Message-ID: <ZMjW7XeEqpoHhQFd@kernel.org> (raw)
In-Reply-To: <20230801011518.25370-1-muhammad.husaini.zulkifli@intel.com>

On Tue, Aug 01, 2023 at 09:15:16AM +0800, Muhammad Husaini Zulkifli wrote:
> The current tx-usecs coalesce setting implementation in the driver code is
> improved by this patch series. The implementation of the current driver
> code may have previously been a copy of the legacy code i210.
> 
> Patch 1:
> Allow the user to see the tx-usecs colease setting's current value when
> using the ethtool command. The previous value was 0.
> 
> Patch 2:
> Give the user the ability to modify the tx-usecs colease setting's value.
> Previously, it was restricted to rx-usecs.
> 
> V2 -> V3:
> - Refactor the code, as Simon suggested, to make it more readable.
> 
> V1 -> V2:
> - Split the patch file into two, like Anthony suggested.

Thanks for the refactoring.

Reviewed-by: Simon Horman <horms@kernel.org>


  parent reply	other threads:[~2023-08-01  9:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  1:15 [Intel-wired-lan] [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting implementation Muhammad Husaini Zulkifli
2023-08-01  1:15 ` Muhammad Husaini Zulkifli
2023-08-01  1:15 ` [Intel-wired-lan] [PATCH iwl-net v3 1/2] igc: Expose tx-usecs coalesce setting to user Muhammad Husaini Zulkifli
2023-08-01  1:15   ` Muhammad Husaini Zulkifli
2023-08-01  1:15 ` [Intel-wired-lan] [PATCH iwl-net v3 2/2] igc: Modify the tx-usecs coalesce setting Muhammad Husaini Zulkifli
2023-08-01  1:15   ` Muhammad Husaini Zulkifli
2023-08-01  9:57 ` Simon Horman [this message]
2023-08-01  9:57   ` [PATCH iwl-net v3 0/2] Enhance the tx-usecs coalesce setting implementation Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMjW7XeEqpoHhQFd@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@osuosl.org \
    --cc=kuba@kernel.org \
    --cc=muhammad.husaini.zulkifli@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.