All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Ran Sun <sunran001@208suo.com>,
	alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h
Date: Tue, 1 Aug 2023 18:16:50 +0700	[thread overview]
Message-ID: <ZMjposYeMFxU5nE9@debian.me> (raw)
In-Reply-To: <20230801100024.8215-1-sunran001@208suo.com>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Tue, Aug 01, 2023 at 10:00:24AM +0000, Ran Sun wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: open brace '{' following struct go on the same line
> ERROR: trailing whitespace
> ERROR: space prohibited before open square bracket '['
> 

Thanks for fixing up your tooling to use git-send-email(1). However, it'd
been great to send a patch series touching whole drm/amd subsystem, with each
patch fixes one error (assuming the subsystem permits checkpatch fixup
like this) instead of spamming maintainers with >= 70 single patches like
this.

And it is unfortunate that you and @208suo.com people doesn't reply to
review comments (try searching lore.kernel.org), which makes me wonder:
what does prevent you from replying to the mailing lists like LKML? Your
mail infrastructure?

Thanks anyway.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Ran Sun <sunran001@208suo.com>,
	alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h
Date: Tue, 1 Aug 2023 18:16:50 +0700	[thread overview]
Message-ID: <ZMjposYeMFxU5nE9@debian.me> (raw)
In-Reply-To: <20230801100024.8215-1-sunran001@208suo.com>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Tue, Aug 01, 2023 at 10:00:24AM +0000, Ran Sun wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: open brace '{' following struct go on the same line
> ERROR: trailing whitespace
> ERROR: space prohibited before open square bracket '['
> 

Thanks for fixing up your tooling to use git-send-email(1). However, it'd
been great to send a patch series touching whole drm/amd subsystem, with each
patch fixes one error (assuming the subsystem permits checkpatch fixup
like this) instead of spamming maintainers with >= 70 single patches like
this.

And it is unfortunate that you and @208suo.com people doesn't reply to
review comments (try searching lore.kernel.org), which makes me wonder:
what does prevent you from replying to the mailing lists like LKML? Your
mail infrastructure?

Thanks anyway.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-08-02  7:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 10:00 [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h Ran Sun
2023-08-01 10:00 ` Ran Sun
2023-08-01 11:16 ` Bagas Sanjaya [this message]
2023-08-01 11:16   ` Bagas Sanjaya
2023-08-01 11:34   ` Jani Nikula
2023-08-01 11:34     ` Jani Nikula
2023-08-02  1:06     ` Bagas Sanjaya
2023-08-02  1:06       ` Bagas Sanjaya
2023-08-02 10:09       ` Jani Nikula
2023-08-02 10:09         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMjposYeMFxU5nE9@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunran001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.