* [PATCH 0/4][next] i40e: Replace one-element arrays with flexible-array members
@ 2023-08-02 5:04 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:04 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
fam1-i40e/0001-i40e-Replace-one-element-array-with-flex-array-membe.patch,
fam1-i40e/0002-i40e-Replace-one-element-array-with-flex-array-membe.patch,
fam1-i40e/0003-i40e-Replace-one-element-array-with-flex-array-membe.patch,
fam1-i40e/0004-i40e-Replace-one-element-array-with-flex-array-membe.patch
Cc: netdev, intel-wired-lan, linux-kernel, Gustavo A. R. Silva,
linux-hardening
Replace one-element arrays with flexible-array members in multiple
structures.
This results in no differences in binary output.
Gustavo A. R. Silva (4):
i40e: Replace one-element array with flex-array member in struct
i40e_package_header
i40e: Replace one-element array with flex-array member in struct
i40e_profile_segment
i40e: Replace one-element array with flex-array member in struct
i40e_section_table
i40e: Replace one-element array with flex-array member in struct
i40e_profile_aq_section
drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_type.h | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 32+ messages in thread* [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
2023-08-02 5:04 ` Gustavo A. R. Silva
@ 2023-08-02 5:05 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:05 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-hardening, netdev, intel-wired-lan, linux-kernel,
Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.
The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
index 7e8183762fd9..0db6f5e3cfcc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
@@ -220,7 +220,7 @@ static bool i40e_ddp_is_pkg_hdr_valid(struct net_device *netdev,
netdev_err(netdev, "Invalid DDP profile - size is bigger than 4G");
return false;
}
- if (size < (sizeof(struct i40e_package_header) +
+ if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
netdev_err(netdev, "Invalid DDP profile - size is too small.");
return false;
@@ -281,7 +281,7 @@ int i40e_ddp_load(struct net_device *netdev, const u8 *data, size_t size,
if (!i40e_ddp_is_pkg_hdr_valid(netdev, pkg_hdr, size))
return -EINVAL;
- if (size < (sizeof(struct i40e_package_header) +
+ if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
netdev_err(netdev, "Invalid DDP recipe size.");
return -EINVAL;
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index 388c3d36d96a..c3d5fe12059a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1456,7 +1456,7 @@ struct i40e_ddp_version {
struct i40e_package_header {
struct i40e_ddp_version version;
u32 segment_count;
- u32 segment_offset[1];
+ u32 segment_offset[];
};
/* Generic segment header */
--
2.34.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
@ 2023-08-02 5:05 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:05 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, intel-wired-lan, linux-kernel, Gustavo A. R. Silva,
linux-hardening
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.
The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
index 7e8183762fd9..0db6f5e3cfcc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
@@ -220,7 +220,7 @@ static bool i40e_ddp_is_pkg_hdr_valid(struct net_device *netdev,
netdev_err(netdev, "Invalid DDP profile - size is bigger than 4G");
return false;
}
- if (size < (sizeof(struct i40e_package_header) +
+ if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
netdev_err(netdev, "Invalid DDP profile - size is too small.");
return false;
@@ -281,7 +281,7 @@ int i40e_ddp_load(struct net_device *netdev, const u8 *data, size_t size,
if (!i40e_ddp_is_pkg_hdr_valid(netdev, pkg_hdr, size))
return -EINVAL;
- if (size < (sizeof(struct i40e_package_header) +
+ if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
netdev_err(netdev, "Invalid DDP recipe size.");
return -EINVAL;
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index 388c3d36d96a..c3d5fe12059a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1456,7 +1456,7 @@ struct i40e_ddp_version {
struct i40e_package_header {
struct i40e_ddp_version version;
u32 segment_count;
- u32 segment_offset[1];
+ u32 segment_offset[];
};
/* Generic segment header */
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
2023-08-02 5:05 ` Gustavo A. R. Silva
@ 2023-08-02 15:18 ` Simon Horman
-1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:18 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Tue, Aug 01, 2023 at 11:05:31PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_package_header with flexible-array
> member.
>
> The `+ sizeof(u32)` adjustments ensure that there are no differences
> in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++--
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> index 7e8183762fd9..0db6f5e3cfcc 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> @@ -220,7 +220,7 @@ static bool i40e_ddp_is_pkg_hdr_valid(struct net_device *netdev,
> netdev_err(netdev, "Invalid DDP profile - size is bigger than 4G");
> return false;
> }
> - if (size < (sizeof(struct i40e_package_header) +
> + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
Hi Gustavo,
would it make more sense to use struct_size() here?
> sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
> netdev_err(netdev, "Invalid DDP profile - size is too small.");
> return false;
> @@ -281,7 +281,7 @@ int i40e_ddp_load(struct net_device *netdev, const u8 *data, size_t size,
> if (!i40e_ddp_is_pkg_hdr_valid(netdev, pkg_hdr, size))
> return -EINVAL;
>
> - if (size < (sizeof(struct i40e_package_header) +
> + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
> sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
> netdev_err(netdev, "Invalid DDP recipe size.");
> return -EINVAL;
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index 388c3d36d96a..c3d5fe12059a 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -1456,7 +1456,7 @@ struct i40e_ddp_version {
> struct i40e_package_header {
> struct i40e_ddp_version version;
> u32 segment_count;
> - u32 segment_offset[1];
> + u32 segment_offset[];
> };
>
> /* Generic segment header */
> --
> 2.34.1
>
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
@ 2023-08-02 15:18 ` Simon Horman
0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:18 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Tue, Aug 01, 2023 at 11:05:31PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_package_header with flexible-array
> member.
>
> The `+ sizeof(u32)` adjustments ensure that there are no differences
> in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++--
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> index 7e8183762fd9..0db6f5e3cfcc 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c
> @@ -220,7 +220,7 @@ static bool i40e_ddp_is_pkg_hdr_valid(struct net_device *netdev,
> netdev_err(netdev, "Invalid DDP profile - size is bigger than 4G");
> return false;
> }
> - if (size < (sizeof(struct i40e_package_header) +
> + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
Hi Gustavo,
would it make more sense to use struct_size() here?
> sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
> netdev_err(netdev, "Invalid DDP profile - size is too small.");
> return false;
> @@ -281,7 +281,7 @@ int i40e_ddp_load(struct net_device *netdev, const u8 *data, size_t size,
> if (!i40e_ddp_is_pkg_hdr_valid(netdev, pkg_hdr, size))
> return -EINVAL;
>
> - if (size < (sizeof(struct i40e_package_header) +
> + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) +
> sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) {
> netdev_err(netdev, "Invalid DDP recipe size.");
> return -EINVAL;
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index 388c3d36d96a..c3d5fe12059a 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -1456,7 +1456,7 @@ struct i40e_ddp_version {
> struct i40e_package_header {
> struct i40e_ddp_version version;
> u32 segment_count;
> - u32 segment_offset[1];
> + u32 segment_offset[];
> };
>
> /* Generic segment header */
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
2023-08-02 5:05 ` Gustavo A. R. Silva
@ 2023-08-10 10:04 ` Pucha, HimasekharX Reddy
-1 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:36 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_package_header with flexible-array member.
>
> The `+ sizeof(u32)` adjustments ensure that there are no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
@ 2023-08-10 10:04 ` Pucha, HimasekharX Reddy
0 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:36 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_package_header with flexible-array member.
>
> The `+ sizeof(u32)` adjustments ensure that there are no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 32+ messages in thread
* [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-02 5:04 ` Gustavo A. R. Silva
@ 2023-08-02 5:05 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:05 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-hardening, netdev, intel-wired-lan, linux-kernel,
Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index c3d5fe12059a..f7a984304b65 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
struct i40e_ddp_version version;
char name[I40E_DDP_NAME_SIZE];
u32 device_table_count;
- struct i40e_device_id_entry device_table[1];
+ struct i40e_device_id_entry device_table[];
};
struct i40e_section_table {
--
2.34.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-02 5:05 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:05 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, intel-wired-lan, linux-kernel, Gustavo A. R. Silva,
linux-hardening
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index c3d5fe12059a..f7a984304b65 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
struct i40e_ddp_version version;
char name[I40E_DDP_NAME_SIZE];
u32 device_table_count;
- struct i40e_device_id_entry device_table[1];
+ struct i40e_device_id_entry device_table[];
};
struct i40e_section_table {
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-02 5:05 ` Gustavo A. R. Silva
@ 2023-08-02 15:23 ` Simon Horman
-1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_segment with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-02 15:23 ` Simon Horman
0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_segment with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-02 5:05 ` Gustavo A. R. Silva
@ 2023-08-10 10:06 ` Pucha, HimasekharX Reddy
-1 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:36 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_segment with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-10 10:06 ` Pucha, HimasekharX Reddy
0 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:36 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_segment with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-02 5:05 ` Gustavo A. R. Silva
@ 2023-08-10 17:34 ` Justin Stitt
-1 siblings, 0 replies; 32+ messages in thread
From: Justin Stitt @ 2023-08-10 17:34 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_segment with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Justin Stitt <justinstitt@google.com>
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index c3d5fe12059a..f7a984304b65 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
> struct i40e_ddp_version version;
> char name[I40E_DDP_NAME_SIZE];
> u32 device_table_count;
> - struct i40e_device_id_entry device_table[1];
> + struct i40e_device_id_entry device_table[];
> };
>
> struct i40e_section_table {
> --
> 2.34.1
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-10 17:34 ` Justin Stitt
0 siblings, 0 replies; 32+ messages in thread
From: Justin Stitt @ 2023-08-10 17:34 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_segment with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Justin Stitt <justinstitt@google.com>
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index c3d5fe12059a..f7a984304b65 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
> struct i40e_ddp_version version;
> char name[I40E_DDP_NAME_SIZE];
> u32 device_table_count;
> - struct i40e_device_id_entry device_table[1];
> + struct i40e_device_id_entry device_table[];
> };
>
> struct i40e_section_table {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-10 17:34 ` Justin Stitt
@ 2023-08-10 20:49 ` Justin Stitt
-1 siblings, 0 replies; 32+ messages in thread
From: Justin Stitt @ 2023-08-10 20:49 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote:
> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> > One-element and zero-length arrays are deprecated. So, replace
> > one-element array in struct i40e_profile_segment with flexible-array
> > member.
> >
> > This results in no differences in binary output.
> >
> > Link: https://github.com/KSPP/linux/issues/335
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> Tested-by: Justin Stitt <justinstitt@google.com>
Whoops, this should be:
Reviewed-by: Justin Stitt <justinstitt@google.com>
I did not test, I just verified there are no binary differences produced
by this patch.
>
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> > index c3d5fe12059a..f7a984304b65 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> > @@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
> > struct i40e_ddp_version version;
> > char name[I40E_DDP_NAME_SIZE];
> > u32 device_table_count;
> > - struct i40e_device_id_entry device_table[1];
> > + struct i40e_device_id_entry device_table[];
> > };
> >
> > struct i40e_section_table {
> > --
> > 2.34.1
> >
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-10 20:49 ` Justin Stitt
0 siblings, 0 replies; 32+ messages in thread
From: Justin Stitt @ 2023-08-10 20:49 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote:
> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> > One-element and zero-length arrays are deprecated. So, replace
> > one-element array in struct i40e_profile_segment with flexible-array
> > member.
> >
> > This results in no differences in binary output.
> >
> > Link: https://github.com/KSPP/linux/issues/335
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> Tested-by: Justin Stitt <justinstitt@google.com>
Whoops, this should be:
Reviewed-by: Justin Stitt <justinstitt@google.com>
I did not test, I just verified there are no binary differences produced
by this patch.
>
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> > index c3d5fe12059a..f7a984304b65 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> > @@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
> > struct i40e_ddp_version version;
> > char name[I40E_DDP_NAME_SIZE];
> > u32 device_table_count;
> > - struct i40e_device_id_entry device_table[1];
> > + struct i40e_device_id_entry device_table[];
> > };
> >
> > struct i40e_section_table {
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
2023-08-10 20:49 ` Justin Stitt
@ 2023-08-10 21:51 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-10 21:51 UTC (permalink / raw)
To: Justin Stitt, Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On 8/10/23 14:49, Justin Stitt wrote:
> On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote:
>> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
>>> One-element and zero-length arrays are deprecated. So, replace
>>> one-element array in struct i40e_profile_segment with flexible-array
>>> member.
>>>
>>> This results in no differences in binary output.
>>>
>>> Link: https://github.com/KSPP/linux/issues/335
>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>> ---
>>> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> Tested-by: Justin Stitt <justinstitt@google.com>
> Whoops, this should be:
> Reviewed-by: Justin Stitt <justinstitt@google.com>
>
> I did not test, I just verified there are no binary differences produced
> by this patch.
In that case, `Build-tested-by` seems more appropriate.
Anyways, the series has been applied already.
--
Gustavo
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
@ 2023-08-10 21:51 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-10 21:51 UTC (permalink / raw)
To: Justin Stitt, Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On 8/10/23 14:49, Justin Stitt wrote:
> On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote:
>> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
>>> One-element and zero-length arrays are deprecated. So, replace
>>> one-element array in struct i40e_profile_segment with flexible-array
>>> member.
>>>
>>> This results in no differences in binary output.
>>>
>>> Link: https://github.com/KSPP/linux/issues/335
>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>> ---
>>> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> Tested-by: Justin Stitt <justinstitt@google.com>
> Whoops, this should be:
> Reviewed-by: Justin Stitt <justinstitt@google.com>
>
> I did not test, I just verified there are no binary differences produced
> by this patch.
In that case, `Build-tested-by` seems more appropriate.
Anyways, the series has been applied already.
--
Gustavo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
2023-08-02 5:04 ` Gustavo A. R. Silva
@ 2023-08-02 5:06 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:06 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-hardening, netdev, intel-wired-lan, linux-kernel,
Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index f7a984304b65..010261a10f56 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1492,7 +1492,7 @@ struct i40e_profile_segment {
struct i40e_section_table {
u32 section_count;
- u32 section_offset[1];
+ u32 section_offset[];
};
struct i40e_profile_section_header {
--
2.34.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
@ 2023-08-02 5:06 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:06 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, intel-wired-lan, linux-kernel, Gustavo A. R. Silva,
linux-hardening
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index f7a984304b65..010261a10f56 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1492,7 +1492,7 @@ struct i40e_profile_segment {
struct i40e_section_table {
u32 section_count;
- u32 section_offset[1];
+ u32 section_offset[];
};
struct i40e_profile_section_header {
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
2023-08-02 5:06 ` Gustavo A. R. Silva
@ 2023-08-02 15:23 ` Simon Horman
-1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Tue, Aug 01, 2023 at 11:06:30PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_section_table with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
@ 2023-08-02 15:23 ` Simon Horman
0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Tue, Aug 01, 2023 at 11:06:30PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_section_table with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
2023-08-02 5:06 ` Gustavo A. R. Silva
@ 2023-08-10 10:08 ` Pucha, HimasekharX Reddy
-1 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:37 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_section_table with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
@ 2023-08-10 10:08 ` Pucha, HimasekharX Reddy
0 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:37 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_section_table with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 32+ messages in thread
* [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
2023-08-02 5:04 ` Gustavo A. R. Silva
@ 2023-08-02 5:07 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:07 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-hardening, netdev, intel-wired-lan, linux-kernel,
Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index 010261a10f56..b9d50218344b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1524,7 +1524,7 @@ struct i40e_profile_aq_section {
u16 flags;
u8 param[16];
u16 datalen;
- u8 data[1];
+ u8 data[];
};
struct i40e_profile_info {
--
2.34.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
@ 2023-08-02 5:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 32+ messages in thread
From: Gustavo A. R. Silva @ 2023-08-02 5:07 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, intel-wired-lan, linux-kernel, Gustavo A. R. Silva,
linux-hardening
One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.
This results in no differences in binary output.
Link: https://github.com/KSPP/linux/issues/335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
index 010261a10f56..b9d50218344b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1524,7 +1524,7 @@ struct i40e_profile_aq_section {
u16 flags;
u8 param[16];
u16 datalen;
- u8 data[1];
+ u8 data[];
};
struct i40e_profile_info {
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
2023-08-02 5:07 ` Gustavo A. R. Silva
@ 2023-08-02 15:24 ` Simon Horman
-1 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:24 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: netdev, Jesse Brandeburg, linux-kernel, Eric Dumazet, Tony Nguyen,
linux-hardening, intel-wired-lan, Jakub Kicinski, Paolo Abeni,
David S. Miller
On Tue, Aug 01, 2023 at 11:07:06PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_aq_section with
> flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
@ 2023-08-02 15:24 ` Simon Horman
0 siblings, 0 replies; 32+ messages in thread
From: Simon Horman @ 2023-08-02 15:24 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, intel-wired-lan,
linux-kernel, linux-hardening
On Tue, Aug 01, 2023 at 11:07:06PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_aq_section with
> flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
2023-08-02 5:07 ` Gustavo A. R. Silva
@ 2023-08-10 10:13 ` Pucha, HimasekharX Reddy
-1 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:13 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:37 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_aq_section with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 32+ messages in thread
* RE: [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
@ 2023-08-10 10:13 ` Pucha, HimasekharX Reddy
0 siblings, 0 replies; 32+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-08-10 10:13 UTC (permalink / raw)
To: Gustavo A. R. Silva, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, August 2, 2023 10:37 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>
> Subject: [Intel-wired-lan] [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section
>
> One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_aq_section with flexible-array member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 32+ messages in thread