All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: <iommu@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <robin.murphy@arm.com>,
	<will@kernel.org>, <jean-philippe@linaro.org>, <jgg@nvidia.com>
Subject: Re: [PATCH v6 00/10] Refactor the SMMU's CD table ownership
Date: Wed, 16 Aug 2023 16:59:43 -0700	[thread overview]
Message-ID: <ZN1i793BPZ+snidD@Asurada-Nvidia> (raw)
In-Reply-To: <20230816131925.2521220-1-mshavit@google.com>

On Wed, Aug 16, 2023 at 09:18:40PM +0800, Michael Shavit wrote:
 
> Hi all,
> 
> This series refactors stage 1 domains so that they describe a single CD
> entry. These entries are now inserted into a CD table that is owned by
> the arm_smmu_master instead of the domain.
> This is conceptually cleaner and unblocks other features, such as
> attaching domains with PASID (for unmanaged/dma domains).
> 
> This patch series was originally part of a larger patch series that
> implemented the set_dev_pasid callback for non-SVA domains but is now
> split into a distinct series.
> 
> This patch series is also available on gerrit with Jean's SMMU test
> engine patches cherry-picked on top for testing:
> https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/24770/9
> 
> Thanks,
> Michael Shavit
> 
> Changes in v6:
> - Undo removal of s1fmt and renaming of s1cdmax
> - Unwind the loop in amr_smmu_write_ctx_desc_devices to NULL out the CD
>   entries we succesfully wrote on failure.
> - Add a comment clarifying the different usages of
>   amr_smmu_write_ctx_desc_devices
> - Grab the asid lock while writing the RID CD to prevent a race with
>   SVA.
> - Add the device to the devices list before writing the CD to the table
>   and installing the CD table.

Though there's a thing in PATCH-6 that I couldn't fully understand
yet, SVA/ATS sanity works with the series. So,

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicolinc@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: <iommu@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <robin.murphy@arm.com>,
	<will@kernel.org>, <jean-philippe@linaro.org>, <jgg@nvidia.com>
Subject: Re: [PATCH v6 00/10] Refactor the SMMU's CD table ownership
Date: Wed, 16 Aug 2023 16:59:43 -0700	[thread overview]
Message-ID: <ZN1i793BPZ+snidD@Asurada-Nvidia> (raw)
In-Reply-To: <20230816131925.2521220-1-mshavit@google.com>

On Wed, Aug 16, 2023 at 09:18:40PM +0800, Michael Shavit wrote:
 
> Hi all,
> 
> This series refactors stage 1 domains so that they describe a single CD
> entry. These entries are now inserted into a CD table that is owned by
> the arm_smmu_master instead of the domain.
> This is conceptually cleaner and unblocks other features, such as
> attaching domains with PASID (for unmanaged/dma domains).
> 
> This patch series was originally part of a larger patch series that
> implemented the set_dev_pasid callback for non-SVA domains but is now
> split into a distinct series.
> 
> This patch series is also available on gerrit with Jean's SMMU test
> engine patches cherry-picked on top for testing:
> https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/24770/9
> 
> Thanks,
> Michael Shavit
> 
> Changes in v6:
> - Undo removal of s1fmt and renaming of s1cdmax
> - Unwind the loop in amr_smmu_write_ctx_desc_devices to NULL out the CD
>   entries we succesfully wrote on failure.
> - Add a comment clarifying the different usages of
>   amr_smmu_write_ctx_desc_devices
> - Grab the asid lock while writing the RID CD to prevent a race with
>   SVA.
> - Add the device to the devices list before writing the CD to the table
>   and installing the CD table.

Though there's a thing in PATCH-6 that I couldn't fully understand
yet, SVA/ATS sanity works with the series. So,

Tested-by: Nicolin Chen <nicolinc@nvidia.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-08-16 23:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 13:18 [PATCH v6 00/10] Refactor the SMMU's CD table ownership Michael Shavit
2023-08-16 13:18 ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 01/10] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 02/10] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 03/10] iommu/arm-smmu-v3: Encapsulate ctx_desc_cfg init in alloc_cd_tables Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 04/10] iommu/arm-smmu-v3: move stall_enabled to the cd table Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 05/10] iommu/arm-smmu-v3: Refactor write_ctx_desc Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 22:36   ` Nicolin Chen
2023-08-16 22:36     ` Nicolin Chen
2023-08-17  8:00     ` Michael Shavit
2023-08-17  8:00       ` Michael Shavit
2023-08-16 13:18 ` [PATCH v6 06/10] iommu/arm-smmu-v3: Move CD table to arm_smmu_master Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 23:44   ` Nicolin Chen
2023-08-16 23:44     ` Nicolin Chen
2023-08-17  8:14     ` Michael Shavit
2023-08-17  8:14       ` Michael Shavit
2023-08-17  0:50   ` Nicolin Chen
2023-08-17  0:50     ` Nicolin Chen
2023-08-16 13:18 ` [PATCH v6 07/10] iommu/arm-smmu-v3: Cleanup arm_smmu_domain_finalise Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 23:45   ` Nicolin Chen
2023-08-16 23:45     ` Nicolin Chen
2023-08-16 13:18 ` [PATCH v6 08/10] iommu/arm-smmu-v3: Update comment about STE liveness Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 14:00   ` Jason Gunthorpe
2023-08-16 14:00     ` Jason Gunthorpe
2023-08-16 23:46   ` Nicolin Chen
2023-08-16 23:46     ` Nicolin Chen
2023-08-16 13:18 ` [PATCH v6 09/10] iommu/arm-smmu-v3: Skip cd sync if CD table isn't active Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-21 10:16   ` Michael Shavit
2023-08-21 10:16     ` Michael Shavit
2023-08-21 10:42     ` Will Deacon
2023-08-21 10:42       ` Will Deacon
2023-08-16 13:18 ` [PATCH v6 10/10] iommu/arm-smmu-v3: Rename cdcfg to cd_table Michael Shavit
2023-08-16 13:18   ` Michael Shavit
2023-08-16 23:59 ` Nicolin Chen [this message]
2023-08-16 23:59   ` [PATCH v6 00/10] Refactor the SMMU's CD table ownership Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN1i793BPZ+snidD@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jean-philippe@linaro.org \
    --cc=jgg@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mshavit@google.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.