From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Erik Schilling <erik.schilling@linaro.org>
Cc: meta-virtualization <meta-virtualization@lists.yoctoproject.org>,
Mikko Rapeli <mikko.rapeli@linaro.org>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
Date: Thu, 17 Aug 2023 20:04:12 +0000 [thread overview]
Message-ID: <ZN59PKR1ZUFY9Ypm@gmail.com> (raw)
In-Reply-To: <20230816-vhost-device-clang-fix-v1-1-bbbd47b13e5b@linaro.org>
It worked in my testing!
This has now merged.
Bruce
In message: [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
on 16/08/2023 Erik Schilling wrote:
> This disables the recipe - which depends on clang-native - if meta-clang
> is not active.
>
> Link: https://lore.kernel.org/yocto-meta-virtualization/ZNyErpfW8p2lX81Z@nuoska/
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Suggested-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> As discussed in the linked thread.
>
> Sorry for the inconveniences!
> ---
> recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> index 4ef9de4..7993116 100644
> --- a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> +++ b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> @@ -10,6 +10,8 @@ DEPENDS += "libgpiod"
> # libgpiod-sys generates bindings using bindgen, which depends on clang
> DEPENDS += "clang-native"
>
> +SKIP_RECIPE[vhost-device-gpio] ?= "${@bb.utils.contains('BBFILE_COLLECTIONS', 'clang-layer', '', 'Depends on clang-native from meta-clang which is not included', d)}"
> +
> SRC_URI += "crate://crates.io/vhost-device-gpio/0.1.0"
> SRC_URI[vhost-device-gpio-0.1.0.sha256sum] = "f4789dd127ce746d4f702d50256ff09e47b19fdb2bfee88a254b7e48efbf1100"
>
>
> ---
> base-commit: 28205358690f79e13c1970ea7d61bce0131da027
> change-id: 20230816-vhost-device-clang-fix-8348952fd3d8
>
> Best regards,
> --
> Erik Schilling <erik.schilling@linaro.org>
>
next prev parent reply other threads:[~2023-08-17 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 19:03 [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists Erik Schilling
2023-08-17 20:04 ` Bruce Ashfield [this message]
2023-08-18 6:18 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN59PKR1ZUFY9Ypm@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=erik.schilling@linaro.org \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=mikko.rapeli@linaro.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.