All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
@ 2023-08-16 19:03 Erik Schilling
  2023-08-17 20:04 ` Bruce Ashfield
  2023-08-18  6:18 ` Richard Purdie
  0 siblings, 2 replies; 3+ messages in thread
From: Erik Schilling @ 2023-08-16 19:03 UTC (permalink / raw)
  To: meta-virtualization
  Cc: Mikko Rapeli, Richard Purdie, Bruce Ashfield, Erik Schilling

This disables the recipe - which depends on clang-native - if meta-clang
is not active.

Link: https://lore.kernel.org/yocto-meta-virtualization/ZNyErpfW8p2lX81Z@nuoska/
Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Suggested-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
---
As discussed in the linked thread.

Sorry for the inconveniences!
---
 recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
index 4ef9de4..7993116 100644
--- a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
+++ b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
@@ -10,6 +10,8 @@ DEPENDS += "libgpiod"
 # libgpiod-sys generates bindings using bindgen, which depends on clang
 DEPENDS += "clang-native"
 
+SKIP_RECIPE[vhost-device-gpio] ?= "${@bb.utils.contains('BBFILE_COLLECTIONS', 'clang-layer', '', 'Depends on clang-native from meta-clang which is not included', d)}"
+
 SRC_URI += "crate://crates.io/vhost-device-gpio/0.1.0"
 SRC_URI[vhost-device-gpio-0.1.0.sha256sum] = "f4789dd127ce746d4f702d50256ff09e47b19fdb2bfee88a254b7e48efbf1100"
 

---
base-commit: 28205358690f79e13c1970ea7d61bce0131da027
change-id: 20230816-vhost-device-clang-fix-8348952fd3d8

Best regards,
-- 
Erik Schilling <erik.schilling@linaro.org>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
  2023-08-16 19:03 [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists Erik Schilling
@ 2023-08-17 20:04 ` Bruce Ashfield
  2023-08-18  6:18 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2023-08-17 20:04 UTC (permalink / raw)
  To: Erik Schilling; +Cc: meta-virtualization, Mikko Rapeli, Richard Purdie

It worked in my testing!

This has now merged.

Bruce

In message: [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
on 16/08/2023 Erik Schilling wrote:

> This disables the recipe - which depends on clang-native - if meta-clang
> is not active.
> 
> Link: https://lore.kernel.org/yocto-meta-virtualization/ZNyErpfW8p2lX81Z@nuoska/
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Suggested-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> As discussed in the linked thread.
> 
> Sorry for the inconveniences!
> ---
>  recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> index 4ef9de4..7993116 100644
> --- a/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> +++ b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb
> @@ -10,6 +10,8 @@ DEPENDS += "libgpiod"
>  # libgpiod-sys generates bindings using bindgen, which depends on clang
>  DEPENDS += "clang-native"
>  
> +SKIP_RECIPE[vhost-device-gpio] ?= "${@bb.utils.contains('BBFILE_COLLECTIONS', 'clang-layer', '', 'Depends on clang-native from meta-clang which is not included', d)}"
> +
>  SRC_URI += "crate://crates.io/vhost-device-gpio/0.1.0"
>  SRC_URI[vhost-device-gpio-0.1.0.sha256sum] = "f4789dd127ce746d4f702d50256ff09e47b19fdb2bfee88a254b7e48efbf1100"
>  
> 
> ---
> base-commit: 28205358690f79e13c1970ea7d61bce0131da027
> change-id: 20230816-vhost-device-clang-fix-8348952fd3d8
> 
> Best regards,
> -- 
> Erik Schilling <erik.schilling@linaro.org>
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists
  2023-08-16 19:03 [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists Erik Schilling
  2023-08-17 20:04 ` Bruce Ashfield
@ 2023-08-18  6:18 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2023-08-18  6:18 UTC (permalink / raw)
  To: Erik Schilling, meta-virtualization; +Cc: Mikko Rapeli, Bruce Ashfield

On Wed, 2023-08-16 at 21:03 +0200, Erik Schilling wrote:
> This disables the recipe - which depends on clang-native - if meta-clang
> is not active.
> 
> Link: https://lore.kernel.org/yocto-meta-virtualization/ZNyErpfW8p2lX81Z@nuoska/
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Suggested-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> As discussed in the linked thread.
> 
> Sorry for the inconveniences!

Thanks, I'm happy to see this quickly fixed! :)

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-18  6:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-16 19:03 [meta-virtualization][PATCH] vhost-device-gpio: only enable if meta-clang exists Erik Schilling
2023-08-17 20:04 ` Bruce Ashfield
2023-08-18  6:18 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.