Re: [PATCH v6 6/6] perf vendor events arm64: Update N2 and V2 metrics and events using Arm telemetry repo

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	Haixin Yu <yuhaixin.yhx@linux.alibaba.com>,
	Nick Forrington <nick.forrington@arm.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Sohom Datta <sohomdatta1@gmail.com>,
	Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, irogers@google.com,
	renyu.zj@linux.alibaba.com
Subject: Re: [PATCH v6 6/6] perf vendor events arm64: Update N2 and V2 metrics and events using Arm telemetry repo
Date: Thu, 17 Aug 2023 14:13:54 -0300	[thread overview]
Message-ID: <ZN5VUkswJnwTaWZj@kernel.org> (raw)
In-Reply-To: <43e5d3e9-fe5f-655d-a6d3-44d47081e1a4@arm.com>

Em Thu, Aug 17, 2023 at 03:41:11PM +0100, James Clark escreveu:
> 
> 
> On 17/08/2023 12:09, John Garry wrote:
> > On 16/08/2023 12:47, James Clark wrote:
> >> Apart from some slight naming and grouping differences, the new metrics
> >> are functionally the same as the existing ones. Any missing metrics were
> >> manually appended to the end of the auto generated file.
> >>
> >> For the events, the new data includes descriptions that may have product
> >> specific details and new groupings that will be consistent with other
> >> products.
> >>
> >> After generating the metrics from the telemetry repo [1], the following
> >> manual steps were performed:
> >>
> >>   * Change the topdown expressions to compare on CPUID and use
> >>     #slots so that the same data can be shared between N2 and V2. Apart
> >>     from these modifications, the expressions now match more closely with
> >>     the Arm telemetry data which will hopefully make future updates
> >>     easier.
> >>
> >>   * Append some metrics from the old N2/V2 data that aren't present in
> >>     the telemetry data. These will possibly be added to the
> >>     telemetry-solution repo at a later time:
> >>
> >>      l3d_cache_mpki, l3d_cache_miss_rate, branch_pki, ipc_rate, spec_ipc,
> >>      retired_rate, wasted_rate, branch_immed_spec_rate,
> >>      branch_return_spec_rate, branch_indirect_spec_rate
> >>
> >> [1]:https://urldefense.com/v3/__https://gitlab.arm.com/telemetry-solution/telemetry-solution/-/blob/main/data/pmu/cpu/neoverse/neoverse-n2.json__;!!ACWV5N9M2RV99hQ!NW7DYe7T69u8RFn9WLyiCcoHm-8BtlxNK3PRw19udocwlwv0vQpjcSDT5XqGbWzvPQyFrG-eRkuu_VZt7cO8-Q$ 
> >> Signed-off-by: James Clark<james.clark@arm.com>
> > 
> > Reviewed-by: John Garry <john.g.garry@oracle.com>
> 
> Thanks for the reviews!

Thanks everybody, patches merged, reviewed-by tags collected.

- Arnaldo