* [PATCH] iommu/sprd: Add missing force_aperture
@ 2023-07-24 17:36 Jason Gunthorpe
2023-07-25 9:13 ` Chunyan Zhang
2023-08-07 12:34 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2023-07-24 17:36 UTC (permalink / raw)
To: Baolin Wang, iommu, Joerg Roedel, Orson Zhai, Robin Murphy,
Will Deacon, Chunyan Zhang
Cc: Chunyan Zhang, Joerg Roedel
force_aperture was intended to false only by GART drivers that have an
identity translation outside the aperture. This does not describe sprd, so
add the missing 'force_aperture = true'.
Fixes: b23e4fc4e3fa ("iommu: add Unisoc IOMMU basic driver")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/sprd-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
index af68b3a2c123ab..183ca889a6f9c4 100644
--- a/drivers/iommu/sprd-iommu.c
+++ b/drivers/iommu/sprd-iommu.c
@@ -145,6 +145,7 @@ static struct iommu_domain *sprd_iommu_domain_alloc_paging(struct device *dev)
dom->domain.geometry.aperture_start = 0;
dom->domain.geometry.aperture_end = SZ_256M - 1;
+ dom->domain.geometry.force_aperture = true;
return &dom->domain;
}
base-commit: b9e8d053f9e8b9d3aa1b5113e3fcfb66ef450564
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/sprd: Add missing force_aperture
2023-07-24 17:36 [PATCH] iommu/sprd: Add missing force_aperture Jason Gunthorpe
@ 2023-07-25 9:13 ` Chunyan Zhang
2023-08-07 12:34 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Chunyan Zhang @ 2023-07-25 9:13 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Baolin Wang, iommu, Joerg Roedel, Orson Zhai, Robin Murphy,
Will Deacon, Chunyan Zhang, Joerg Roedel
On Tue, 25 Jul 2023 at 01:36, Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> force_aperture was intended to false only by GART drivers that have an
> identity translation outside the aperture. This does not describe sprd, so
> add the missing 'force_aperture = true'.
>
> Fixes: b23e4fc4e3fa ("iommu: add Unisoc IOMMU basic driver")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Thanks,
Chunyan
> ---
> drivers/iommu/sprd-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
> index af68b3a2c123ab..183ca889a6f9c4 100644
> --- a/drivers/iommu/sprd-iommu.c
> +++ b/drivers/iommu/sprd-iommu.c
> @@ -145,6 +145,7 @@ static struct iommu_domain *sprd_iommu_domain_alloc_paging(struct device *dev)
>
> dom->domain.geometry.aperture_start = 0;
> dom->domain.geometry.aperture_end = SZ_256M - 1;
> + dom->domain.geometry.force_aperture = true;
>
> return &dom->domain;
> }
>
> base-commit: b9e8d053f9e8b9d3aa1b5113e3fcfb66ef450564
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/sprd: Add missing force_aperture
2023-07-24 17:36 [PATCH] iommu/sprd: Add missing force_aperture Jason Gunthorpe
2023-07-25 9:13 ` Chunyan Zhang
@ 2023-08-07 12:34 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2023-08-07 12:34 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Baolin Wang, iommu, Orson Zhai, Robin Murphy, Will Deacon,
Chunyan Zhang, Chunyan Zhang, Joerg Roedel
On Mon, Jul 24, 2023 at 02:36:05PM -0300, Jason Gunthorpe wrote:
> drivers/iommu/sprd-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-07 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-24 17:36 [PATCH] iommu/sprd: Add missing force_aperture Jason Gunthorpe
2023-07-25 9:13 ` Chunyan Zhang
2023-08-07 12:34 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.