From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-xe] [PATCH igt] tests/xe_debugfs: Skip test for tile count
Date: Mon, 7 Aug 2023 18:14:53 -0400 [thread overview]
Message-ID: <ZNFs3Y65lM1mbjth@intel.com> (raw)
In-Reply-To: <20230803220248.871666-1-lucas.demarchi@intel.com>
On Thu, Aug 03, 2023 at 03:02:48PM -0700, Lucas De Marchi wrote:
> Once upon a time in xe, tile count and gt count were the same thing.
> This is not necessarily true anymore. Example: Meteor Lake has just
> one tile, but 2 GTs (one for graphics, one for media).
>
> There's little value in comparing what the kernel exports via ioctl
> from what the kernel exports via debugfs. Just remove the test.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/xe/xe_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/xe/xe_debugfs.c b/tests/xe/xe_debugfs.c
> index 5434d4645..e51d03661 100644
> --- a/tests/xe/xe_debugfs.c
> +++ b/tests/xe/xe_debugfs.c
> @@ -104,9 +104,6 @@ test_base(int fd, struct drm_xe_query_config *config)
>
> igt_assert(igt_debugfs_search(fd, "info", reference));
>
> - sprintf(reference, "tile_count %lld", config->info[XE_QUERY_CONFIG_GT_COUNT]);
> - igt_assert(igt_debugfs_search(fd, "info", reference));
> -
> switch (config->info[XE_QUERY_CONFIG_VA_BITS]) {
> case 48:
> val = 3;
> --
> 2.40.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Matt Roper <matthew.d.roper@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH igt] tests/xe_debugfs: Skip test for tile count
Date: Mon, 7 Aug 2023 18:14:53 -0400 [thread overview]
Message-ID: <ZNFs3Y65lM1mbjth@intel.com> (raw)
In-Reply-To: <20230803220248.871666-1-lucas.demarchi@intel.com>
On Thu, Aug 03, 2023 at 03:02:48PM -0700, Lucas De Marchi wrote:
> Once upon a time in xe, tile count and gt count were the same thing.
> This is not necessarily true anymore. Example: Meteor Lake has just
> one tile, but 2 GTs (one for graphics, one for media).
>
> There's little value in comparing what the kernel exports via ioctl
> from what the kernel exports via debugfs. Just remove the test.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/xe/xe_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/xe/xe_debugfs.c b/tests/xe/xe_debugfs.c
> index 5434d4645..e51d03661 100644
> --- a/tests/xe/xe_debugfs.c
> +++ b/tests/xe/xe_debugfs.c
> @@ -104,9 +104,6 @@ test_base(int fd, struct drm_xe_query_config *config)
>
> igt_assert(igt_debugfs_search(fd, "info", reference));
>
> - sprintf(reference, "tile_count %lld", config->info[XE_QUERY_CONFIG_GT_COUNT]);
> - igt_assert(igt_debugfs_search(fd, "info", reference));
> -
> switch (config->info[XE_QUERY_CONFIG_VA_BITS]) {
> case 48:
> val = 3;
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-08-07 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 22:02 [igt-dev] [PATCH igt] tests/xe_debugfs: Skip test for tile count Lucas De Marchi
2023-08-03 22:02 ` [Intel-xe] " Lucas De Marchi
2023-08-03 23:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-08-03 23:13 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-03 23:14 ` [Intel-xe] ✗ CI.Patch_applied: failure " Patchwork
2023-08-04 6:03 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork
2023-08-11 15:12 ` Kamil Konieczny
2023-08-11 21:31 ` Lucas De Marchi
2023-08-07 22:14 ` Rodrigo Vivi [this message]
2023-08-07 22:14 ` [Intel-xe] [PATCH igt] " Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNFs3Y65lM1mbjth@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.