From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
robin.murphy@arm.com, nicolinc@nvidia.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v4 6/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master
Date: Mon, 7 Aug 2023 19:41:49 -0300 [thread overview]
Message-ID: <ZNFzLfemo6joVcsI@nvidia.com> (raw)
In-Reply-To: <CAKHBV25fCOE3pVysLaB2e67G0Be3FdWLKb+ZsmbHg8CyPpwo5A@mail.gmail.com>
On Mon, Aug 07, 2023 at 08:19:44PM +0800, Michael Shavit wrote:
> On Fri, Aug 4, 2023 at 2:47 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >
> >
> > I'm not surprised, I think arm_smmu_write_ctx is a little too clever
> > for its own good..
> >
> > I would have written it by computing the full target CD entry,
> > extracted directly from the domain.
> >
>
> Yeah I was considering making a fix to arm_smmu_write_ctx instead; but
> clearing the CD entry on detach feels like the right thing to do.
> Relying on the 0th CD entry being re-written when the CD table is
> re-inserted feels fragile.
>
> Perhaps re-writing arm_smmu_write_ctx could be considered as a
> separate singleton patch?
I wouldn't touch it in this series at least
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
robin.murphy@arm.com, nicolinc@nvidia.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v4 6/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master
Date: Mon, 7 Aug 2023 19:41:49 -0300 [thread overview]
Message-ID: <ZNFzLfemo6joVcsI@nvidia.com> (raw)
In-Reply-To: <CAKHBV25fCOE3pVysLaB2e67G0Be3FdWLKb+ZsmbHg8CyPpwo5A@mail.gmail.com>
On Mon, Aug 07, 2023 at 08:19:44PM +0800, Michael Shavit wrote:
> On Fri, Aug 4, 2023 at 2:47 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >
> >
> > I'm not surprised, I think arm_smmu_write_ctx is a little too clever
> > for its own good..
> >
> > I would have written it by computing the full target CD entry,
> > extracted directly from the domain.
> >
>
> Yeah I was considering making a fix to arm_smmu_write_ctx instead; but
> clearing the CD entry on detach feels like the right thing to do.
> Relying on the 0th CD entry being re-written when the CD table is
> re-inserted feels fragile.
>
> Perhaps re-writing arm_smmu_write_ctx could be considered as a
> separate singleton patch?
I wouldn't touch it in this series at least
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-07 22:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 16:32 [PATCH v4 0/8] Refactor the SMMU's CD table ownership Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-02 16:32 ` [PATCH v4 1/8] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 19:19 ` Nicolin Chen
2023-08-04 19:19 ` Nicolin Chen
2023-08-02 16:32 ` [PATCH v4 2/8] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 19:25 ` Nicolin Chen
2023-08-04 19:25 ` Nicolin Chen
2023-08-02 16:32 ` [PATCH v4 3/8] iommu/arm-smmu-v3: Encapsulate ctx_desc_cfg init in alloc_cd_tables Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 19:27 ` Nicolin Chen
2023-08-04 19:27 ` Nicolin Chen
2023-08-02 16:32 ` [PATCH v4 4/8] iommu/arm-smmu-v3: move stall_enabled to the cd table Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 23:32 ` Nicolin Chen
2023-08-04 23:32 ` Nicolin Chen
2023-08-07 12:21 ` Michael Shavit
2023-08-07 12:21 ` Michael Shavit
2023-08-02 16:32 ` [PATCH v4 5/8] iommu/arm-smmu-v3: Refactor write_ctx_desc Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 20:22 ` Nicolin Chen
2023-08-04 20:22 ` Nicolin Chen
2023-08-07 12:26 ` Michael Shavit
2023-08-07 12:26 ` Michael Shavit
2023-08-02 16:32 ` [PATCH v4 6/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-03 17:56 ` Michael Shavit
2023-08-03 17:56 ` Michael Shavit
2023-08-03 18:47 ` Jason Gunthorpe
2023-08-03 18:47 ` Jason Gunthorpe
2023-08-07 12:19 ` Michael Shavit
2023-08-07 12:19 ` Michael Shavit
2023-08-07 22:41 ` Jason Gunthorpe [this message]
2023-08-07 22:41 ` Jason Gunthorpe
2023-08-04 22:25 ` Nicolin Chen
2023-08-04 22:25 ` Nicolin Chen
2023-08-04 22:46 ` Jason Gunthorpe
2023-08-04 22:46 ` Jason Gunthorpe
2023-08-04 23:11 ` Nicolin Chen
2023-08-04 23:11 ` Nicolin Chen
2023-08-02 16:32 ` [PATCH v4 7/8] iommu/arm-smmu-v3: Skip cd sync if CD table isn't active Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 19:59 ` Nicolin Chen
2023-08-04 19:59 ` Nicolin Chen
2023-08-07 15:02 ` Michael Shavit
2023-08-07 15:02 ` Michael Shavit
2023-08-02 16:32 ` [PATCH v4 8/8] iommu/arm-smmu-v3: Rename cdcfg to cd_table Michael Shavit
2023-08-02 16:32 ` Michael Shavit
2023-08-04 19:31 ` Nicolin Chen
2023-08-04 19:31 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNFzLfemo6joVcsI@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.